Status change of ejecting device in Files App |
|||||||||
Issue descriptionOS: Chrome Hi @tetsui, thanks for implementing the change to make the eject device button accessible in the tab order in the Files App. Can we add an alert to speak the status change aloud once the device is ejected? Once you press Enter to eject the device, it'd be great to get confirmation like "device ejected" so the user knows that it's safe to remove it from the USB drive.
,
Feb 22 2018
,
Feb 28 2018
,
Apr 5 2018
,
Apr 13 2018
,
Jun 19 2018
I guess we can give this back to Luciano as it seems an accessibility fix is required.
,
Jun 20 2018
I didn't know how to interact with screen reader when it wasn't a result of a focus, like on this case it was a result of the umount event finished. I spoke to dtesng@ from ChromeVox team and he suggested that we can use aria-live and/or role=alert, which changes on state of the element with aria-live will be read by ChromeVox. https://www.w3.org/TR/wai-aria-1.1/#aria-live https://www.w3.org/TR/wai-aria-1.1/#alert
,
Jun 20 2018
Issue 537554 has been merged into this issue.
,
Nov 22
,
Nov 22
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24d7413cdbda8ea94970eba748ffd1c11433c5f3 commit 24d7413cdbda8ea94970eba748ffd1c11433c5f3 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Nov 23 03:44:38 2018 Add spoken feedback for ejecting a volume Add a message to screen reader once a volume has been ejected, it uses |speakA11yMessage| function introduced on crrev.com/c/1347956. --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" Test: browser_test Bug: 758638 Change-Id: I16e20f828c05368a41046d71fcfbcf04cfb212f4 Reviewed-on: https://chromium-review.googlesource.com/c/1348880 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#610526} [modify] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/chrome/app/file_manager_strings.grdp [add] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_A11Y_VOLUME_EJECT.png.sha1 [modify] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/24d7413cdbda8ea94970eba748ffd1c11433c5f3/ui/file_manager/integration_tests/file_manager/providers.js
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/915ec100be7e4ded68283627b8a03fca214e04d0 commit 915ec100be7e4ded68283627b8a03fca214e04d0 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Nov 23 05:40:47 2018 Revert "Add spoken feedback for ejecting a volume" This reverts commit 24d7413cdbda8ea94970eba748ffd1c11433c5f3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610526 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjRkNzQxM2NkYmRhOGVhOTQ5NzBlYmE3NDhmZmQxYzExNDMzYzVmMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16380 Sample Failed Step: viz_browser_tests Sample Flaky Test: Providers/FilesAppBrowserTest.Test/providerEject Original change's description: > Add spoken feedback for ejecting a volume > > Add a message to screen reader once a volume has been ejected, it uses > |speakA11yMessage| function introduced on crrev.com/c/1347956. > > --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" > > Test: browser_test > Bug: 758638 > Change-Id: I16e20f828c05368a41046d71fcfbcf04cfb212f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1348880 > Reviewed-by: Anand Mistry <amistry@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610526} Change-Id: Ifbc16215312062cd1593f497d96f1bddde0b2745 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758638 , 851904 Reviewed-on: https://chromium-review.googlesource.com/c/1348737 Cr-Commit-Position: refs/heads/master@{#610540} [modify] https://crrev.com/915ec100be7e4ded68283627b8a03fca214e04d0/chrome/app/file_manager_strings.grdp [delete] https://crrev.com/6325a876f34e5702402e95e0bbf21706a1b21794/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_A11Y_VOLUME_EJECT.png.sha1 [modify] https://crrev.com/915ec100be7e4ded68283627b8a03fca214e04d0/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/915ec100be7e4ded68283627b8a03fca214e04d0/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/915ec100be7e4ded68283627b8a03fca214e04d0/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/915ec100be7e4ded68283627b8a03fca214e04d0/ui/file_manager/integration_tests/file_manager/providers.js
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/437630830a6eae058218f49808dfeea74c45c445 commit 437630830a6eae058218f49808dfeea74c45c445 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Nov 23 06:52:29 2018 Add spoken feedback for ejecting a volume Add a message to screen reader once a volume has been ejected, it uses |speakA11yMessage| function introduced on crrev.com/c/1347956. Test: browser_test --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" Bug: 758638 Change-Id: Id147eac183db099d8ae55f83a4632315c108cb6a Reviewed-on: https://chromium-review.googlesource.com/c/1349154 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#610544} [modify] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/chrome/app/file_manager_strings.grdp [add] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_A11Y_VOLUME_EJECT.png.sha1 [modify] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/437630830a6eae058218f49808dfeea74c45c445/ui/file_manager/integration_tests/file_manager/providers.js |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by zalcorn@chromium.org
, Aug 31 2017