chrome_public_test_apk failing on chromium.linux/Android Tests |
||
Issue descriptionchrome_public_test_apk failing on chromium.linux/Android Tests Builders failed on: - Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests Seeing two recent failures: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/45131 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/45114 java.lang.AssertionError: expected:<192> but was:<512> at org.junit.a.a(Assert.java:88) at org.junit.a.g(Assert.java:834) at org.junit.a.b(Assert.java:645) at org.chromium.chrome.browser.webapps.WebappSplashScreenHomescreenIconTest.testShowFallbackIcon(WebappSplashScreenHomescreenIconTest.java:1631) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at org.junit.runners.a.e.b(FrameworkMethod.java:50) at org.junit.internal.runners.a.c.a(ReflectiveCallable.java:12) at org.junit.runners.a.d.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.c.f.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.c.h.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.chromium.chrome.browser.webapps.WebappActivityTestRule$1.evaluate(WebappActivityTestRule.java:99) at org.junit.a.e.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:175) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:40) at org.junit.runners.e.run(ParentRunner.java:290) at org.junit.runners.c.a(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.d.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:164) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.e.run(ParentRunner.java:290) at org.junit.runners.c.a(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.d.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.e.a(JUnitCore.java:137) at android.support.test.internal.runner.k.a(TestExecutor.java:3115) at android.support.test.runner.a.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:83) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Aug 24 2017
Maybe related: a org.chromium.chrome.browser.webapps.WebappSplashScreenThemeColorTest#testThemeColorWhenSpecified failure at https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/45136
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25509a3d8c0f1b1ca89647087f71ff7f98fa0b54 commit 25509a3d8c0f1b1ca89647087f71ff7f98fa0b54 Author: Piotr Swigon <piotrs@chromium.org> Date: Tue Aug 29 05:16:31 2017 [WebApps] Clears WebappRegistry after each test. Clears WebappRegistry after each test, as it can interfere between test cases. The failure in the linked bug can be easily explained by WebappSplashScreenIconTest running before WebappSplashScreenHomescreenIconTest. TEST_SPLASH_ICON which is 512x512 is left over in the WebappRegistry after WebappSplashScreenIconTest and would be picked up by the WebappSplashScreenHomescreenIconTest.testShowFallbackIcon(), which would fail with the assertion shown in the linked bug. This patch removes there interference between these test cases. Bug: 758636 Change-Id: I38b13076cc4ac3c18bf25a7581e074193fd283ef Reviewed-on: https://chromium-review.googlesource.com/640231 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#498028} [modify] https://crrev.com/25509a3d8c0f1b1ca89647087f71ff7f98fa0b54/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java [modify] https://crrev.com/25509a3d8c0f1b1ca89647087f71ff7f98fa0b54/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java
,
Aug 29 2017
I believe this should not happen anymore. Thank you for notifying me of this. |
||
►
Sign in to add a comment |
||
Comment 1 by zea@chromium.org
, Aug 24 2017Owner: piotrs@chromium.org
Status: Assigned (was: Available)