Perf Custom Merge/Upload Logic for swarming (OBBS) |
||||||||||||||||||||||||||
Issue descriptionNeed a custom merge script for perf (similar to the custom trigger script in crbug.com/758630 ) that collects benchmark results across n devices (where n is the number of devices per unique configuration) and aggregate them up into one result file that is the api between the swarming recipe and the chromium_tests module in the chromium recipe. The perf specific parts of the chromium_tests module will then need to determine how to: 1) pass that information along to upload_perf_dashboard_results.py (ie as one file or y files where y is the number of benchmarks). This is dependent on what apis we have available from the perf and flakiness dashboards. 2) How to interact with the histogram set migration and generate the histogram sets and generate oauth tokens if necessary. ⛆ |
|
|
,
Aug 24 2017
,
Aug 24 2017
,
Aug 25 2017
,
Aug 25 2017
,
Aug 25 2017
,
Sep 8 2017
,
Sep 11 2017
dev notes: https://docs.google.com/document/d/1aZh0kKgt3oFO7V3a-LFE3osJAtXVpapO-2o6VI5vQd4/edit note: martiniss@ is TLing this effort, eyaich@ is doing the dev
,
Sep 18 2017
I think the right direction might be to actually only support histogram set in the recipe code after discussions with Stephen around merging our perf data. Going forward we are going to have two "merge" steps: 1) on one swarming bot to collect results from n/# devices, where n is the number of benchmarks in a run 2) from x swarming bots, where x is the number of devices in a perf configuration We are discussing merging chart json (which isn't super straightforward) but isn't the only problem to solve in this space. We also need to solve merging legacy c++ and histogram alongside chartjson becuase we could have perf results in all three formats. Therefore, Stephen and I are proposing that we convert everything to histogram set (most likely in telemetry so swarming and recipes don't have to care about the other formats) and then we can just concat concat concat and not worry about anything in recipe swarming land. I realize this is easier for us but I promise that is not the only reason I am saying it ;) I think it is the right solution for the long term. Ben/Ethan please comment on the feasibility of this in telemetry. Stephen, please comment on if you agree that this is the best approach in infra.
,
Sep 18 2017
Can you be more specific about what you mean by "merge"? If you literally combine all the json objects into one single json object, I am pretty sure that you gonna hit Python OOM when merging the histogram set or chart json. (in the past, I found that a 200Mb pure json string can take up to 2Gb memory in Python in the object form)
,
Sep 18 2017
I didn't think there were 2 different merge steps. I thought we would only be merging in the 2nd case. The first case you mention about merging results on one swarming bot, I'm not sure if that's a merge as much as just collecting results. I think in that case it's just collecting them, but not merging them. I do agree that moving to histogram set is nice though, as it's just concatenation to merge, which is very easy. Not sure how much work that would be though.
,
Sep 20 2017
#10: Yes Ned, we can't possible pass all the perf results back, we won't be passing any back actually, we will be doing the upload on the swarming post_run recipe step and hopefully invoking a script on src side to do this. The chromium_test recipe will only receive the test results format back from the perf benchmark run. #11: Stephen you are right, your current CL (crrev.com/c/668111) just dumps the perf results into directories and we will grep for them in the post run and upload them. I don't believe we ever need to merge them because we will just covert, upload and then drop. I have a brief design doc coming since I would like input from Ned, Stephen, John budorick on the swarming merge side and Ben/Ethan on the histogram set side of feasibility of this solution.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/233df38a6ec8b9cb03333860cd46730d4e5c55f3 commit 233df38a6ec8b9cb03333860cd46730d4e5c55f3 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Oct 31 19:43:05 2017 //tools/perf: Use trigger script in OBBS tester Attempting to reland https://chromium-review.googlesource.com/c/chromium/src/+/722067 Differences include: Not changing --id to --bot, removing the sys.executable as an argument to the subprocess, and changing --dump_json to --dump-json BUG= chromium:758632 Change-Id: I91bad09256a7e87972c448039c89e308ee5db7f5 Reviewed-on: https://chromium-review.googlesource.com/747074 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#512909} [modify] https://crrev.com/233df38a6ec8b9cb03333860cd46730d4e5c55f3/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/233df38a6ec8b9cb03333860cd46730d4e5c55f3/tools/perf/chromium.perf.fyi.extras.json [modify] https://crrev.com/233df38a6ec8b9cb03333860cd46730d4e5c55f3/tools/perf/perf_device_trigger.py [modify] https://crrev.com/233df38a6ec8b9cb03333860cd46730d4e5c55f3/tools/perf/perf_device_trigger_unittest.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d46d3e12751ab02d3b07c138138231cefbbc6c4e commit d46d3e12751ab02d3b07c138138231cefbbc6c4e Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Nov 02 16:00:21 2017 Reverting json changes to not use custom trigger Revert of part of https://chromium-review.googlesource.com/c/chromium/src/+/747074/ Bug= chromium:758632 Change-Id: I1788ff04b04984d7c4f70f5df3f7772a8551a515 Reviewed-on: https://chromium-review.googlesource.com/748889 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#513502} [modify] https://crrev.com/d46d3e12751ab02d3b07c138138231cefbbc6c4e/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/d46d3e12751ab02d3b07c138138231cefbbc6c4e/tools/perf/chromium.perf.fyi.extras.json
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce368d87f4d78453f58c13697241563468c4ba26 commit ce368d87f4d78453f58c13697241563468c4ba26 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Nov 30 01:31:48 2017 Renaming the merge script to better reflect what it does Also deletes the pretty much empty test cases I had so far since they don't test the functionality that we're keeping in the script. BUG= chromium:758632 Change-Id: I11c59c06392c023c82ed1ca8646fc02e6b46781b Reviewed-on: https://chromium-review.googlesource.com/797533 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#520374} [modify] https://crrev.com/ce368d87f4d78453f58c13697241563468c4ba26/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/ce368d87f4d78453f58c13697241563468c4ba26/tools/perf/chromium.perf.fyi.extras.json [delete] https://crrev.com/49555f1e800a5532895b1e8f3939ee999f1e03ff/tools/perf/core/merge_script.py [delete] https://crrev.com/49555f1e800a5532895b1e8f3939ee999f1e03ff/tools/perf/core/merge_script_unittest.py [delete] https://crrev.com/49555f1e800a5532895b1e8f3939ee999f1e03ff/tools/perf/core/test_data/merge_1.json [delete] https://crrev.com/49555f1e800a5532895b1e8f3939ee999f1e03ff/tools/perf/core/test_data/merge_2.json [add] https://crrev.com/ce368d87f4d78453f58c13697241563468c4ba26/tools/perf/upload_perf_results.py
,
Nov 30 2017
,
Dec 8 2017
,
Dec 8 2017
,
Jan 8 2018
Merge scripts now receive --task-output-dir in addition to the list of shard JSONs.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1443f409d5c48106644e83dd29eb09b7108ad6ab commit 1443f409d5c48106644e83dd29eb09b7108ad6ab Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Jan 30 04:53:32 2018 Creating telemetry_perf_tests_experimental isolate Allows obbs_fyi trybot to run tests without rebuilding chrome Reduces trybot time from an hour and a half to <10 minutes Bug: 758632 Change-Id: I8ab95895111bd8b13533b1f9318a0e7891134fd5 Reviewed-on: https://chromium-review.googlesource.com/887956 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532760} [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/chrome/test/BUILD.gn [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/tools/perf/BUILD.gn [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/tools/perf/chrome_telemetry_build/BUILD.gn [modify] https://crrev.com/1443f409d5c48106644e83dd29eb09b7108ad6ab/tools/perf/chromium.perf.fyi.extras.json
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9bb8ea9d07f494cdff0557eb932b8e8f338907 commit 2c9bb8ea9d07f494cdff0557eb932b8e8f338907 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Jan 30 16:04:13 2018 Adding dependency Turns out pylib is needed to discover all the benchmarks in benchmark_runner Bug: 758632 Change-Id: I1b4d1106c8c32ab87b7431fa9331d67777a925a9 Reviewed-on: https://chromium-review.googlesource.com/893208 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532895} [modify] https://crrev.com/2c9bb8ea9d07f494cdff0557eb932b8e8f338907/tools/perf/BUILD.gn
,
Jan 31 2018
,
Feb 5 2018
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79 commit 96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Feb 08 03:22:47 2018 Custom perf merge/upload logic Still need to generate oauth tokens, locate step name, update a few other small fields, and add tests but wanted to get the updated in progress version checked in. In its current state, it cancels uploading the results because there is no oauth token available. Bug: 758632 Change-Id: Ie861b9518bc16640d0a7cf44a3e1d8c5ca60c8e2 Reviewed-on: https://chromium-review.googlesource.com/893539 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#535286} [modify] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/tools/perf/chromium.perf.fyi.extras.json [add] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/tools/perf/core/results_dashboard.py [add] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/tools/perf/core/results_merger.py [add] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/tools/perf/core/upload_results_to_perf_dashboard.py [add] https://crrev.com/96d6d3fb4a5948629e0a9e9f0b0db465a0d84d79/tools/perf/process_perf_results.py [delete] https://crrev.com/4cbd9a5962a0b48d52c9b7cf3fa69c44dba9a357/tools/perf/upload_perf_results.py
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61da49cb7d445bdae543536021c5b61e48c6aa03 commit 61da49cb7d445bdae543536021c5b61e48c6aa03 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Feb 08 17:50:53 2018 Update naming of files and directories for perf upload Bug: 758632 Change-Id: Id5200664e06375bcaf5715a2fcfd896b9fc001ea Reviewed-on: https://chromium-review.googlesource.com/908713 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#535430} [modify] https://crrev.com/61da49cb7d445bdae543536021c5b61e48c6aa03/tools/perf/process_perf_results.py
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/500b8241fdb7b98b99d990a68c1807687f7eca6a commit 500b8241fdb7b98b99d990a68c1807687f7eca6a Author: Ashley Enstad <ashleymarie@chromium.org> Date: Fri Feb 09 19:40:57 2018 Adding vpython dependency for scripts_smoke_unittest tools/perf/core/results_dashboard imports httplib2 so we need to include that dependency when running tests that depend on results_dashboard. Bug: 758632 , 809563 Change-Id: Ic4ca05d9365ab80b95d1fa1886be07f0417844bb Reviewed-on: https://chromium-review.googlesource.com/908710 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#535788} [modify] https://crrev.com/500b8241fdb7b98b99d990a68c1807687f7eca6a/.vpython [modify] https://crrev.com/500b8241fdb7b98b99d990a68c1807687f7eca6a/tools/perf/core/results_dashboard.py [modify] https://crrev.com/500b8241fdb7b98b99d990a68c1807687f7eca6a/tools/perf/scripts_smoke_unittest.py
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7f3a7aae36398628a474b9d783e123c08849a5b commit b7f3a7aae36398628a474b9d783e123c08849a5b Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Feb 20 20:30:19 2018 Only add the histogram flag if the results are histograms Bug: 758632 Change-Id: I2aa7e817265a5d7bd25823aa47544f53ccc976c1 Reviewed-on: https://chromium-review.googlesource.com/926567 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#537867} [modify] https://crrev.com/b7f3a7aae36398628a474b9d783e123c08849a5b/testing/scripts/run_performance_tests.py [modify] https://crrev.com/b7f3a7aae36398628a474b9d783e123c08849a5b/tools/perf/process_perf_results.py
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86e44bb82716a95e8b87878cb59e2f8613c800f1 commit 86e44bb82716a95e8b87878cb59e2f8613c800f1 Author: Emily Hanley <eyaich@google.com> Date: Wed Feb 21 16:59:13 2018 Remove uploading of the ref build to the flakiness dashboard. Now that we are running both the reference and non reference builds in the same trigger, there is no way to merge two of the same tests under the same step name (performance_test_suite is our test name now). Bug: 758632 Change-Id: I2cdd2ec1f96f880fc11046ef7aab8dacea0baee5 Reviewed-on: https://chromium-review.googlesource.com/928786 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#538136} [modify] https://crrev.com/86e44bb82716a95e8b87878cb59e2f8613c800f1/tools/perf/process_perf_results.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9860fc151092df2dcaa40f6b1111e977a237f495 commit 9860fc151092df2dcaa40f6b1111e977a237f495 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Feb 22 01:29:12 2018 Generate oauth token for perf dashboard upload Bug: 758632 Change-Id: Ie7d4d7687cb4f54b1172506060c40c399295f90d Reviewed-on: https://chromium-review.googlesource.com/926914 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#538301} [modify] https://crrev.com/9860fc151092df2dcaa40f6b1111e977a237f495/testing/buildbot/chromium.perf.fyi.json [add] https://crrev.com/9860fc151092df2dcaa40f6b1111e977a237f495/tools/perf/core/oauth_api.py [modify] https://crrev.com/9860fc151092df2dcaa40f6b1111e977a237f495/tools/perf/process_perf_results.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b5a86c8791e7b877abc3c6982a1242d3a7a69a8 commit 6b5a86c8791e7b877abc3c6982a1242d3a7a69a8 Author: Emily Hanley <eyaich@google.com> Date: Thu Feb 22 19:05:09 2018 Cleaning up flags in src side upload script. Bug: 758632 Change-Id: I648b732c41ee22be7fec63acac678e33c81b5588 Reviewed-on: https://chromium-review.googlesource.com/931742 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538510} [modify] https://crrev.com/6b5a86c8791e7b877abc3c6982a1242d3a7a69a8/tools/perf/core/results_dashboard.py [modify] https://crrev.com/6b5a86c8791e7b877abc3c6982a1242d3a7a69a8/tools/perf/core/upload_results_to_perf_dashboard.py [modify] https://crrev.com/6b5a86c8791e7b877abc3c6982a1242d3a7a69a8/tools/perf/process_perf_results.py
,
Feb 23 2018
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/391a1ccc52ae5b110b841b3ac428103087414dbb commit 391a1ccc52ae5b110b841b3ac428103087414dbb Author: Ashley Enstad <ashleymarie@chromium.org> Date: Sat Feb 24 10:11:08 2018 Fixing oauth token for histogram upload We were passing the json {"token":"asdf...","expiry":123} instead of just the token Bug: 758632 Change-Id: Ic5bb57dcf608f2f00ba2cbee05271cc249927437 Reviewed-on: https://chromium-review.googlesource.com/935288 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#539008} [modify] https://crrev.com/391a1ccc52ae5b110b841b3ac428103087414dbb/tools/perf/core/oauth_api.py
,
Feb 26 2018
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/282ef55d16d870e93c6f08883a028ee08b9a906d commit 282ef55d16d870e93c6f08883a028ee08b9a906d Author: Emily Hanley <eyaich@google.com> Date: Tue Mar 06 18:14:12 2018 Stop attempting to upload disabled benchmarks to the perf dashboard. Bug: 758632 Change-Id: I349304391fb8dc8bcb805cc1f69e09aebdd5232b Reviewed-on: https://chromium-review.googlesource.com/951413 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#541147} [modify] https://crrev.com/282ef55d16d870e93c6f08883a028ee08b9a906d/tools/perf/process_perf_results.py
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0db14a699570c1061a326399ef53e3a808643b commit 7d0db14a699570c1061a326399ef53e3a808643b Author: Emily Hanley <eyaich@google.com> Date: Wed Mar 07 19:01:56 2018 Switching buildbot tester to only run subset of benchmarks. Bug: 758632 Change-Id: I05afa2de700600c4082ddca82fca8fbbd2cab3c4 Reviewed-on: https://chromium-review.googlesource.com/953067 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541519} [modify] https://crrev.com/7d0db14a699570c1061a326399ef53e3a808643b/BUILD.gn [modify] https://crrev.com/7d0db14a699570c1061a326399ef53e3a808643b/chrome/test/BUILD.gn [modify] https://crrev.com/7d0db14a699570c1061a326399ef53e3a808643b/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/7d0db14a699570c1061a326399ef53e3a808643b/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/7d0db14a699570c1061a326399ef53e3a808643b/tools/perf/core/benchmark_bot_map.json
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e3b2cc0580556623a69a1f993a8b20772ab41f commit b8e3b2cc0580556623a69a1f993a8b20772ab41f Author: Emily Hanley <eyaich@google.com> Date: Fri Mar 09 07:29:54 2018 fixing deps for experimental build Bug: 758632 Change-Id: I33c62a8c7ce7d8afd47021dc9833bf739dd26696 Reviewed-on: https://chromium-review.googlesource.com/956089 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542056} [modify] https://crrev.com/b8e3b2cc0580556623a69a1f993a8b20772ab41f/tools/perf/BUILD.gn
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4475e4803094f42a8933d4b0426423636652f094 commit 4475e4803094f42a8933d4b0426423636652f094 Author: Emily Hanley <eyaich@google.com> Date: Fri Mar 09 07:59:47 2018 Adding null checks if telemetry crashes and doesn't produce results Also updating what tests run on each shard to help debug the failing tests. Bug: 758632 Change-Id: Ib0eb60f0b9ae7e3a2cd19ae8c1f8183d4d0b7d81 Reviewed-on: https://chromium-review.googlesource.com/955676 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542060} [modify] https://crrev.com/4475e4803094f42a8933d4b0426423636652f094/testing/scripts/run_performance_tests.py [modify] https://crrev.com/4475e4803094f42a8933d4b0426423636652f094/tools/perf/core/benchmark_android_bot_map.json [modify] https://crrev.com/4475e4803094f42a8933d4b0426423636652f094/tools/perf/core/benchmark_desktop_bot_map.json [modify] https://crrev.com/4475e4803094f42a8933d4b0426423636652f094/tools/perf/process_perf_results.py
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7a01706593e214bbb25bc324dde00ba91cfd088 commit f7a01706593e214bbb25bc324dde00ba91cfd088 Author: Emily Hanley <eyaich@google.com> Date: Fri Mar 09 20:58:18 2018 Triggering jobs on new macbook airs Bug: 758632 Change-Id: I7fc16ec27f1e24978c85c0b4a58970b19ffc5045 Reviewed-on: https://chromium-review.googlesource.com/955924 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#542217} [modify] https://crrev.com/f7a01706593e214bbb25bc324dde00ba91cfd088/chrome/test/BUILD.gn [modify] https://crrev.com/f7a01706593e214bbb25bc324dde00ba91cfd088/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/f7a01706593e214bbb25bc324dde00ba91cfd088/tools/perf/process_perf_results.py
,
Mar 26 2018
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c85ee8867820877b2c9d813229e07f2ae028e42 commit 5c85ee8867820877b2c9d813229e07f2ae028e42 Author: Emily Hanley <eyaich@google.com> Date: Fri Apr 13 16:56:26 2018 Do a check for git_revision for tryserver jobs Bug: 758632 Change-Id: I12b77b94313845e2b38d03313915a23663363a5e Reviewed-on: https://chromium-review.googlesource.com/1011574 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550654} [modify] https://crrev.com/5c85ee8867820877b2c9d813229e07f2ae028e42/tools/perf/process_perf_results.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c85ee8867820877b2c9d813229e07f2ae028e42 commit 5c85ee8867820877b2c9d813229e07f2ae028e42 Author: Emily Hanley <eyaich@google.com> Date: Fri Apr 13 16:56:26 2018 Do a check for git_revision for tryserver jobs Bug: 758632 Change-Id: I12b77b94313845e2b38d03313915a23663363a5e Reviewed-on: https://chromium-review.googlesource.com/1011574 Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550654} [modify] https://crrev.com/5c85ee8867820877b2c9d813229e07f2ae028e42/tools/perf/process_perf_results.py
,
Jul 30
,
Dec 22
""" # Temporary target for running benchmarks without building Chrome # Will be removed as a part of crbug.com/758632 group("telemetry_perf_tests_without_chrome") { testonly = true deps = [ "//tools/perf/:perf_without_chrome", ] data_deps = [ "//testing:run_perf_test", ] } """ https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=run_perf_test&sq=package:chromium&dr=C&l=2243
,
Dec 22
Can we remove the target?
,
Dec 22
No, that target is actually useful for other purposes. It's better to just remove the the comment
,
Dec 22
,
Dec 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34302eb571e3aab49b8bb72f368fc00ac211c6da commit 34302eb571e3aab49b8bb72f368fc00ac211c6da Author: Ned Nguyen <nednguyen@google.com> Date: Sat Dec 22 01:25:33 2018 Remove obsolete comment in chrome/test/BUILD.gn telemetry_perf_tests_without_chrome is useful for testing chrome reference binary without building Chrome, running test infras against different versions of Chrome binary, so it's useful to be kept. Bug: 758632 Change-Id: Ieb14309ef543bf09815023953d8da643fc40c6d8 Reviewed-on: https://chromium-review.googlesource.com/c/1389496 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#618705} [modify] https://crrev.com/34302eb571e3aab49b8bb72f368fc00ac211c6da/chrome/test/BUILD.gn |
|||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by eyaich@chromium.org
, Aug 24 2017