New issue
Advanced search Search tips

Issue 758628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Update //third_party/WebKit/LayoutTests/device_orientation/ to use testharness.js instead of js-test.js

Project Member Reported by juncai@chromium.org, Aug 24 2017

Issue description

Currently the device orientation and device motion layout tests use js-test.js. It would be better to update them to use testharness.js.
 

Comment 1 by juncai@chromium.org, Aug 24 2017

Status: Started (was: Assigned)

Comment 2 by juncai@chromium.org, Aug 24 2017

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d1dd5dc13903c2ee1af125f0d4b8d474057563

commit 58d1dd5dc13903c2ee1af125f0d4b8d474057563
Author: Jun Cai <juncai@chromium.org>
Date: Wed Sep 06 18:05:39 2017

Update device motion layouttests using testharness.js instead of js-test.js

This CL updates //third_party/WebKit/LayoutTests/device_orientation/motion
to use testharness.js instead of js-test.js.

Bug:  758628 
Change-Id: I44d476cee1126a0c810e3dc2e217e7156e4a74d1
Reviewed-on: https://chromium-review.googlesource.com/644312
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500008}
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/add-during-dispatch-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/add-during-dispatch.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/add-listener-from-callback-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/add-listener-from-callback.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/create-event-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/create-event.html
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/detached-frame.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/fire-last-event-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/fire-last-event.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/multiple-event-listeners-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/multiple-event-listeners.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/null-values-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/null-values.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/page-visibility-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/page-visibility.html
[delete] https://crrev.com/73b1c29d60d341229f52e54da5293c268b04a6c4/third_party/WebKit/LayoutTests/device_orientation/motion/window-property-expected.txt
[modify] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/motion/window-property.html
[add] https://crrev.com/58d1dd5dc13903c2ee1af125f0d4b8d474057563/third_party/WebKit/LayoutTests/device_orientation/resources/device-orientation-helpers.js

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db41a37062a493327eb216867fca603afaa553a0

commit db41a37062a493327eb216867fca603afaa553a0
Author: Jun Cai <juncai@chromium.org>
Date: Mon Oct 30 18:44:21 2017

Update device orientation layouttests using testharness.js instead of js-test.js

This CL updates //third_party/WebKit/LayoutTests/device_orientation/orientation
to use testharness.js instead of js-test.js.

Bug:  758628 
Change-Id: I8be7a93cdd9e0bca1a168f91c165c119e02ca1cd
Reviewed-on: https://chromium-review.googlesource.com/677634
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512550}
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/add-listener-from-callback-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/add-listener-from-callback.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-absolute-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-absolute.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/create-event-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/create-event.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-event-listeners-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-event-listeners.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-frames-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-frames.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/no-synchronous-events-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/no-synchronous-events.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/null-values-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/null-values.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/page-visibility-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/page-visibility.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/resources/basic-operation.js
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/updates-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/updates.html
[delete] https://crrev.com/41478570e45309fce0ba795c1921ee8769dcdb7e/third_party/WebKit/LayoutTests/device_orientation/orientation/window-property-expected.txt
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/orientation/window-property.html
[modify] https://crrev.com/db41a37062a493327eb216867fca603afaa553a0/third_party/WebKit/LayoutTests/device_orientation/resources/device-orientation-helpers.js

Comment 5 by juncai@chromium.org, Oct 30 2017

Status: Fixed (was: Started)

Sign in to add a comment