Issue metadata
Sign in to add a comment
|
Gerrit Feature: Make it easier to see which patchset was used for running tryjobs |
||||||||||||||||||||||
Issue descriptionWhen the user updates the commit message new patchsets are created. These patchsets at least visually "inherit" the trybot runs from the previous patchset. As a result it's hard to see which patchset actually created a set of trybot results. Here is an example: https://skia-review.googlesource.com/c/skia/+/38140/5 Currently, when a user looks a patchset 5 they see a set of buildbot results that were created by patchset 1. It would be helpful if there was a note to the effect of "these trybot results were created by patchset 1".
,
Aug 24 2017
Moved to chromium because this has to do with the buildbucket plugin. Another option for little grey text "These results inherited from patchset 1".
,
Aug 28 2017
That's actually a great idea, implemented here: https://chromium-review.googlesource.com/639713 Screenshot: https://screenshot.googleplex.com/a1xYe5614qq
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/db22171e3536f79696753cc3f241d82758e28c05 commit db22171e3536f79696753cc3f241d82758e28c05 Author: Aaron Gable <agable@chromium.org> Date: Mon Aug 28 23:55:51 2017 Display which patchsets shown builds are from The plugin often shows builds which were actually triggered on one or more prior patchsets (e.g. because the current or intervening patchsets were trivial rebases). This can be confusing, so show which patchsets are having their builds shown in the plugin header bar. R=tandrii@chromium.org Bug: 758624 Change-Id: I25ba38602916d14a60f4e7e4ee6590463e8dfb40 Reviewed-on: https://chromium-review.googlesource.com/639713 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/db22171e3536f79696753cc3f241d82758e28c05/src/main/resources/static/cr-buildbucket-view.html [modify] https://crrev.com/db22171e3536f79696753cc3f241d82758e28c05/README.md [modify] https://crrev.com/db22171e3536f79696753cc3f241d82758e28c05/src/main/resources/static/cr-buildbucket-view.js
,
Aug 29 2017
Importing with cl/166778363. Will be deployed later this week, probably. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmis...@google.com
, Aug 24 2017