I'm seeing this hit in what I believe is the Crashpad handler's handler.
#if !defined(OS_NACL)
// static
bool GlobalHistogramAllocator::CreateWithFile(
const FilePath& file_path,
size_t size,
uint64_t id,
StringPiece name) {
bool exists = PathExists(file_path);
File file(
file_path, File::FLAG_OPEN_ALWAYS | File::FLAG_SHARE_DELETE |
File::FLAG_READ | File::FLAG_WRITE);
std::unique_ptr<MemoryMappedFile> mmfile(new MemoryMappedFile());
if (exists) {
size = saturated_cast<size_t>(file.GetLength());
mmfile->Initialize(std::move(file), MemoryMappedFile::READ_WRITE);
} else {
mmfile->Initialize(std::move(file), {0, static_cast<int64_t>(size)},
MemoryMappedFile::READ_WRITE_EXTEND);
}
if (!mmfile->IsValid() ||
!FilePersistentMemoryAllocator::IsFileAcceptable(*mmfile, true)) {
NOTREACHED() << file_path; <<< HERE
return false;
}
Set(WrapUnique(new GlobalHistogramAllocator(
std::make_unique<FilePersistentMemoryAllocator>(std::move(mmfile), size,
id, name, false))));
Get()->SetPersistentLocation(file_path);
return true;
}
I don't think this is user-visible, but I think it means we get no metrics from the fallback handler?
Comment 1 by siggi@chromium.org
, Aug 24 2017Cc: bcwh...@chromium.org mark@chromium.org
Summary: NOTREACHED in GlobalHistogramAllocator::CreateWithFile in crashpad-handler (was: NOTREACHED in GlobalHistogramAllocator::CreateWithFile)