Weird getComputedStyle value for pseudo-elements on layout-dependent properties. |
|||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Open attached test-case. What is the expected result? "auto" is alerted, since it's the default computed value for the width property. What happens instead? The width of the element, not the pseudo-element, is alerted.
,
Aug 24 2017
The issue is that we grab the styled_node's LayoutObject in getPropertyCSSValue, but styled_node is the element if there's no pseudo-element.
,
Aug 27 2017
Seems an easy fix, so will take it. These kind of web-compat issues annoy me :) Patch at https://chromium-review.googlesource.com/c/chromium/src/+/636965, tests at https://github.com/w3c/web-platform-tests/pull/7020.
,
Aug 28 2017
,
Aug 28 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b44fcea5be6799309c5445a9b4d60ee9fe88509 commit 8b44fcea5be6799309c5445a9b4d60ee9fe88509 Author: Emilio Cobos Álvarez <emilio@chromium.org> Date: Tue Aug 29 02:25:38 2017 [cssom] Don't use the element layout object when querying a non-existent pseudo. BUG= 758596 Change-Id: I6defc3ce03d9f3cd80cec770d9412e55dfbd9580 Reviewed-on: https://chromium-review.googlesource.com/636965 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#497990} [delete] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/third_party/WebKit/LayoutTests/external/wpt/cssom/getComputedStyle-pseudo-expected.txt [modify] https://crrev.com/8b44fcea5be6799309c5445a9b4d60ee9fe88509/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt [modify] https://crrev.com/8b44fcea5be6799309c5445a9b4d60ee9fe88509/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html [modify] https://crrev.com/8b44fcea5be6799309c5445a9b4d60ee9fe88509/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/8b44fcea5be6799309c5445a9b4d60ee9fe88509/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h
,
Aug 29 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eco...@igalia.com
, Aug 24 2017