New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758570 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 750084
issue 694255



Sign in to add a comment

Remove marking deque overflow handling

Project Member Reported by mlippautz@chromium.org, Aug 24 2017

Issue description

We have switched to work lists that rely on segments quite a while ago and should remove marking deque overflow handling.

Failing to allocate a segment will result in OOM.
 
Blocking: 750084
Blocking: 694255
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4e5db9a6c859df7af95a92e7cf4e530faa49a765

commit 4e5db9a6c859df7af95a92e7cf4e530faa49a765
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Sep 19 05:20:20 2017

[heap] Remove marking deque overflow handling

Removes
- SequentialMarkingDeque
- The ability to handle marking deque overflow
- BlackToGrey transitions

We switched to a different marking work list on M61 that fails
in OOM upon failing to allocate Segments used in the work list.

Bug:  chromium:758570 
Change-Id: I66e2ab912271bf84b085dccc9b4bdd96076b64fb
Reviewed-on: https://chromium-review.googlesource.com/632676
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48078}
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/BUILD.gn
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/heap.cc
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/incremental-marking.cc
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/mark-compact-inl.h
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/mark-compact.cc
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/mark-compact.h
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/heap/marking.h
[delete] https://crrev.com/59e4b75187000d82ffe15417feb063ed69bed532/src/heap/sequential-marking-deque.cc
[delete] https://crrev.com/59e4b75187000d82ffe15417feb063ed69bed532/src/heap/sequential-marking-deque.h
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/src/v8.gyp
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/test/cctest/heap/test-mark-compact.cc
[modify] https://crrev.com/4e5db9a6c859df7af95a92e7cf4e530faa49a765/test/unittests/heap/marking-unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0257c539bbee2e475af843d347a506173c0c34f7

commit 0257c539bbee2e475af843d347a506173c0c34f7
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Sep 20 05:28:55 2017

[heap] Remove clear on tearing down marking work list when not marking

The work list should be empty in the case we are not tearing down
during incremental marking. Explicitly clear during incremental marking
and rely on DCHECKs for the other case.

Bug:  chromium:758570 
Change-Id: Iecc8935f0cbfda67f0e7afde42930050e7c94d2d
Reviewed-on: https://chromium-review.googlesource.com/674504
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48087}
[modify] https://crrev.com/0257c539bbee2e475af843d347a506173c0c34f7/src/heap/mark-compact.cc
[modify] https://crrev.com/0257c539bbee2e475af843d347a506173c0c34f7/src/heap/mark-compact.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b2ef3777d71f5321624405cc6e66e6585ebbdc31

commit b2ef3777d71f5321624405cc6e66e6585ebbdc31
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Sep 20 05:59:06 2017

[heap] Remove ProcessMarkingWorklist

Bug:  chromium:758570 
Change-Id: Ia2bd72c1756fbc4062c62d975e25bb0ca209a6ad
Reviewed-on: https://chromium-review.googlesource.com/674465
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48089}
[modify] https://crrev.com/b2ef3777d71f5321624405cc6e66e6585ebbdc31/src/heap/mark-compact.cc
[modify] https://crrev.com/b2ef3777d71f5321624405cc6e66e6585ebbdc31/src/heap/mark-compact.h

Status: Fixed (was: Assigned)

Sign in to add a comment