Remove feature flag and kill switch for site notification channels |
|||||||
Issue descriptionIn M62 on Android O we will turn on site notification channels by default, but keep the feature flag and unmigration code as a kill switch just in case. After at least one stable release if no problems ensue we can probably remove the flag and unmigration code.
,
Aug 31 2017
we will also be able to properly deprecate the generic 'Sites' notification channel when the feature flag is gone.
,
Oct 4 2017
The NextAction date has arrived: 2017-10-04
,
Oct 4 2017
Updating NextAction date to one week after stable release of M62.
,
Oct 24 2017
The NextAction date has arrived: 2017-10-24
,
Nov 13 2017
Kill switch was just triggered for 62 so we should let this settle for another release or two. Updating next action date accordingly.
,
Jan 11 2018
The NextAction date has arrived: 2018-01-11
,
Jan 15 2018
Hi Anita, please can you comment on whether the Kill switch was triggered after your comment of Nov 13th? If not, we can remove this flag and code now. Thanks!
,
Jan 15 2018
Thanks for the ping. Indeed the kill switch has not been triggered since #6 in either 63 or 64 so we can and should delete this code for 65+.
,
Jan 16 2018
,
Jan 16 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab5b237fab7d5fa83b50601ff58bd4c6eec94234 commit ab5b237fab7d5fa83b50601ff58bd4c6eec94234 Author: Anita Woodruff <awdf@chromium.org> Date: Wed May 30 16:10:35 2018 [Android Notifications] Remove kill switch for site channels - This feature flag enabled separate notification channels for notifications from different origins on Android O. (It had no effect on other platforms because notification channels only exist on Android O+). - Since the feature flag has now been enabled by default for two beta releases and one stable release (M63) with no reported issues, we can be reasonably confident that we no longer require a kill switch for this feature, so the flag and 'unmigration' code can now be removed. Bug: 758553 Change-Id: Icfacc58ed30db2c0ee7ad220411b5cf9af3c3237 Reviewed-on: https://chromium-review.googlesource.com/868654 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#562858} [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitions.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/SiteChannelsManager.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/browser/content_settings/host_content_settings_map_factory.cc [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/browser/notifications/notification_channels_provider_android.cc [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/browser/notifications/notification_channels_provider_android.h [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/browser/notifications/notification_channels_provider_android_unittest.cc [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/common/chrome_features.cc [modify] https://crrev.com/ab5b237fab7d5fa83b50601ff58bd4c6eec94234/chrome/common/chrome_features.h
,
May 30 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by awdf@chromium.org
, Aug 24 2017NextAction: 2017-10-04
Status: Available (was: ExternalDependency)