New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758548 link

Starred by 2 users
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 758555



Sign in to add a comment

Arrange UiElements into a hierarchy

Project Member Reported by vollick@chromium.org, Aug 24 2017 
This should mean that
 * every UiElement, save the root, will have a parent.
 * parents will own their children
 * UiScene methods can become recursive functions on this tree
 * Hiding subtrees can be accomplished by setting the opacity of the subtree's root.

Comment 1 by vollick@chromium.org, Aug 24 2017

Blocking: 758555
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/180b50c651973bbab37552adb4215fd83f3b437f

commit 180b50c651973bbab37552adb4215fd83f3b437f
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Aug 28 20:55:18 2017

[vr] Arrange UiElements in a hierarchy

Certain operations (like, say, hiding a swath of related elements) are
simplified if the elements are arranged in a well-defined hierarchy.

This CL attempts to arrange the elements in such a hierarchy, but does
not currently leverage this structure. Since there is a fair bit of
churn in this CL, I've tried to minimize behavior changes so that the
CL is easier to review and to reduce risk.

Bug:  758548 
Change-Id: I438b0ef9675a94920020c892a26f5123c3ff3b07
Reviewed-on: https://chromium-review.googlesource.com/638130
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497870}
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/draw_phase.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/linear_layout.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/linear_layout_unittest.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/ui_element.h
[rename] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/viewport_aware_root.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/elements/viewport_aware_root_unittest.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/180b50c651973bbab37552adb4215fd83f3b437f/chrome/browser/vr/ui_scene_unittest.cc

Comment 3 by vollick@chromium.org, Sep 21 2017

Owner: vollick@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment