Regression:Bookmark bar drop down does not expand/collapse on double click on chrome://bookmarks.
Reported by
aiman.an...@etouch.net,
Aug 24 2017
|
||||
Issue descriptionChrome version: 62.0.3194.0 (Official Build)c14400a94cb4f43e0e9b02e59e93cf5a082c6408-refs/heads/master@{#496533}(64-bit) OS: Win (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6). Steps to reproduce: 1.Launch chrome, open two NTP, right click on NTP and select ‘Bookmark all tabs’. (Kindly refer Screen-Cast video). 2.On chrome://bookmarks/, double click on Bookmark Bar folder. 3.Observe. Actual Result:Bookmark bar drop down does not expand/collapse on double click. Expected Result:Bookmark bar drop down should expand/collapse on double click. This is Regression Issue broken in M-61 and will soon provide other bisect info. Manual Bisect Info: Good Build: 61.0.3138.0 Bad Build: 61.0.3139.0
,
Aug 24 2017
Using the per-revision bisect providing the bisect results, Good build: 61.0.3138.0(Revision: 481386). Bad build: 61.0.3139.0 (Revision: 481757). You are probably looking for a change made after 481443 (known good), but no later than 481444 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/02958eaa8c765b0bc65c020bb1dd1d1fd0792de0..ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228 From the CL above, assigning the issue to the concern owner @calamity- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2924383003 Thanks!
,
Aug 24 2017
adding RBS, please change if required
,
Aug 25 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ed1103a2f27abd107bb22ae0228b925bca6c048 commit 8ed1103a2f27abd107bb22ae0228b925bca6c048 Author: Christopher Lam <calamity@chromium.org> Date: Mon Aug 28 02:07:06 2017 [MD Bookmarks] Make double click toggle folders in sidebar. This CL makes the folder items in the sidebar open and close when double clicked. Bug: 758538 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I45a37bb14981bf33175d51b6ca7578a7c298e624 Reviewed-on: https://chromium-review.googlesource.com/633319 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#497687} [modify] https://crrev.com/8ed1103a2f27abd107bb22ae0228b925bca6c048/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/8ed1103a2f27abd107bb22ae0228b925bca6c048/chrome/browser/resources/md_bookmarks/folder_node.js
,
Sep 25
Based on #5, this appears fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by aiman.an...@etouch.net
, Aug 24 2017