Attaching expected Video

Deleted: Expected_Focus.mp4 12.6 MB

	Expected_Focus.mp4 12.6 MB View Download

This is not a Blink issue.

@estade is this something you could look into? It seems like the focus stay on the info bubble, and should go back to the system menu if the user presses <Esc>, <Enter>, <Space>, etc.

Any update on this bug? We are going for a stable RC next week and this is marked as a blocker. 

I don't work in this space any more so I can't guarantee I'll have time to look at it soon. If it's truly a blocker, someone on Chrome OS UI should prioritize it.

Any update on this one? We are planning to build a R62 stable RC the evening of the 19th, so we would need to have all fixes merged back to 62 in ~24 hours. 

Albert, do you know whom would own this?

Upping priority as we build the R62 stable RC tomorrow, we need a fix in the next 24 hours.

@zork can someone on your team look at this?

To be clear, the problem I'm seeing is:
1) Use tab to select "Network info" icon
2) Press enter to open network info bubble
3) Press esc to close network info bubble
4) Press tab

Expected: at 4, focus should be returned to system menu
Actual: focus actually returns to the active window when the network bubble is dismissed.

I don't think pressing "tab" while the network info bubble is open requires moving focus to the next item, but focus should return to the system menu if the bubble is closed.

Daisy, could you have someone look into this?

I can do a quick bisect on this.

Turns out it's a time-consuming bisect because of a bad Chrome crash between the good and bad version which caused some trouble for bisecting. (the CL that caused the crash has been reverted later)

The culprit CL: https://codereview.chromium.org/2958693002. Assign to the owner to fix it.

Let me clarify what is the issue here. The issue here is that focus goes back to the active window when network info bubble is closed. The focus should move to the system tray. But IIUC, this hasn't worked in the way even before my CL. 

Before my CL, system tray was closed when you press Tab key while info bubble is shown. I assume that KeyEventWatcher in SystemTray was capturing Esc key event and closed the tray.

In summary, steps reproduce would be
1. Open a Chrome window.
2. Open system tray by Alt+Shift+S
3. Press Tab key to move focus to network options, and press enter to open it.
4. Press Tab key to move focus to info icon, and press enter to open it.
5. Press Esc key.
6. Press Tab key.

Expected behavior: focus moves on the system tray.
Actual behavior after the CL (61.0.3142.0 or later): focus moves to the Chrome window. System tray is left open.
Actual behavior before the CL: system tray is closed.

For pressing Tab key, it's okay with current behavior (i.e. nothing happens with Tab key).

tbuckley@: Please confirm that this is the issue or not. Also, can we remove Release-Block-Stable? I don't think this is regression from that point of view.

@yawano, your description of the issue is correct.

The behavior before the CL is preferable to the behavior after, though I agree the ideal is to return focus to the system menu. Is it possible to fix with 64?

Uploaded a fix at https://crrev.com/c/768526 to move the focus back to the system menu after the bubble is closed.

To confirm the behavior, pressing esc key for info bubble behaves differently depending on how user has opened the bubble.
If user has opened the bubble by keyboard, it behaves as the expected behavior in comment 12. Only the bubble closes.
But if user has opened the bubble by mouse, pressing esc key for info bubble closes the tray.

tbuckley@: I think the difference should be reasonable. If user is interacting with the tray by keyboard, the user will want to keep navigating on the tray by using keyboard rather than the tray itself is closed. Let me know if you don't think this difference is reasonable.

Also can I ask you to remove Release-Block-Stable-M63 if it is okay to be fixed in M64?

tbuckley@: ping.

We should have consistent behavior across the two cases. If the user has tapped escape, it means they have switched to keyboard navigation and may want to continue it. Would it be difficult to have only the bubble close in both cases?

Removed ReleaseBlock-Stable for M63.

Thank you! I have an idea why it closes the tray for the later case. I'll investigate how it can be fixed.

I found the way to fix the later case. I'll fix the later case with another CL.

Fix for the later case is in review at https://crrev.com/c/776255

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c57843e97f285c4fa0604bc8c59b4d952837912

commit 5c57843e97f285c4fa0604bc8c59b4d952837912
Author: Yuki Awano <yawano@chromium.org>
Date: Fri Nov 17 08:26:02 2017

Activate the widget if info bubble is destoryed

- Widget of info bubble is activated while the bubble is shown. Activate
  the widget of network list if info bubble is destoryed to move the
  focus back to the list.

Bug:  758530 
Test: confirm the behavior as described in the issue.
Change-Id: I9af52ce28f291c2d698da27a3b0c0824c2ddd84e
Reviewed-on: https://chromium-review.googlesource.com/768526
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517341}
[modify] https://crrev.com/5c57843e97f285c4fa0604bc8c59b4d952837912/ash/system/network/network_state_list_detailed_view.cc

+sgabriel@

This UI has been problematic to maintain, specifically the small information bubble that appears when the (i) icon is clicked in the Network Tray.

What would you think of showing the additional info inline, i.e. expanding the header area to show the extra lines of text (usually 2 lines, 3 if ipv6 is available)?

sgabriel@: ping.

I've created a spec based on the implementation of our network warning in VPN:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZR34IMaWJcOe/files/MCFpGID3uboHAdeaZOIWPyPMwMSJbxAVNpw. 

The spec is available here and also attached:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZR34IMaWJcOe/files/MCFpGID3uboHAeYL6dyzNNKvwMSJbxAVNpw.

It would appear on click on the info icon, on top of all network section and content, pushing them down.
It would scroll up.
In term of motion, could we use simple EASE_IN_OUT curve slide down over 240ms?

Deleted: network info bubble 2.png 70.4 KB

	network info bubble 2.png 70.4 KB View Download

Filed issue 789868 for redesign work. Let's keep this issue as a bug with the current info bubble design, and use the bug for new design work.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c78ffabce240f2be847e12bbbec00b677a43c8

commit 31c78ffabce240f2be847e12bbbec00b677a43c8
Author: Yuki Awano <yawano@chromium.org>
Date: Tue Dec 12 09:34:54 2017

Do not reroute events for the tray

- Do not reroute events if it is targetted to the tray or its
  descendants, or if target of the event has window of the tray as a
  transient ancestor.
- When network info bubble is shown, the bubble is active but the tray
  itself is not active. The bubble is shown as another widget. The
  bubble should receive key events in this case. If the handler reroutes
  key events in this case, the tray is closed when esc key is pressed
  while the bubble is shown.

      information icon. Press esc key to close the info bubble. Confirm
      that it only closes the info bubble.

Bug:  758530 
Test: Open network section of system tray by click. Click the
Change-Id: I0df0c81e4df28785f16fdefb9af37a73f00ef604
Reviewed-on: https://chromium-review.googlesource.com/776255
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523384}
[modify] https://crrev.com/31c78ffabce240f2be847e12bbbec00b677a43c8/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/31c78ffabce240f2be847e12bbbec00b677a43c8/ui/views/bubble/tray_bubble_view.cc

Fix for the later case has landed on M65: pressing esc key while info bubble is open should close the bubble, not the system tray.

tbuckley@: I'm going to close this issue without merging the fix to M64. But please re-open this if you think the fix should be merged to M64. Thanks.