Payment egtests fail on iOS device |
|||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): M62 iOS Version: All Device: Sample run https://uberchromegw.corp.google.com/i/internal.bling.main/builders/canary-device/builds/1219 https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/clang-tot-device/builds/3371 Note: tests don't run on devices on main waterfall. I am not sure this is intended.
,
Aug 25 2017
AFAIK these tests need the WebPayments flag to run correctly. Looking into this. (also removed rayraymond@, whose internship has ended)
,
Aug 25 2017
lod@ The failures you linked to are due to the following error:
[0825/043626.576305:ERROR:crw_web_controller.mm(2473)] JavaScript error: TypeError: function is not a constructor (evaluating 'new DOMException("Request cancelled", "AbortError")') URL:http://127.0.0.1:52487/components/test/data/payments/payment_request_name_test.html
These tests should be skipped in iOS versions below 10.3. Why are they running in the first place?
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm?l=103
,
Aug 25 2017
The tests that have the guard (like testOpenAndCancel) do not run. Most tests don't have the 10.3 guard https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm?l=166 Should we add one for all tests in the suite?
,
Aug 25 2017
olivierrobin@, i think you and lod@ are talking about different issues. Yours seems to be related to the bots missing the --enable-features=WebPayments command line argument. The reason we don't see testOpenAndCancel in those failures in that well it's not running since the iOS version is below 10.3 What lod@ is reporting seems to be related to the guard itself not working. Note that there are a way smaller set of tests failing there. @baxely, Any idea why these two issues are happening?
,
Aug 25 2017
,
Aug 25 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b32636c3872a6d4d8b4f474be743d0650a1d2e3 commit 4b32636c3872a6d4d8b4f474be743d0650a1d2e3 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Fri Aug 25 19:19:50 2017 [Payment Request] Fixes broken tests for ios_chrome_payments_egtests target Bug: 758513 Change-Id: If666eecc27e51f8ce5ed6cfa49b01a862eaf0e1f Reviewed-on: https://chromium-review.googlesource.com/636187 Commit-Queue: mahmadi (Moe) <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#497487} [modify] https://crrev.com/4b32636c3872a6d4d8b4f474be743d0650a1d2e3/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm [modify] https://crrev.com/4b32636c3872a6d4d8b4f474be743d0650a1d2e3/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm [modify] https://crrev.com/4b32636c3872a6d4d8b4f474be743d0650a1d2e3/ios/chrome/browser/ui/payments/payment_request_payment_response_egtest.mm [modify] https://crrev.com/4b32636c3872a6d4d8b4f474be743d0650a1d2e3/ios/chrome/browser/ui/payments/payment_request_use_stats_egtest.mm
,
Aug 25 2017
This fixes the failures reported by lod@. I think what olivierrobin@ reported had to do with the flag.
,
Aug 28 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lod@chromium.org
, Aug 25 2017