New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758513 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Payment egtests fail on iOS device

Project Member Reported by olivierrobin@chromium.org, Aug 24 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): M62
iOS Version: All
Device: 

Sample run
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/canary-device/builds/1219
https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/clang-tot-device/builds/3371

Note: tests don't run on devices on main waterfall. I am not sure this is intended.
 

Comment 1 by lod@chromium.org, Aug 25 2017

Tests are now running on main waterfall but still failing.
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/7237
Cc: -rayraymond@google.com mahmadi@chromium.org
AFAIK these tests need the WebPayments flag to run correctly. Looking into this.

(also removed rayraymond@, whose internship has ended)
Cc: lod@chromium.org
lod@ The failures you linked to are due to the following error:

[0825/043626.576305:ERROR:crw_web_controller.mm(2473)] JavaScript error: TypeError: function is not a constructor (evaluating 'new DOMException("Request cancelled", "AbortError")') URL:http://127.0.0.1:52487/components/test/data/payments/payment_request_name_test.html

These tests should be skipped in iOS versions below 10.3. Why are they running in the first place?

https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm?l=103
The tests that have the guard (like testOpenAndCancel) do not run.
Most tests don't have the 10.3 guard
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm?l=166

Should we add one for all tests in the suite?
Cc: baxley@chromium.org
olivierrobin@, i think you and lod@ are talking about different issues. Yours seems to be related to the bots missing the --enable-features=WebPayments command line argument. The reason we don't see testOpenAndCancel in those failures in that well it's not running since the iOS version is below 10.3

What lod@ is reporting seems to be related to the guard itself not working. Note that there are a way smaller set of tests failing there.

@baxely, Any idea why these two issues are happening?  


Cc: eugene...@chromium.org
Cc: -mahmadi@chromium.org macourteau@chromium.org
Owner: mahmadi@chromium.org
Status: Started (was: Assigned)
This fixes the failures reported by lod@. I think what olivierrobin@ reported had to do with the flag.
Mergedinto: 755799
Status: Duplicate (was: Started)

Sign in to add a comment