New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758503 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: i < size() in Vector.h called from UpdateLogicalWidthForCollapsedCells

Project Member Reported by ClusterFuzz, Aug 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5030184490369024

Fuzzer: mbarbella_webcomponents
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  i < size() in Vector.h
  blink::LayoutTableSection::UpdateLogicalWidthForCollapsedCells
  blink::LayoutTable::UpdateLayout
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=496775:496804

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5030184490369024

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 24 2017

Labels: OS-Windows

Comment 2 by tkent@chromium.org, Aug 27 2017

Components: Blink>Layout

Comment 3 by e...@chromium.org, Aug 29 2017

Components: -Blink>Layout Blink>Layout>Table
Owner: dgro...@chromium.org
Status: Assigned (was: Untriaged)
Summary: CHECK failure: i < size() in Vector.h called from UpdateLogicalWidthForCollapsedCells (was: CHECK failure: i < size() in Vector.h)

Comment 4 by e...@chromium.org, Aug 29 2017

Cc: joysyu@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25ea97e412367de1c639b092c40a5b927fcb8aa

commit b25ea97e412367de1c639b092c40a5b927fcb8aa
Author: Joy Yu <joysyu@google.com>
Date: Tue Aug 29 22:57:25 2017

Fix crash when indexing into column collapse vector

Take the minimum of the number of columns and the number of columns a
cell is spanning. Before, we did'nt take the minimum, so a cell set to
span more columns than the actual number of columns resulted in an
error.

Bug:  758503 
Change-Id: I3257bf3313f3ad09850a531c9ca1c5511d94b0f1
Reviewed-on: https://chromium-review.googlesource.com/642119
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498270}
[add] https://crrev.com/b25ea97e412367de1c639b092c40a5b927fcb8aa/third_party/WebKit/LayoutTests/fast/table/table-cell-colspan-exceeds-total-cols-crash.html
[modify] https://crrev.com/b25ea97e412367de1c639b092c40a5b927fcb8aa/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Comment 6 by joysyu@google.com, Aug 29 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Aug 30 2017

ClusterFuzz has detected this issue as fixed in range 498140:498349.

Detailed report: https://clusterfuzz.com/testcase?key=5030184490369024

Fuzzer: mbarbella_webcomponents
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  i < size() in Vector.h
  blink::LayoutTableSection::UpdateLogicalWidthForCollapsedCells
  blink::LayoutTable::UpdateLayout
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=496775:496804
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=498140:498349

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5030184490369024

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Aug 30 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5030184490369024 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment