New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[Sensor][Linux] LinearAccleration.start() first call fails

Project Member Reported by mikhail....@intel.com, Aug 24 2017

Issue description

Creation of fusion sensors on platform side is failing on Linux/Chrome OS if device nodes detection is not yet completed (i.e. if there has been no previous attempts to create any sensor by PlatformSensorProviderLinux)
 
Summary: [Sensor][Linux] LinearAccleration.start() first call fails (was: [Sensor][Linux] LinearAccleration.start() first call fails )
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c

commit 8a4778e913e038c5f5bd179d3ef64392d6ee0d3c
Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Sat Aug 26 05:27:17 2017

[sensor][Linux] Fix fusion sensors creation

This patch fixes fusion sensor creation failure in PlatformSensorProviderLinux.
The problem was that PlatformSensorProviderLinux::CreateSensorInternal() early
returned in case device nodes were not indexed ignoring creation of fusion senor
types.

The patch also improves the PlatformSensorFusion class interface with introducing
of a factory method which enforces the clients to use async callback for
initialization PlatformSensorFusion instances.

Bug:  758498 
Change-Id: Id3e773cc770397a2ceb133a7fd88af9106e77bd3
Reviewed-on: https://chromium-review.googlesource.com/631936
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#497656}
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_fusion.cc
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_fusion.h
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_provider_android.cc
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_provider_linux.cc
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_provider_linux.h
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_provider_mac.cc
[modify] https://crrev.com/8a4778e913e038c5f5bd179d3ef64392d6ee0d3c/services/device/generic_sensor/platform_sensor_provider_win.cc

Status: Fixed (was: Started)

Sign in to add a comment