Issue metadata
Sign in to add a comment
|
Regression: Arrow buttons are enable even when text is not entered in 'find in' box for first instance
Reported by
nutan.ga...@etouch.net,
Aug 24 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: c14400a94cb4f43e0e9b02e59e93cf5a082c6408-refs/heads/master@{#496533} OS: Mac(10.11.6, 10.12.3, 10.12.5) What steps will reproduce the problem? 1. Launch crome, navigate to NTP 2. Press cmd+f for find box and observe Actual: Arrow buttons are enable even when text is not entered in 'find in' box for first instance Expected: Arrow buttons should not be enable This is a regression issue broken in ‘M-62’, below is the manual regression range and will soon update bisect info. Good build : 62.0.3176.0 Bad build : 62.0.3177.0 Note: Issue is not reproducible on Mac and Linux OS
,
Aug 24 2017
Corrections: Chrome Version: 62.0.3194.0 c14400a94cb4f43e0e9b02e59e93cf5a082c6408-refs/heads/master@{#496533} Note: Issue is not reproducible on Windows and Linux OS
,
Aug 24 2017
,
Aug 25 2017
Just to update, M-62 will be branched soon and this is marked as Beta blocker. Would be great to have this fixed before branch point.
,
Aug 28 2017
Friendly ping for an update on this.
,
Aug 29 2017
Sorry for the late reply, just noticed this. I'll leave it building tonight and will take a look tomorrow and update.
,
Aug 29 2017
If it has to be rolled back, a commit that rolls back the changes would need to be pushed ASAP or what would be the best process?
,
Aug 30 2017
M-62 will branched tomorrow(08/31). carloschilazo@: If the fix is being worked on and lands before branch point, would be the best scenario in this case, else we can always take the fix to M-62 branch if this misses the branch point.
,
Aug 31 2017
Opened review 646066, Need to get feedback from Rohit for that patch, otherwise we'll need to rollback the change from 91d0123
,
Aug 31 2017
M62 is branching today, Please take a look ASAP.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9bc1fcaf5411f7060c1ad9724131a7a2601e8ec commit f9bc1fcaf5411f7060c1ad9724131a7a2601e8ec Author: Sergio Carlos Morales Angeles <carloschilazo@gmail.com> Date: Thu Aug 31 23:04:42 2017 Evaluate find text length when deciding if we should enable findbar buttons Fix regression on Mac related to find bar button enablement. Bug: 758491 Change-Id: Ic87e20be062cbd6f3ef48b926161a576b5064a11 Reviewed-on: https://chromium-review.googlesource.com/646066 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#499063} [modify] https://crrev.com/f9bc1fcaf5411f7060c1ad9724131a7a2601e8ec/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
,
Sep 1 2017
,
Sep 5 2017
Marking this Fixed as per verification in C#12.
,
Sep 5 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 5 2017
M-62 was branched @499098 and fix landed @499063 so no merge required here. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sandeepkumars@chromium.org
, Aug 24 2017Labels: hasbisect-per-revision
Owner: rohitrao@chromium.org
Status: Assigned (was: Unconfirmed)