New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758483 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Text caret in 'Copies' text field, stops blinking after drag & drop action.

Reported by avsha...@etouch.net, Aug 24 2017

Issue description

Chrome version : 60.0.3112.113 (Official Build) 95c454326a7a3153e984e50a4719924968490717-refs/branch-heads/3112@{#744} 32/64 bit
OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3, 10.12.5)

What steps will reproduce the problem?
1. Launch chrome, open NTP and press Ctrl + P keys to open Print Preview window.
2. In 'Destination', select any printer and enter '1' in 'Pages' text box.
3. Now select entered value from 'Pages' text box and drag it into 'Copies' text field.
4. Hit right arrow key from keyboard and observe the text caret in 'Copies' field.

Actual Result : Text caret in 'Copies' text field, does not blink after drag & drop action.

Expected Result : Text caret in 'Copies' text field, should keep blinking even after drag & drop action.

This is a regression issue broken in ‘M-53’, below is the manual regression range and will soon update bisect info.
Good build : 53.0.2764.0
Bad build : 53.0.2765.0
 
Actual_Result.mp4
1.1 MB View Download
Expected_Result.mp4
984 KB View Download

Comment 1 by avsha...@etouch.net, Aug 24 2017

Labels: hasbisect
Owner: amaralp@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/fe771cfc4e0fa2de3c7e4518d9eeb696fd6a305a..746d6c13d1c1463f52adc42381a584dc7029ba6e?pretty=fuller&n=10000

Suspecting : r399323 from Narrow Bisect 

@amaralp : Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.

Thank you!
Cc: paulmeyer@chromium.org
The root problem is that drag and drop doesn't call |EventHandler::HandleMouseReleaseEvent()| which restarts the blinking. I tracked that down to https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp?type=cs&l=361
which was added by paulmeyer@. paulmeyer@, why are we suppressing input events during drag and drop?

Sign in to add a comment