New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758480 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 753158
issue 759774



Sign in to add a comment

Write go library to talk to gerrit

Project Member Reported by robert...@chromium.org, Aug 24 2017

Issue description

This is so that the audit app can get confirmation that certain commits are pure reverts of other commits (for example)
 
Summary: Write go library to talk to gerrit (was: Write go library to talk to gitiles)
Blocking: 759774
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/7b6710374cae9d564b18416a75aabcab59fa52c6

commit 7b6710374cae9d564b18416a75aabcab59fa52c6
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 18:30:29 2017

Add minimal api for gerrit following the patterns in api/gitiles.

The audit app requires talking to gerrit, and using the same patterns as
when talking to gitiles will be helpful.

R=iannucci,dnj,stgao,chanli

Bug:758480
Change-Id: I520698ce1df431dbd59f6b2e6c116ebc11a85671
Reviewed-on: https://chromium-review.googlesource.com/630300
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/7b6710374cae9d564b18416a75aabcab59fa52c6/common/api/gerrit/OWNERS
[add] https://crrev.com/7b6710374cae9d564b18416a75aabcab59fa52c6/common/api/gerrit/gerrit.go
[add] https://crrev.com/7b6710374cae9d564b18416a75aabcab59fa52c6/common/api/gerrit/gerrit_test.go

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/7c457dd5de8289da89f626f333f3f00948c1c175

commit 7c457dd5de8289da89f626f333f3f00948c1c175
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 18:35:19 2017

gerrit client api: Add GetDetails.

Adding an api to get details about a single change.

R=tandrii,iannucci,dnj,stgao,chanli
BUG= 758480 

Change-Id: Iede97cc9b640148f5a132764c75177c88bb5b547
Reviewed-on: https://chromium-review.googlesource.com/640090
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/7c457dd5de8289da89f626f333f3f00948c1c175/common/api/gerrit/gerrit.go
[modify] https://crrev.com/7c457dd5de8289da89f626f333f3f00948c1c175/common/api/gerrit/gerrit_test.go

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/539396498a47c35d40b3d9f0a10e0fa4c6bcffe8

commit 539396498a47c35d40b3d9f0a10e0fa4c6bcffe8
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 21:45:09 2017

Roll luci-go

infra/go/src/go.chromium.org/luci
7c457dd5 gerrit client api: Add GetDetails.
7b671037 Add minimal api for gerrit following the patterns in
         api/gitiles.

R=dnj,iannucci
BUG= 758480 

Change-Id: I8a0d6b64378e2264b46f6e51c51522b587d38af6
Reviewed-on: https://chromium-review.googlesource.com/648169
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/539396498a47c35d40b3d9f0a10e0fa4c6bcffe8/DEPS

Status: Fixed (was: Started)

Sign in to add a comment