New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758478 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Incorrect-function-pointer-type in _hb_blob_destroy_user_data

Project Member Reported by ClusterFuzz, Aug 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5975138029010944

Fuzzer: libFuzzer_renderer_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Incorrect-function-pointer-type
Crash Address: 
Crash State:
  _hb_blob_destroy_user_data
  hb_blob_destroy
  hb_face_t::get_upem
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=496738:496798

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5975138029010944

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 24 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 24 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 24 2017

Labels: Pri-1
Components: Blink>Fonts
The repro case is 1 byte, which seems implausible. There don't seem to be any changes to fonts within the regression range?

Comment 5 by ta...@google.com, Aug 25 2017

Cc: drott@chromium.org mgiuca@chromium.org
Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
I can reproduce this on Goobuntu. msw@, would you be the right person to fix this?

Comment 6 by msw@chromium.org, Aug 25 2017

Cc: -drott@chromium.org e...@chromium.org
Owner: drott@chromium.org
No, my text rendering work has been for chrome browser ui, not the blink renderer (they're completely separate harfbuzz clients). Hopefully drott@ or eae@ can triage.

Comment 7 by drott@chromium.org, Sep 4 2017

Cc: behdad@chromium.org

Comment 8 by drott@chromium.org, Sep 4 2017

Behdad, are these more instances of https://github.com/behdad/harfbuzz/issues/474 ?
Yes. 
Labels: -Security_Severity-Medium -ReleaseBlock-Stable Security_Severity-Low
Downgrading this to same severity as  issue 696729  and removing ReleaseBlock-Stable.
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 5 2017

Labels: -Pri-1 Pri-2
Cc: bunge...@chromium.org
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 14 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Security_Impact-Beta Security_Impact-Stable
For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md.

The link referenced in the description is no longer valid.

Comment 17 by e...@chromium.org, Oct 31 2017

Cc: dsinclair@chromium.org drott@chromium.org npm@chromium.org tsepez@chromium.org
 Issue 761694  has been merged into this issue.
Project Member

Comment 18 by ClusterFuzz, Nov 3 2017

ClusterFuzz has detected this issue as fixed in range 513517:513548.

Detailed report: https://clusterfuzz.com/testcase?key=5975138029010944

Fuzzer: libFuzzer_renderer_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Incorrect-function-pointer-type
Crash Address: 
Crash State:
  _hb_blob_destroy_user_data
  hb_blob_destroy
  hb_face_t::get_upem
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=496738:496798
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=513517:513548

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5975138029010944

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 19 by ClusterFuzz, Nov 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6020511204376576 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 20 by sheriffbot@chromium.org, Nov 3 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -M-62 M-64
Project Member

Comment 23 by sheriffbot@chromium.org, Feb 9 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment