New issue
Advanced search Search tips

Issue 758473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

ServiceWorkerProviderHostTest.ActiveIsNotController is flaky

Project Member Reported by falken@chromium.org, Aug 24 2017

Issue description

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=ServiceWorkerProviderHostTest.ActiveIsNotController

 RUN      ] ServiceWorkerProviderHostTest.ActiveIsNotController
[12162:12162:0823/215311.894864:24800004963:FATAL:service_worker_provider_host.cc(647)] Check failed: info_.provider_id == info.provider_id (-3 vs. -2)
#0 0x0000f2e29f47 base::debug::StackTrace::StackTrace()
#1 0x0000f2e27f4c base::debug::StackTrace::StackTrace()
#2 0x0000f2ec8eee logging::LogMessage::~LogMessage()
#3 0x0000ee4cd5d8 content::ServiceWorkerProviderHost::CompleteNavigationInitialized()
#4 0x000009bf9400 content::ServiceWorkerProviderHostTest_ActiveIsNotController_Test::TestBody()
#5 0x0000092ae5cf _ZN7testing8internal12InvokeHelperIvNSt3__15tupleIJEEEE12InvokeMethodIN5media23VirtualAudioInputStreamEMS8_FvvEEEvPT_T0_RKS4_
#6 0x00000abaf9b1 testing::internal::HandleExceptionsInMethodIfSupported<>()
#7 0x00000ab97246 testing::Test::Run()
#8 0x00000ab97ffe testing::TestInfo::Run()
#9 0x00000ab98bb7 testing::TestCase::Run()
#10 0x00000aba69f1 testing::internal::UnitTestImpl::RunAllTests()
#11 0x0000092ad42f _ZN7testing8internal12InvokeHelperIbNSt3__15tupleIJEEEE12InvokeMethodIN5media23VirtualAudioInputStreamEMS8_FbvEEEbPT_T0_RKS4_
#12 0x00000abb13e1 testing::internal::HandleExceptionsInMethodIfSupported<>()
#13 0x00000aba65f5 testing::UnitTest::Run()
#14 0x00000b6297bd RUN_ALL_TESTS()
#15 0x00000b62694f base::TestSuite::Run()
#16 0x00000b5745ec content::UnitTestTestSuite::Run()
#17 0x00000844d09a _ZN4base8internal13FunctorTraitsIMN7content26AppCacheRequestHandlerTestEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#18 0x00000844cfba _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content26AppCacheRequestHandlerTestEFvvEJPS5_EEEvOT_DpOT0_
#19 0x00000a5213da _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEiOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE
#20 0x00000a5212c1 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#21 0x000008470dbe _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#22 0x00000b64bfb9 base::(anonymous namespace)::LaunchUnitTestsInternal()
#23 0x00000b64bdb6 base::LaunchUnitTests()
#24 0x00000a5210c9 main
#25 0x0000e1b7daf3 __libc_start_main
#26 0x0000083245b4 <unknown>
[2425/5269] ServiceWorkerProviderHostTest.ActiveIsNotController (CRASHED)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7114a66134c951d0641f6e39b180b73bd3858211

commit 7114a66134c951d0641f6e39b180b73bd3858211
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Aug 25 09:42:15 2017

Deflake ServiceWorkerProviderHostTest.ActiveIsNotController

The test was trying to keep track of browser_side_provider_id which
could get out of sync with the global provider_id used internally
by ServiceWorkerProviderHost.

Bug:  758473 
Change-Id: I96a6255deb057e505e5d6c8ad57014b8b507b1c8
Reviewed-on: https://chromium-review.googlesource.com/634789
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497367}
[modify] https://crrev.com/7114a66134c951d0641f6e39b180b73bd3858211/content/browser/service_worker/service_worker_provider_host_unittest.cc

Comment 2 by falken@chromium.org, Aug 28 2017

Labels: M-62
Status: Fixed (was: Assigned)

Sign in to add a comment