Get rid of VisbileSelectionTemplate::IsNonOrphanedCaretOrRange() |
||||
Issue descriptionvisible_selection.IsNonOrphanedCaretOrRange() should be replaced to !visible_selection.IsNone() && visible_selection.IsValidFor(document) As of August 24, 2017, there are 9 call sites.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b390187aa4859248c6c63263735a11a91cb7eed commit 8b390187aa4859248c6c63263735a11a91cb7eed Author: Akari Asai <akariasai@google.com> Date: Tue Aug 29 08:59:48 2017 Modified InsertListCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). Changed InsertListCommand::DoApply() in Webkit/Source/core/editing/commands/ InsertListCommandcpp to replace IsNonOrphanedCaretOrRange() to !VS.IsNone() && VS.IsValidFor(document) so that IsNonOrphanedCaretOrRange() could be removed from VisibleSelection. Modified InsertListCommand::DoApply() Bug: 758468 Change-Id: I12043bd7280245fefbb7e99d39e67ee73701f1a1 Reviewed-on: https://chromium-review.googlesource.com/633260 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Akari Asai <akariasai@google.com> Cr-Commit-Position: refs/heads/master@{#498055} [modify] https://crrev.com/8b390187aa4859248c6c63263735a11a91cb7eed/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/918ecede2fe1effcf7f70c1b30e9ab2eb7c55f42 commit 918ecede2fe1effcf7f70c1b30e9ab2eb7c55f42 Author: Akari Asai <akariasai@google.com> Date: Wed Aug 30 11:56:28 2017 Modified InsertLineBreakCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). Changed InsertLineBreakCommand::DoApply in Webkit/Source/core/editing/commands/ InsertLineBreakCommand.cpp to replace IsNonOrphanedCaretOrRange() to !VisibleSelection.selection.IsNone() && VisibleSelection.IsValidFor(document) so that IsNonOrphanedCaretOrRange() could be removed from VisibleSelection. Bug: 758468 Change-Id: I88800f7e29ad116faf5463beaaffd6926bd48e59 Reviewed-on: https://chromium-review.googlesource.com/633262 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#498425} [modify] https://crrev.com/918ecede2fe1effcf7f70c1b30e9ab2eb7c55f42/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3213bd435a735f1f1a22f9ce92c00d5e4f82b20 commit a3213bd435a735f1f1a22f9ce92c00d5e4f82b20 Author: Akari Asai <akariasai@google.com> Date: Fri Sep 01 13:52:05 2017 Modifies FrameSelection::SelectFrameElementInParentIfFullySelected() not to use IsNonOrphanedCaretOrRange(). This patch modifies SelectFrameElementInParentIfFullySelected() Webkit/Source/core/editing/ FrameSelection.cpp to replace IsNonOrphanedCaretOrRange()to !visible_selection.IsNone() && visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: I9678936d2f4be4873bce9188f4a1e47d5c7d4d52 Reviewed-on: https://chromium-review.googlesource.com/632296 Commit-Queue: Akari Asai <akariasai@google.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#499184} [modify] https://crrev.com/a3213bd435a735f1f1a22f9ce92c00d5e4f82b20/third_party/WebKit/Source/core/editing/FrameSelection.cpp
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2c7a344d7f8ef4de77dd87428560a4da95f0918 commit b2c7a344d7f8ef4de77dd87428560a4da95f0918 Author: Akari Asai <akariasai@google.com> Date: Wed Sep 06 02:56:30 2017 Modifies InsertParagraphSeparatorCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). This patch modifies DoApply() in Webkit/Source/core/editing/commands/ InsertParagraphSeparatorCommand.cpp to replace IsNonOrphanedCaretOrRange() to !visible_selection.IsNone() && visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: I8e25aa510db5196b5c19bfae42d707aa17f0844e Reviewed-on: https://chromium-review.googlesource.com/647669 Commit-Queue: Akari Asai <akariasai@google.com> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#499860} [modify] https://crrev.com/b2c7a344d7f8ef4de77dd87428560a4da95f0918/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41a8961aaa4a9c58c031b7ad6f11b0b6f86f8be5 commit 41a8961aaa4a9c58c031b7ad6f11b0b6f86f8be5 Author: Akari Asai <akariasai@google.com> Date: Wed Sep 06 02:58:40 2017 Modify InsertTextCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). This patch modifies DoApply() in Webkit/Source/core/editing/commands/ InsertTextCommand.cpp to replace IsNonOrphanedCaretOrRange() to !visible_selection.IsNone() && visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: Ieb27239ce22a3588c2bf14e8538ded7d65f32375 Reviewed-on: https://chromium-review.googlesource.com/647670 Commit-Queue: Akari Asai <akariasai@google.com> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#499861} [modify] https://crrev.com/41a8961aaa4a9c58c031b7ad6f11b0b6f86f8be5/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/285732da33074654fa4c84d33b06a9df0039c5dc commit 285732da33074654fa4c84d33b06a9df0039c5dc Author: Akari Asai <akariasai@google.com> Date: Wed Sep 06 03:13:59 2017 Modifies RemoveFormatCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). This patch modifies DoApply() Webkit/Source/core/editing/RemoveFormatCommand.cpp to replace IsNonOrphanedCaretOrRange()to !visible_selection.IsNone() && visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: I1e586ce2c28f66744b35dc95146bb38046a1c942 Reviewed-on: https://chromium-review.googlesource.com/647356 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Akari Asai <akariasai@google.com> Cr-Commit-Position: refs/heads/master@{#499869} [modify] https://crrev.com/285732da33074654fa4c84d33b06a9df0039c5dc/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc73dea15274e4b57df9499c4baabda7be377ed commit dfc73dea15274e4b57df9499c4baabda7be377ed Author: Akari Asai <akariasai@google.com> Date: Wed Sep 06 03:57:42 2017 Modifies TypingCommand::DoApply() not to use IsNonOrphanedCaretOrRange(). This patch modifies DoApply() in Webkit/Source/core/editing/commands/ TypingCommand.cpp to replace !IsNonOrphanedCaretOrRange() to visible_selection.IsNone() || visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: I89c50d507767ce709ef59f9056f48021e128f400 Reviewed-on: https://chromium-review.googlesource.com/647668 Commit-Queue: Akari Asai <akariasai@google.com> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#499877} [modify] https://crrev.com/dfc73dea15274e4b57df9499c4baabda7be377ed/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68d0678dcce021a8f8ca6f9f7a8fdf6697a77f63 commit 68d0678dcce021a8f8ca6f9f7a8fdf6697a77f63 Author: Akari Asai <akariasai@google.com> Date: Wed Sep 06 09:11:21 2017 Modify ValueFormatBlock() not to use IsNonOrphanedCaretOrRange(). This patch modifies ValueFormatBlock() Webkit/Source/core/editing/ commands/EditorCommand.cpp to replace IsNonOrphanedCaretOrRange() to !visible_selection.IsNone() &&visible_selection.IsValidFor(document) to remove IsNonOrphanedCaretOrRange() from VisibleSelection. Using isValidFor() enables to check not only if the selection's base exists, but also if it is in the same document as the parent. Bug: 758468 Change-Id: I90ddbe0f0ec5a70d3fbacf68005178d51d7648d3 Reviewed-on: https://chromium-review.googlesource.com/648868 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#499912} [modify] https://crrev.com/68d0678dcce021a8f8ca6f9f7a8fdf6697a77f63/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/859e2860d35e51d2545c2312e14441065cc914de commit 859e2860d35e51d2545c2312e14441065cc914de Author: Akari Asai <akariasai@google.com> Date: Fri Sep 08 09:57:07 2017 Remove IsNonOrphanedCaretOrRange() from VisibleSelection.h. This patch removes IsNonOrphanedCaretOrRange() from third_party/ WebKit/Source/core/editing/VisibleSelection.h since there are no references calling this function. Bug: 758468 Change-Id: I54e62ab7e7e4c7f391e45c8c2243d09eed0c5e0a Reviewed-on: https://chromium-review.googlesource.com/656647 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#500552} [modify] https://crrev.com/859e2860d35e51d2545c2312e14441065cc914de/third_party/WebKit/Source/core/editing/VisibleSelection.h
,
Oct 2 2017
The assigned owner "akariasai@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3 2017
,
Nov 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yosin@chromium.org
, Aug 24 2017