New issue
Advanced search Search tips

Issue 758463 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

joystick input broken in m60 on android

Project Member Reported by boliu@chromium.org, Aug 24 2017

Issue description

joystick input broken in m60 on android
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1794739316000394fb7e0d4ae4245f2166590218

commit 1794739316000394fb7e0d4ae4245f2166590218
Author: Bo Liu <boliu@chromium.org>
Date: Thu Aug 24 13:56:22 2017

android: Return zero velocity joystick event as unhandled

This is a follow up after refactor in refs/heads/master@{#472737}.
Bring back checks for zero velocity joystick events and leave them
as unhandled. These checks are important because they allow client
to then convert unhandled joystick events to dpad events.

Bug:  758463 
Bug:  644488 
Change-Id: I855103dc6878dada3701e7be3b268186ccf4bc71
Reviewed-on: https://chromium-review.googlesource.com/631476
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497030}
[modify] https://crrev.com/1794739316000394fb7e0d4ae4245f2166590218/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Labels: Merge-Approved-61
Approved for M61 branch 3163.
Labels: ReleaseBlock-Stable M-61
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10bef95abc02eea604380458c6f30346d5ae6782

commit 10bef95abc02eea604380458c6f30346d5ae6782
Author: Bo Liu <boliu@chromium.org>
Date: Thu Aug 24 16:30:41 2017

android: Return zero velocity joystick event as unhandled

This is a follow up after refactor in refs/heads/master@{#472737}.
Bring back checks for zero velocity joystick events and leave them
as unhandled. These checks are important because they allow client
to then convert unhandled joystick events to dpad events.

Bug:  758463 
Bug:  644488 
Change-Id: I855103dc6878dada3701e7be3b268186ccf4bc71
Reviewed-on: https://chromium-review.googlesource.com/631476
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497030}(cherry picked from commit 1794739316000394fb7e0d4ae4245f2166590218)
Reviewed-on: https://chromium-review.googlesource.com/633483
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#855}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/10bef95abc02eea604380458c6f30346d5ae6782/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Comment 5 by boliu@chromium.org, Aug 24 2017

Status: Fixed (was: Untriaged)
 Issue 758998  has been merged into this issue.

Comment 7 by boliu@chromium.org, Aug 29 2017

Labels: Merge-Request-60
only affects joystick event, so should be safe

Comment 8 by cma...@chromium.org, Aug 29 2017

Cc: satyavat...@chromium.org
Labels: -Merge-Request-60 Merge-Approved-60
Thanks Bo!

satyavathir@, please help verify this fix on the 3112 branch if possible!
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 29 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a599b1b932054e3181686c7110ed629795e8c29

commit 2a599b1b932054e3181686c7110ed629795e8c29
Author: Bo Liu <boliu@chromium.org>
Date: Tue Aug 29 18:41:29 2017

[Merge M60] android: Return zero velocity joystick event as unhandled

This is a follow up after refactor in refs/heads/master@{#472737}.
Bring back checks for zero velocity joystick events and leave them
as unhandled. These checks are important because they allow client
to then convert unhandled joystick events to dpad events.

Bug:  758463 
Bug:  644488 
Change-Id: I855103dc6878dada3701e7be3b268186ccf4bc71
Reviewed-on: https://chromium-review.googlesource.com/631476
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497030}(cherry picked from commit 1794739316000394fb7e0d4ae4245f2166590218)
Reviewed-on: https://chromium-review.googlesource.com/642012
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#745}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/2a599b1b932054e3181686c7110ed629795e8c29/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Please note that I was able repro issue on M60: 60.0.3112. 107.

Fix verified - joy stick navigation works fine on NVidia Shield / 5.2(24.28.403.174)/NRD90M with 61.0.3163.72 & 62.0.3199.4

Some of the Apps tested: Facebook Video, Spotify, Hulu, Netflix, HayStack, Pluto Tv, Bild TV, ARD Mediathek etc.

I will check on M60 Stable soon.
Status: Verified (was: Fixed)
Verified this fix on NVidia Shield (P2897/ 5.2(24.28.403.174)/NRD90M with M60/60.0.3112.116 with Apps: Facebook Video, Spotify, Hulu, Netflix, HayStack, Pluto TV.

Thanks!

Sign in to add a comment