Issue 758458 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	lijeffrey@chromium.org
Closed:	Aug 2017
Cc:	█ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt>Flakiness
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

Blocking:
issue 757517

[Findit] Flake Analyzer - Bail out of heuristic analysis if no suspected build identified

Project Member Reported by lijeffrey@chromium.org, Aug 24 2017

Issue description

AttributeError: 'NoneType' object has no attribute 'task_id'
at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:11355-d3b56da.403577873630294266/waterfall/flake/get_test_location_pipeline.py:24)
at _run_internal (/base/data/home/apps/s~findit-for-me/waterfall-backend:11355-d3b56da.403577873630294266/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py:1113)
at evaluate (/base/data/home/apps/s~findit-for-me/waterfall-backend:11355-d3b56da.403577873630294266/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py:2158)

heuristic analysis assumes a suspected build was identified, when in fact it can be called when no build was found. In that case, bail out.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cbb651bdf5d2363fbf89de741bf51ab5be290e06

commit cbb651bdf5d2363fbf89de741bf51ab5be290e06
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Aug 25 00:32:52 2017

[Findit] Flake Analyzer - Bail out of heuristic analysis if no suspected build

Bug:  758458 
Change-Id: Ib5e741ef4b9093c9b2c435e4c4edb41acca3d5cb
Reviewed-on: https://chromium-review.googlesource.com/631336
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/waterfall/flake/test/get_test_location_pipeline_test.py
[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/model/flake/test/master_flake_analysis_test.py
[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/waterfall/flake/get_test_location_pipeline.py
[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/waterfall/flake/identify_suspected_revisions_pipeline.py
[modify] https://crrev.com/cbb651bdf5d2363fbf89de741bf51ab5be290e06/appengine/findit/waterfall/flake/test/identify_suspected_revisions_pipeline_test.py

Comment 2 by lijeffrey@chromium.org, Aug 28 2017

Blocking: 757517
Status: Fixed (was: Assigned)

►

Issue 758458 link

Issue metadata

[Findit] Flake Analyzer - Bail out of heuristic analysis if no suspected build identified

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

Comment 1 Deleted

Comment 2 by lijeffrey@chromium.org, Aug 28 2017

Comment 2 Deleted

Sign in to add a comment