New issue
Advanced search Search tips

Issue 758456 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

UI for exiting fullscreen

Project Member Reported by yuweih@chromium.org, Aug 24 2017

Issue description

This bug tracks works to implement the UI for exiting fullscreen when the page has reserved the ESC key.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b212672c8311f68605eba8045cc4f71ffca9f578

commit b212672c8311f68605eba8045cc4f71ffca9f578
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Aug 24 18:33:24 2017

Change string for the hold ESC to exit fullscreen instruction

According to the new system keyboard lock UI spec, the exit instruction
string has been changed to "Press and hold [ESC]..."

TBR=cpu@chromium.org

Bug:  758456 
Change-Id: Ice13883bc5a41bba1d5629de95d3a855d7147382
Reviewed-on: https://chromium-review.googlesource.com/630258
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497132}
[modify] https://crrev.com/b212672c8311f68605eba8045cc4f71ffca9f578/chrome/app/generated_resources.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc

commit 81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Sep 14 18:45:18 2017

[Vector Icons] Add the 24x24 close icon and rename the previous 16x16 icon

This CL adds the 24x24 close icon (to be used by the exit fullscreen
indicator) and rename the old 16x16 close icon to close_16 since it is
the variant of the standard 24x24 icon.

Bug:  758456 
Change-Id: I8859740271653d82e197fc20e105030c679144c8
Reviewed-on: https://chromium-review.googlesource.com/666232
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502002}
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/chrome/browser/vr/elements/close_button_texture.cc
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/components/vector_icons/BUILD.gn
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/components/vector_icons/close.icon
[add] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/components/vector_icons/close_16.1x.icon
[add] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/components/vector_icons/close_16.icon
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/81e9248898bb4a9acd25f2a8ca5e3590ad5e4ebc/ui/views/controls/button/image_button_factory_unittest.cc

Comment 3 by yuweih@chromium.org, Sep 15 2017

Components: Internals>PlatformIntegration
Summary: UI for exiting fullscreen (was: System keyboard lock exit UI on fullscreen)
Since we now decide to unify the UI and logic for the exit fullscreen indicator for keyboard lock and the button to exit fullscreen mode for touch tablets, I'll use this bug to track all changes related to them, i.e. I'll merge  bug 710991  into this bug.

Comment 4 by yuweih@chromium.org, Sep 15 2017

Cc: robliao@chromium.org yuweih@chromium.org
 Issue 710991  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6179c3db6d6ff0f186b0ca20e3388c19b299586a

commit 6179c3db6d6ff0f186b0ca20e3388c19b299586a
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Sep 28 00:36:49 2017

[Fullscreen Control] Finish up the fullscreen control UI and add the animation class

This CL finishes up the fullscreen control UI. It is a transparent-black
circular button with a close (X) icon on the middle. It is used both as an
indicator for exiting fullscreen when the keyboard lock reserves the ESC
key and an actual button to exit fullscreen for touch devices.

This CL also implements a FullscreenControlPopup class to show the
indicator with a dropdown animation in replacement of the DropdownBarHost
implementation.

This is the UX spec (Google internal):
https://docs.google.com/presentation/d/11D86S87NZK5sAMLhc8WSV9pk_VWkjMAjvnN08uUD5po/edit#slide=id.g23756e43b7_3_0

Bug:  758456 
Change-Id: I44dc2d0944386f5f6f5e607831c5ea4e38364357
Reviewed-on: https://chromium-review.googlesource.com/647950
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504816}
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[add] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.cc
[add] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.h
[add] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup_unittest.cc
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.cc
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.h
[modify] https://crrev.com/6179c3db6d6ff0f186b0ca20e3388c19b299586a/chrome/test/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f

commit bb7b2c58109f2c207a8d56ee0ff910dc72e6163f
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Oct 12 20:09:33 2017

[Fullscreen Control] Hide the exit instruction when showing the control UI

This CL makes FullscreenControlHost hide the "Press [ESC] to exit
fullscreen" instruction when showing the fullscreen control UI.

This CL also adds myself as the owner of fullscreen_control/

Bug:  758456 
Change-Id: I64c7d0e8015243dddeac5dd10f8ad593e8f0c181
Reviewed-on: https://chromium-review.googlesource.com/707727
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508424}
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/views/exclusive_access_bubble_views.cc
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/views/exclusive_access_bubble_views.h
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/views/fullscreen_control/OWNERS
[modify] https://crrev.com/bb7b2c58109f2c207a8d56ee0ff910dc72e6163f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bbad6bfc41a885971254fc6b0faefceca8729b9

commit 2bbad6bfc41a885971254fc6b0faefceca8729b9
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Nov 17 02:44:55 2017

[Fullscreen Control] Fixing the touch behavior

* Fix the issue of |input_entry_method_| not being reset to NOT_ACTIVE
  when the popup is hidden.
* Use ET_GESTURE_LONG_PRESS instead of ET_GESTURE_LONG_TAP so that
  animation is triggered before the tap is released.
* Add auto timeout to the popup when it is triggered by touch.
* Hide the popup when it is triggered by touch and the user touches
  outside of the popup.

Bug:  758456 
Change-Id: Id2cb6642a4e9129a096c5025d5695aeacf304717
Reviewed-on: https://chromium-review.googlesource.com/775734
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517256}
[modify] https://crrev.com/2bbad6bfc41a885971254fc6b0faefceca8729b9/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/2bbad6bfc41a885971254fc6b0faefceca8729b9/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[modify] https://crrev.com/2bbad6bfc41a885971254fc6b0faefceca8729b9/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.cc
[modify] https://crrev.com/2bbad6bfc41a885971254fc6b0faefceca8729b9/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.h
[modify] https://crrev.com/2bbad6bfc41a885971254fc6b0faefceca8729b9/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a33dfce1cc40a11e9c6396fb09e068d66d871f5

commit 6a33dfce1cc40a11e9c6396fb09e068d66d871f5
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Nov 22 21:06:00 2017

[Fullscreen Control] Tweaking touch timeout behavior

Per hwi@'s feedback, the timout should start 5 seconds after the user
releases the finger.

Bug:  758456 
Change-Id: I5cd850c9427e2ce792db19c9772121f8ce0bfa52
Reviewed-on: https://chromium-review.googlesource.com/784096
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518742}
[modify] https://crrev.com/6a33dfce1cc40a11e9c6396fb09e068d66d871f5/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/826eae6812fc62c516d2beac2db50c3fdbc4c561

commit 826eae6812fc62c516d2beac2db50c3fdbc4c561
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Dec 14 22:39:51 2017

[Fullscreen Control] Don't show exit UI if slide-down top-chrome is available

If the slide-down top-chrome is available in fullscreen mode then we
don't need to show the fullscreen exit UI since the user can use the
top-chrome to exit fullscreen.

Bug:  758456 
Change-Id: I1298279ca97e5fea00629e888e6a56ade23bc67f
Reviewed-on: https://chromium-review.googlesource.com/827608
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524209}
[modify] https://crrev.com/826eae6812fc62c516d2beac2db50c3fdbc4c561/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/826eae6812fc62c516d2beac2db50c3fdbc4c561/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h

Status: Fixed (was: Assigned)
This is done and launched to stable as of M68.

Sign in to add a comment