New issue
Advanced search Search tips

Issue 758450 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 678288



Sign in to add a comment

Include Finch experiment info in WebView minidumps

Project Member Reported by paulmiller@chromium.org, Aug 24 2017

Issue description

Microdumps likely won't have space, but we should make sure experiment info is included in minidumps, to ease debugging. (This came up during kmilka@'s presentation.)
 

Comment 1 by kmilka@google.com, Aug 24 2017

It looks like, in Chrome, this work is done by the FieldTrialSynchronizer, with a call to SetVariationsListCrashKeys():

https://cs.chromium.org/chromium/src/chrome/browser/metrics/field_trial_synchronizer.cc?l=33

Currently we don't have an equivalent of the synchronizer in WebView, and I don't think we need to create one for this. Chrome creates the object here:

https://cs.chromium.org/chromium/src/chrome/browser/chrome_browser_main.cc?l=707

and the important work is done in the constructor. We may be able to get away with just adding a direct call to variations::SetVariationListCrashKeys() in AwFieldTrialCreator's SetupFieldTrials().

Comment 2 by kmilka@google.com, Aug 24 2017

Cc: kmilka@google.com

Comment 3 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to owner. Please triage as appropriate.

Comment 5 by kmilka@chromium.org, May 26 2018

Cc: -kmilka@google.com
Cc: tobiasjs@chromium.org
Labels: -Pri-3 Pri-1
This is a critical feature for Finch, as people who experiments Finch would want to collect stability data as well as other metrics.
Owner: hazems@chromium.org
Hazem is able to take this.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713df1886f5c891d07c5a1ca012f83e3a698ead6

commit 713df1886f5c891d07c5a1ca012f83e3a698ead6
Author: Hazem Ashmawy <hazems@chromium.org>
Date: Thu Nov 01 17:12:51 2018

[aw] Add Finch experiments to Webview minidump

Add Finch Experiments info aka variations crash keys to Webview minidump. The keys are "variations" and "num-experiments".

Bug:  758450 
Change-Id: Ib3bc7b872c0ff88eb404595496a9084f1d123ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1305953
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604622}
[modify] https://crrev.com/713df1886f5c891d07c5a1ca012f83e3a698ead6/android_webview/browser/aw_field_trial_creator.cc
[modify] https://crrev.com/713df1886f5c891d07c5a1ca012f83e3a698ead6/android_webview/common/crash_reporter/crash_keys.cc

Status: Verified (was: Assigned)
This change is landed in version 72.0.3599.0. The "Experiments" field in chrome crash dashboard now shows experiments IDs and count for webview crashes.

Sign in to add a comment