New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758449 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 322303



Sign in to add a comment

Explore to remove dependency of Tab in PrintingControllerImpl.java

Project Member Reported by ctzsm@chromium.org, Aug 24 2017

Issue description

There are two benefits to do so:

1) We only need to track which WebContent is needed to print, which we could track in native side. Removes dependency of Tab can reduce code complexity and make it one step closer to merge code path with WebView.

2) Less dangerous of crash, because we are tracking Tab instance via WeakReference, we can't guarantee existence of Tab when we need it.
 

Comment 1 by ctzsm@chromium.org, Aug 24 2017

Summary: Explore to remove dependency of Tab in PrintingControllerImpl.java (was: Experiment to remove dependency of Tab in PrintingControllerImpl.java)

Comment 2 by ctzsm@chromium.org, Aug 25 2017

Blocking: 322303

Comment 3 by ctzsm@chromium.org, Sep 5 2017

Components: Internals>Printing
Labels: OS-Android

Comment 4 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org

Sign in to add a comment