New issue
Advanced search Search tips

Issue 758446 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

youtube for android and youtube chrome apps shouldnt both show up in suggested apps

Project Member Reported by newcomer@chromium.org, Aug 24 2017

Issue description

if there are two apps which are the same but one is for android, the other is for chrome, only show one of them in suggested apps.


 

Comment 1 by khmel@chromium.org, Aug 24 2017

Status: Started (was: Untriaged)
To confirm,

IIUC android version is expected to be shown
shibasheikh@ should know the specifics, but I believe that they want the most recently used of the two possible apps.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.

Comment 5 Deleted

If it's simpler to just show the first on the list of suggested apps (without looking at logic of how they were selected) that would be awesome!

Comment 7 by khmel@chromium.org, Aug 24 2017

Implemented already based on last launch time or install time. Sending to review soon.
Status: Fixed (was: Started)
Yury just showed me this implemented.

Comment 9 by khmel@chromium.org, Aug 24 2017

Status: Started (was: Fixed)
The CL is still in review. I expect it finishes soon.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d808390d77c634187022ce71c36a0e4f6276afdd

commit d808390d77c634187022ce71c36a0e4f6276afdd
Author: khmel <khmel@google.com>
Date: Thu Aug 24 23:23:20 2017

arc: Prevent showing duplicate apps in Recent and Search.

This CL blocks appearing together Android and Chrome versions of the
same app in Recent view and in Search. Most recent (by last launch or
install time) app is shown. In case user launches opposite app then new
app is replaced in Recent and Search.

Test: Manually on device. Added unit test.
Bug:  758446 
Change-Id: Icb565be663f100259b5eea55ae3531d0fc15cf83
Reviewed-on: https://chromium-review.googlesource.com/634065
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#497244}
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/chromeos/extensions/gfx_utils.h
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/ui/app_list/search/app_result.h
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/ui/app_list/search/app_search_provider.h
[modify] https://crrev.com/d808390d77c634187022ce71c36a0e4f6276afdd/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/027e773789a6ae7e95ca2a8212a39241d9d32d98

commit 027e773789a6ae7e95ca2a8212a39241d9d32d98
Author: khmel <khmel@google.com>
Date: Fri Aug 25 00:09:14 2017

[Merge M61] arc: Prevent showing duplicate apps in Recent and Search.

This CL blocks appearing together Android and Chrome versions of the
same app in Recent view and in Search. Most recent (by last launch or
install time) app is shown. In case user launches opposite app then new
app is replaced in Recent and Search.

Test: Manually on device. Added unit test.
Bug:  758446 

TBR=khmel@google.com, xiyuan@chromium.org

(cherry picked from commit d808390d77c634187022ce71c36a0e4f6276afdd)

Change-Id: Icb565be663f100259b5eea55ae3531d0fc15cf83
Reviewed-on: https://chromium-review.googlesource.com/634065
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#497244}
Reviewed-on: https://chromium-review.googlesource.com/634503
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#868}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/chromeos/extensions/gfx_utils.h
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/ui/app_list/search/app_result.h
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/ui/app_list/search/app_search_provider.h
[modify] https://crrev.com/027e773789a6ae7e95ca2a8212a39241d9d32d98/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

Comment 12 by khmel@chromium.org, Aug 25 2017

Status: Fixed (was: Started)

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment