New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758442 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: simplify navigation code.

Project Member Reported by scottchen@chromium.org, Aug 24 2017

Issue description

In MD Extensions, currently there are multiple ways a custom element triggers a route & page change, which can make tracing the code complicated.

Simplify the navigation code by providing a globally accessible extensions.navigation.navigateTo() API for routing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5070f164a9aa43a4b6d953c67c1d8ce396f481

commit 0e5070f164a9aa43a4b6d953c67c1d8ce396f481
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Aug 29 23:22:40 2017

MD Extensions: make sidebar element use the new navigation code.

This CL exposes a global singleton "extensions.navigation" that custom
elements can use to trigger navigation, as well as subscribe to handle
a route change.

This CL also converts <sidebar> to use this new mechanism, instead of
proxying the call to changePage via a provided delegate.

Bug:  758442 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8130acd9570223f6130dcdd3848061c88429afed
Reviewed-on: https://chromium-review.googlesource.com/624729
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498278}
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/browser/resources/md_extensions/navigation_helper.js
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/browser/resources/md_extensions/sidebar.js
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/test/data/webui/extensions/extension_manager_test.js
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
[modify] https://crrev.com/0e5070f164a9aa43a4b6d953c67c1d8ce396f481/chrome/test/data/webui/extensions/extension_sidebar_test.js

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a

commit 43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Aug 31 20:59:09 2017

MD Extensions: convert all navigation code to use navigateTo.

This CL converts all the .changePage calls to use the new extensions.navigation.navigateTo API instead.

Bug:  758442 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I11ee36de6a526daf33c2cca3cb2d768203c2399b
Reviewed-on: https://chromium-review.googlesource.com/639334
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498995}
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/item_util.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/service.html
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/browser/resources/md_extensions/service.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/test/data/webui/extensions/extension_item_test.js
[modify] https://crrev.com/43b30ab3f4a9ef2ba37535c9745a9d91d1c7e77a/chrome/test/data/webui/extensions/extension_manager_test.js

Status: Fixed (was: Started)

Sign in to add a comment