New issue
Advanced search Search tips

Issue 758423 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox UI Experiments: Some suggestions still show ellipsis in fill_into_edit

Project Member Reported by tommycli@chromium.org, Aug 24 2017

Issue description

Bookmarks I could reproduce with
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0beb815a054f2f944baf9e7aaa3fd308f0e92916

commit 0beb815a054f2f944baf9e7aaa3fd308f0e92916
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Aug 25 18:30:26 2017

Omnibox UI Experiments: Fix remaining ellipses entering fill_into_edit.

For Physical Web, Zero Suggest, and Bookmarks, there are still some
instances of match.contents (which may no longer be a valid URL)
being used to generate fill_into_edit.

This can cause ellipses entering the fill_into_edit. This CL fixes
those cases.

Bug:  758423 
Change-Id: I96c69e6653e2f1d2aa97f91c5f41d26ee5b25077
Reviewed-on: https://chromium-review.googlesource.com/630698
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497473}
[modify] https://crrev.com/0beb815a054f2f944baf9e7aaa3fd308f0e92916/components/omnibox/browser/physical_web_provider.cc
[modify] https://crrev.com/0beb815a054f2f944baf9e7aaa3fd308f0e92916/components/omnibox/browser/titled_url_match_utils.cc
[modify] https://crrev.com/0beb815a054f2f944baf9e7aaa3fd308f0e92916/components/omnibox/browser/zero_suggest_provider.cc

Fixed?
Status: Fixed (was: Started)
I just did another pass using Codesearch and I think this is fixed now.

Sign in to add a comment