New issue
Advanced search Search tips

Issue 758422 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Parts of window not redrawn when frame button layout changes

Project Member Reported by thomasanderson@chromium.org, Aug 24 2017

Issue description

Repro: Change your window button ordering settings such that at least one button gets placed at the opposite side of the window.

When chrome updates, the buttons will be drawn correctly, but the tabstrip fails to redraw, causing overlapping buttons with tabs.
 
Screenshot from 2017-08-23 17-03-35.png
6.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b046099adcfa1192152a02d8106340a71bdb87b0

commit b046099adcfa1192152a02d8106340a71bdb87b0
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 29 01:10:11 2017

Linux: Relayout tabstrip when frame button ordering changes

When the button ordering changes, a relayout got triggered only for
the OpaqueBrowserFrameView for the window, but not for the tabstrip.
This caused buttons to overlap with the tabstrip until you did
something to relayout the window (like a resize).  This CL always does
a relayout of the parent view (which includes the tabstrip).

R=pkasting@chromium.org
CC=​erg@chromium.org
BUG= 758422 

Change-Id: I18227d95092d68ede1bc4924f33e8ac9751f8b14
Reviewed-on: https://chromium-review.googlesource.com/630761
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497969}
[modify] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

Status: Fixed (was: Started)
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
thomasanderson@,

Tried to change the order of buttons on Ubuntu 14.04 but we are unable to change in ubuntu settings.Could you please help us with clear steps to check this issue from TE end.

Thanks in advance..!!
The fix is unfortunately not available in Ubuntu 14.04.  It requires GTK3.14+, but 14.04 only has GTK3.10.

Sign in to add a comment