Add browser test for the translate component |
||
Issue descriptionAdd browser test for the translate component We need to test the following scenarios: 1) Every time a page is visited, translate ui pops up properly and the model is recording the language. 2) Visit different page will not break, and no stale states. 3) Translate-> Revert will not break 4) Incognito page will not record anything.
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/075e24e0cabeb7eb6981bd9ce5a301c6b0c51887 commit 075e24e0cabeb7eb6981bd9ce5a301c6b0c51887 Author: Gustav Sennton <gsennton@chromium.org> Date: Thu Sep 07 09:54:53 2017 Revert "Add missing translate browser test, current two:" This reverts commit 270e75744242cd7d88d6a52e15a1749e0b2803d0. Reason for revert: The LanguageModelLogSucceed test is flaky on the Linux Tests bot, see crbug.com/762875 Original change's description: > Add missing translate browser test, current two: > > 1) go to french/english page 10 times, and french 1 time > more, and make sure the histogram model logs properly. > > 2) change to incognito, repeat test case 1, and make sure no url > language histograms. > > Bug: 758414 > Change-Id: I49123e632f876fdb0953f664beab1bcd0ebb5976 > Reviewed-on: https://chromium-review.googlesource.com/630337 > Commit-Queue: Renjie Liu <renjieliu@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500202} TBR=pkasting@chromium.org,hajimehoshi@chromium.org,renjieliu@chromium.org,jochen@chromium.org,napper@chromium.org,martis@chromium.org Change-Id: I3ef286c50fe3dd1297c148fda4d6f637c6a111c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758414 Reviewed-on: https://chromium-review.googlesource.com/654258 Reviewed-by: Gustav Sennton <gsennton@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#500260} [delete] https://crrev.com/f181c11ae2db3aac9abadb2fce12682677c23430/chrome/browser/ui/views/translate/translate_language_browsertest.cc [modify] https://crrev.com/075e24e0cabeb7eb6981bd9ce5a301c6b0c51887/chrome/test/BUILD.gn
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a17f3044980d0e7079715222a3a2a1483a2f7ff commit 8a17f3044980d0e7079715222a3a2a1483a2f7ff Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Sep 07 10:13:10 2017 Revert "Add missing translate browser test, current two:" This reverts commit 270e75744242cd7d88d6a52e15a1749e0b2803d0. Reason for revert: the tests are flaky See details here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44211 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44210 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44206 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44194 Original change's description: > Add missing translate browser test, current two: > > 1) go to french/english page 10 times, and french 1 time > more, and make sure the histogram model logs properly. > > 2) change to incognito, repeat test case 1, and make sure no url > language histograms. > > Bug: 758414 > Change-Id: I49123e632f876fdb0953f664beab1bcd0ebb5976 > Reviewed-on: https://chromium-review.googlesource.com/630337 > Commit-Queue: Renjie Liu <renjieliu@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500202} TBR=pkasting@chromium.org,hajimehoshi@chromium.org,renjieliu@chromium.org,jochen@chromium.org,napper@chromium.org,martis@chromium.org Change-Id: Ieecbc9d6eb87512ff3112b1cb83af84d3502a831 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758414 Reviewed-on: https://chromium-review.googlesource.com/654757 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#500264}
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0455b33d89902bf3a314b652342fae57c0fb5a04 commit 0455b33d89902bf3a314b652342fae57c0fb5a04 Author: Renjie Liu <renjieliu@chromium.org> Date: Thu Sep 14 04:05:43 2017 Add Translate then Revert browser test. The third test case: Translate then revert, make sure the mojo did not break. Bug: 758414 Change-Id: Ic4410e9b2c152110b722b38f5488928a12d7d118 Reviewed-on: https://chromium-review.googlesource.com/657500 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#501864} [modify] https://crrev.com/0455b33d89902bf3a314b652342fae57c0fb5a04/chrome/browser/ui/translate/translate_bubble_test_utils.h [modify] https://crrev.com/0455b33d89902bf3a314b652342fae57c0fb5a04/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc [modify] https://crrev.com/0455b33d89902bf3a314b652342fae57c0fb5a04/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/0455b33d89902bf3a314b652342fae57c0fb5a04/chrome/browser/ui/views/translate/translate_language_browsertest.cc [modify] https://crrev.com/0455b33d89902bf3a314b652342fae57c0fb5a04/chrome/test/BUILD.gn
,
Sep 14 2017
fulfilled the contract (cover the listed cases), closing the bug. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2017