New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758395 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

During scrolling, all apps indicator is not correctly laid out

Project Member Reported by warx@chromium.org, Aug 23 2017

Issue description

Please see the attached video, started from 10s
 
indicator.webm
4.9 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b3a01e2f93d1732e1490a0da3e62161eca3f32e

commit 9b3a01e2f93d1732e1490a0da3e62161eca3f32e
Author: Qiang Xu <warx@chromium.org>
Date: Tue Aug 29 22:52:06 2017

app_list: fix layout issues for suggested apps and indicator when scrolling

changes:
(1) Move 48px from CalculateIdealBounds to CalculateTransitionOffset, the
former one only applies to all apps tiles.
(2) remove transition > 0 and forward/backward restrictions, apply the
adjustments to both previous and next page.

(1) will fix 760238 and 758395, (2) will fix 760243.

Test: test with fullscreen app list flag.
Bug:  760238 ,  758395 ,  760243 
Change-Id: Ifb0cc8add4376f549a602588b736d92c5cc3520f
Reviewed-on: https://chromium-review.googlesource.com/641615
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498268}
[modify] https://crrev.com/9b3a01e2f93d1732e1490a0da3e62161eca3f32e/ui/app_list/views/apps_grid_view.cc

Comment 2 by warx@chromium.org, Aug 29 2017

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 29 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.

Comment 5 by warx@chromium.org, Aug 30 2017

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31cce5deb03cd5100db2ca85abe8257af1054ecf

commit 31cce5deb03cd5100db2ca85abe8257af1054ecf
Author: Vadim Tryshev <vadimt@google.com>
Date: Thu Aug 31 22:49:57 2017

app_list: fix layout issues for suggested apps and indicator when scrolling

changes:
(1) Move 48px from CalculateIdealBounds to CalculateTransitionOffset, the
former one only applies to all apps tiles.
(2) remove transition > 0 and forward/backward restrictions, apply the
adjustments to both previous and next page.

(1) will fix 760238 and 758395, (2) will fix 760243.

TBR=warx@chromium.org

(cherry picked from commit 9b3a01e2f93d1732e1490a0da3e62161eca3f32e)

Test: test with fullscreen app list flag.
Bug:  760238 ,  758395 ,  760243 
Change-Id: Ifb0cc8add4376f549a602588b736d92c5cc3520f
Reviewed-on: https://chromium-review.googlesource.com/641615
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498268}
Reviewed-on: https://chromium-review.googlesource.com/646835
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1059}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/31cce5deb03cd5100db2ca85abe8257af1054ecf/ui/app_list/views/apps_grid_view.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment