New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add tooltips to buttons in shelf that don't have them

Project Member Reported by mcirimele@chromium.org, Aug 23 2017

Issue description

What steps will reproduce the problem?
(1) Use the mouse cursor to hover over Stylus menu button or notifications button in shelf
(2) Notice there are no tooltips

What is the expected result?
A tooltip is shown with a label for each button, like when you hover over pinned apps or the time.

What happens instead?
Nothing is shown. 

I propose we add tooltips for at least the stylus menu button and the notifications button and that we use "Stylus tools" and "Notifications" as strings. We should also consider if we want to add tooltips to the system tray icons like Network / Battery / User or just leave it as is with the time being the only part with a tooltip.
 
Cc: minch@chromium.org
minch@ is this something you can take over?

Comment 2 by minch@chromium.org, Sep 7 2017

Cc: -minch@chromium.org omrilio@chromium.org
Labels: OS-Chrome
Owner: minch@chromium.org
Status: Assigned (was: Untriaged)
sure, I can take this. But what to do is to add tooltips for stylus menu button and the notifications button currently?

Comment 3 by minch@chromium.org, Oct 9 2017

Status: Started (was: Assigned)
Will add the tooltips to stylus menu button and notifications button in this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f492034f45d22a21f3108f4723949014219820ec

commit f492034f45d22a21f3108f4723949014219820ec
Author: MinChen <minch@chromium.org>
Date: Mon Oct 09 23:57:46 2017

Add tooltips to stylus/ IME/ notifications button in shelf.

Bug:  758386 
Change-Id: I300bd76fdd09d8bb6c61d235dc3b9abb525b53d9
Reviewed-on: https://chromium-review.googlesource.com/707760
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507545}
[modify] https://crrev.com/f492034f45d22a21f3108f4723949014219820ec/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/f492034f45d22a21f3108f4723949014219820ec/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/f492034f45d22a21f3108f4723949014219820ec/ash/system/web_notification/web_notification_tray.cc

Comment 5 by minch@chromium.org, Oct 11 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment