New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Incorrect Color in Global Error Menu

Project Member Reported by spqc...@chromium.org, Aug 23 2017

Issue description

In Linux, the 3-dot menu color did not get changed. Its displaying in black color only. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f17b009d027726cbfac8fd07d4672c9f1f0e98

commit 28f17b009d027726cbfac8fd07d4672c9f1f0e98
Author: Sarah Chan <spqchan@chromium.org>
Date: Fri Aug 25 20:41:18 2017

[Views] Fix Animated App Menu Icon Color on Linux

On Linux, the system theme is different from the
default theme, which causes the icon color to be
incorrectly set.

Bug:  758384 
Change-Id: I2dc6df460f0011edb57eb268640fd693590681b6
Reviewed-on: https://chromium-review.googlesource.com/634571
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497527}
[modify] https://crrev.com/28f17b009d027726cbfac8fd07d4672c9f1f0e98/chrome/browser/ui/views/toolbar/app_menu_button.cc

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Ubuntu 14.04 with chrome Beta #61.0.3163.59 & Canary #62.0.3198.0

Installed Test theme on both versions and observed the same behavior of 3 dot wrench icon color in both channels.

Attaching the screen-shot for reference.

spqchan@ Could you please look into it and let us know your observations.

Test theme : https://chrome.google.com/webstore/detail/black-carbon-%2B-silver-met/lodhggoaglindpoejnjldimdlikkphph?hl=en
758384-Canary.png
113 KB View Download
758384-Beta.png
90.2 KB View Download
Can you test this with --simulate-crtical-update? Both icons should be red
Labels: TE-Verified-62.0.3198.0 TE-Verified-M62
Tested the issue on Ubutu 14.04 using Chrome version M62 - 62.0.3198.0 as per the issue mentioned in original comment. Observed that issue is working as intended (3 dot menu button replaced with Update button and is displayed in red colour when chrome is launched with --simulate-critical-update). Hence adding TE-Verified label. Attached the screenshot for reference.

Thank you!

758384-62.0.3198.0.png
90.6 KB View Download
758384-61.0.3163.59.png
99 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment