New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758379 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

moblab gs_offloader failing on M60

Project Member Reported by haddowk@chromium.org, Aug 23 2017

Issue description

  
the offloader is failing on 

CHROMEOS_RELEASE_BUILDER_PATH=guado_moblab-release/R60-9592.85.0

With the error:

File "/usr/local/autotest/site_utils/gs_offloader.py", line 1036, in <module>
    main()
  File "/usr/local/autotest/site_utils/gs_offloader.py", line 1029, in main
    offloader.offload_once()
  File "/usr/local/autotest/site_utils/gs_offloader.py", line 863, in offload_once
    job.enqueue_offload(queue, self._upload_age_limit)
  File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/usr/lib64/python2.7/site-packages/chromite/lib/parallel.py", line 750, in BackgroundTaskRunner
    queue.put(_AllTasksComplete())
  File "/usr/lib64/python2.7/site-packages/chromite/lib/parallel.py", line 750, in BackgroundTaskRunner
    queue.put(_AllTasksComplete())
  File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/usr/lib64/python2.7/site-packages/chromite/lib/parallel.py", line 561, in ParallelTasks
    raise BackgroundFailure(exc_infos=errors)
chromite.lib.parallel.BackgroundFailure: <type 'exceptions.UnboundLocalError'>: local variable 'stderr_content' referenced before assignment
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/chromite/lib/parallel.py", line 602, in TaskRunner
    task(*x, **task_kwargs)
  File "/usr/lib64/python2.7/site-packages/chromite/lib/metrics.py", line 303, in wrapper
    return fn(*args, **kwargs)
  File "/usr/local/autotest/site_utils/gs_offloader.py", line 686, in offload_dir
    if 'CommandException: Error opening file' in stderr_content:
UnboundLocalError: local variable 'stderr_content' referenced before assignment


 
Owner: haddowk@chromium.org

Comment 2 by dshi@chromium.org, Aug 23 2017

Cc: ayatane@chromium.org
I think a previous fix of mine exposed this issue - I have a cl out for review
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/609c7316c7418ff48bda655651332130f5b10a43

commit 609c7316c7418ff48bda655651332130f5b10a43
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Aug 23 23:35:25 2017

[moblab]  Fix issue with uninitialized variable in gs_offloader

Previous fixes exposed a condition where a variable was accessed
before being set, fix.

BUG= chromium:758379 
TEST=Ran on local moblab

Change-Id: Ib8b12da6987dfd90455ca072c1fc058935e443ff
Reviewed-on: https://chromium-review.googlesource.com/630477
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/609c7316c7418ff48bda655651332130f5b10a43/site_utils/gs_offloader.py

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment