[OOBE flow] Capturing picture through camera is not working, at 'Set your profile photo' step. |
||||||||
Issue descriptionChrome OS version: 62.0.3194.0, dev build Platform version: 9871.0.0, dev channel cave device M-62 build This issue is related to launch bug Issue 721647. Steps to reproduce the problem: 1. During the OOBE flow, at the 'Set your profile picture' step. 2. Click on the camera icon and select 'Take photo' option. 3. Observed that picture is not captured. What is the expected behavior? Capturing picture through camera should work, at 'Set your profile photo' step during the OOBE flow Please refer the attachment.
,
Aug 24 2017
,
Aug 24 2017
https://chromium-review.googlesource.com/c/chromium/src/+/632656 should fix this.
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e97d4cfc98db146faef458af9df69ea86efd49a2 commit e97d4cfc98db146faef458af9df69ea86efd49a2 Author: David Reveman <reveman@chromium.org> Date: Thu Aug 24 18:47:05 2017 Change Picture: Fix OOBE photo capture. While making the UI revert to default profile picture when discarding last photo/file we accidentally broke photo taking from OOBE screen. That was because we had code that relied on being able to pass undefined imageIndex to setOldImageUrl and not have it default to 0 and select default image. This removes the default value for imageIndex in setOldImageUrl and instead makes the photo discard code that used this pass CrPicture.kDefaultImageUrl as imageUrl, which will result in the same behavior while still allowing the photo taking code to use this with undefined imageIndex and get the behavior it expects. Bug: 758378 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d5ae32e1daae37ec529771376967e8f89db5fc4 Reviewed-on: https://chromium-review.googlesource.com/632656 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497143} [modify] https://crrev.com/e97d4cfc98db146faef458af9df69ea86efd49a2/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/e97d4cfc98db146faef458af9df69ea86efd49a2/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/e97d4cfc98db146faef458af9df69ea86efd49a2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 24 2017
,
Aug 24 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24 2017
Approving merge to M61 Chrome OS.
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8448cc86230de110492f5e97544f2abb4810fe commit 0e8448cc86230de110492f5e97544f2abb4810fe Author: David Reveman <reveman@chromium.org> Date: Fri Aug 25 08:17:29 2017 Change Picture: Fix OOBE photo capture. While making the UI revert to default profile picture when discarding last photo/file we accidentally broke photo taking from OOBE screen. That was because we had code that relied on being able to pass undefined imageIndex to setOldImageUrl and not have it default to 0 and select default image. This removes the default value for imageIndex in setOldImageUrl and instead makes the photo discard code that used this pass CrPicture.kDefaultImageUrl as imageUrl, which will result in the same behavior while still allowing the photo taking code to use this with undefined imageIndex and get the behavior it expects. TBR=reveman@chromium.org (cherry picked from commit e97d4cfc98db146faef458af9df69ea86efd49a2) Bug: 758378 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d5ae32e1daae37ec529771376967e8f89db5fc4 Reviewed-on: https://chromium-review.googlesource.com/632656 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497143} Reviewed-on: https://chromium-review.googlesource.com/634709 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#884} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0e8448cc86230de110492f5e97544f2abb4810fe/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/0e8448cc86230de110492f5e97544f2abb4810fe/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/0e8448cc86230de110492f5e97544f2abb4810fe/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 25 2017
,
Aug 31 2017
Verified on M-61 beta build (Chrome OS 9765.50.0, 61.0.3163.72) as well as M-62 dev build (Chrome OS 9895.0.0, 62.0.3199.0). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by reve...@chromium.org
, Aug 24 2017Owner: reve...@chromium.org
Status: Assigned (was: Untriaged)