New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758376 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

If Bluetooth is not present, Tether should be UNAVAILABLE

Project Member Reported by khorimoto@chromium.org, Aug 23 2017

Issue description

Currently, if Bluetooth is not present, we set Tether to be UNINITIALIZED. This causes us to display the "enable Bluetooth to use tethering" UI. If we get in this situation, we shouldn't display any tether-related UI.

This situation is especially true if we hit issue 752664.
 
To clarify: are you proposing that if Bluetooth is not present, Tether technology should be unavailable, but if Bluetooth is simply unpowered, then Tether technology should continue to be uninitialized?
Yes.
Status: Started (was: Assigned)
sgtm
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0de4f5aed65ec8f985d1d18a793035ead8a92a4e

commit 0de4f5aed65ec8f985d1d18a793035ead8a92a4e
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Aug 23 23:38:21 2017

[CrOS Tether] If Bluetooth is not present, disable Tether entirely.

Previously, we assumed that if Bluetooth was not fully enabled, then
it was simply turned off by the user. In this case, we would show some
"enable Bluetooth" UI surfaces.

However, there are actually cases where Bluetooth is not present on the
system at all, so we should not display this UI. Additionally, there
are some bugs which cause Bluetooth to be hidden (crbug.com/752664).

This CL changes our logic so that Tether-related UI is never shown at
all.

Bug:  758376 , 672263
Change-Id: Id923e056524ab000e8e9901916e14b77d775c264
Reviewed-on: https://chromium-review.googlesource.com/630360
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496866}
[modify] https://crrev.com/0de4f5aed65ec8f985d1d18a793035ead8a92a4e/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/0de4f5aed65ec8f985d1d18a793035ead8a92a4e/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/0de4f5aed65ec8f985d1d18a793035ead8a92a4e/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/0de4f5aed65ec8f985d1d18a793035ead8a92a4e/tools/metrics/histograms/enums.xml

Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ketakid@google.com, Aug 24 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dff3ebb898420b12213bf0dcedb092578333fb24

commit dff3ebb898420b12213bf0dcedb092578333fb24
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 24 01:11:25 2017

[CrOS Tether] If Bluetooth is not present, disable Tether entirely.

Previously, we assumed that if Bluetooth was not fully enabled, then
it was simply turned off by the user. In this case, we would show some
"enable Bluetooth" UI surfaces.

However, there are actually cases where Bluetooth is not present on the
system at all, so we should not display this UI. Additionally, there
are some bugs which cause Bluetooth to be hidden (crbug.com/752664).

This CL changes our logic so that Tether-related UI is never shown at
all.

TBR=khorimoto@google.com

(cherry picked from commit 0de4f5aed65ec8f985d1d18a793035ead8a92a4e)

Bug:  758376 , 672263
Change-Id: Id923e056524ab000e8e9901916e14b77d775c264
Reviewed-on: https://chromium-review.googlesource.com/630360
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496866}
Reviewed-on: https://chromium-review.googlesource.com/631120
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#846}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/dff3ebb898420b12213bf0dcedb092578333fb24/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/dff3ebb898420b12213bf0dcedb092578333fb24/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/dff3ebb898420b12213bf0dcedb092578333fb24/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/dff3ebb898420b12213bf0dcedb092578333fb24/tools/metrics/histograms/enums.xml

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment