New issue
Advanced search Search tips

Issue 758368 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

PathService::Get(base::DIR_SOURCE_ROOT, ...) returns wrong value on OSX in Mojo processes

Project Member Reported by mmenke@chromium.org, Aug 23 2017 
PathService::Get(base::DIR_SOURCE_ROOT, ...) returns the wrong value on OSX in Mojo processes.  In particular, PathProviderMac expects the binary to be at src/foo/bar/Chromium.app/Contents/MacOS/Chromium, but the helper binaries are in src/foo/bar/Chromium.app/Contents/Frameworks/Content Shell Helper.app/Contents/MacOS.

This came up in https://chromium-review.googlesource.com/c/chromium/src/+/624067, where I'm trying to install test root certs in the network service's process.

Comment 1 by mmenke@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)
Forgot to reference this bug on the CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd131f2f5352b20469f0866e5377077967fa04a4

commit bd131f2f5352b20469f0866e5377077967fa04a4
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Aug 24 19:47:11 2017

Install test root certs in NetworkServiceTestHelper.

This allows browser tests that use EmbeddedTestServers of TYPE_HTTPS
to avoid running into SSL errors when the network service is enabled.

Also enable a small number of content_browsertests that were using
HTTPS servers, though most remain disabled, since most such tests
cover other things that aren't hooked up yet.

Also fix base::DIR_SOURCE_ROOT in content/shell on OSX subprocesses.

Bug:  757088 
Change-Id: I8aeb3b253934f21b0b198e4c4f157a198bcc88c8
Reviewed-on: https://chromium-review.googlesource.com/624067
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497161}
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/content/shell/app/paths_mac.h
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/content/shell/app/paths_mac.mm
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/net/test/embedded_test_server/embedded_test_server.cc
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/net/test/embedded_test_server/embedded_test_server.h
[modify] https://crrev.com/bd131f2f5352b20469f0866e5377077967fa04a4/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment