New issue
Advanced search Search tips

Issue 758365 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Oct 2017
Cc:
steve...@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 665582


Sign in to add a comment

mash: Ctrl-Shift-Q doesn't logout or exit

Project Member Reported by jamescook@chromium.org, Aug 23 2017 
1. Run chrome --mash
2. Hit Ctrl-Shift-Q twice

This should sign out (or on Linux desktop quit the session), but it doesn't.

This log line is probably why:
[127605:127605:0823/134608.472226:2334927202371:ERROR:shell_delegate_mus.cc(66)] Not implemented reached in virtual void ash::ShellDelegateMus::Exit()

Either the shell delegate mojo method needs to be wired up (maybe through shutdown.mojom) or the code needs to be refactored to use the right signout/shutdown method.

Steven, this might be a good first mojo bug. Do you want to take it? It's not urgent.

Comment 1 by steve...@chromium.org, Aug 23 2017

Labels: M-63
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Sure, sounds good.

Comment 2 by steve...@chromium.org, Oct 3 2017

Status: Started (was: Assigned)

Comment 3 by steve...@chromium.org, Oct 4 2017

Blockedon: 665582
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905

commit d1b937b5e7e11fd12c73f95742ce1fbcf4b96905
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Oct 05 17:18:49 2017

Mash: elim ShellDelegate::Exit

Instead call SessionController::RequestSignOut which does
the same thing.

Bug:  758365 
Change-Id: I138b58a05a10a4cdc748896746a5acf14f9bb980
Reviewed-on: https://chromium-review.googlesource.com/699430
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506776}
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/session/session_aborted_dialog.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shell_delegate.h
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/shutdown_controller.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/test_shell_delegate.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/test_shell_delegate.h
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/d1b937b5e7e11fd12c73f95742ce1fbcf4b96905/chrome/browser/ui/ash/chrome_shell_delegate.h

Comment 5 by steve...@chromium.org, Oct 5 2017

Status: Fixed (was: Started)

Comment 6 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment