Remove Physical Web Setting from Low-end |
|||||||
Issue descriptionWe've disabled physical web scans on low-end devices, but still have a non-functional setting. From https://bugs.chromium.org/p/chromium/issues/detail?id=736138#c22 "Good question, I suspect yes it will still show setting, and enabling the feature will not work. (I will need to double check, don't have a low-end device to test on) I think we should go one of two routes: 1. Make PW impossible to turn on, and remove the privacy setting entirely. 2. Make PW default-off, but leave the privacy setting for those who want to enable it explicitly. It looks like today we make it impossible to turn on, but leave the setting, which is a bad combination. I prefer option (2), but think option (1) is probably fine."
,
Aug 28 2017
Verified on M62-62.0.3198.0 build, now Physical-web option removed from Privacy on Low-end devices Tested device -Samsung Galaxy J1(SM-J100H)/KTU84P
,
Aug 28 2017
As discussed in person -- this is now verified as removed. It's a safe change in product excellence category to ensure we don't expose an unusable setting.
,
Aug 28 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
OK, we can take this if we merge it today. Approved for M61 branch 3163.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fcda4885c7a3a28fc37e263e9906c37cb3f7136 commit 5fcda4885c7a3a28fc37e263e9906c37cb3f7136 Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Tue Aug 29 17:17:24 2017 Do not show physical web preference on low-end. Since we've disabled physical web for low-end devices, do not show the preference. BUG= 758358 Change-Id: I7efba61b505416c5dcb20c79ad981d53691485a9 Reviewed-on: https://chromium-review.googlesource.com/629818 Reviewed-by: Conley Owens <cco3@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497127}(cherry picked from commit ba096e2f4e770bfe52e0af69a5f67c159633cec8) Reviewed-on: https://chromium-review.googlesource.com/641574 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#973} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5fcda4885c7a3a28fc37e263e9906c37cb3f7136/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
,
Aug 29 2017
,
Aug 30 2017
Verified in M61-61.0.3163.72 build on Low-end device(Samsung Galaxy J1(SM-J100H)) Now Physical-web option is removed from preference on Low-end devices |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 24 2017