New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758355 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deprecate content::UtilityProcessHost

Project Member Reported by jcivelli@chromium.org, Aug 23 2017

Issue description

As a first step towards moving process start-up to the ServiceManager, we should change all classes that directly rely on content::UtilityProcessHost to use a Mojo service instead started by the ServiceManager.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589166c11e590a1f5a54cdf2804fc9fca58e9654

commit 589166c11e590a1f5a54cdf2804fc9fca58e9654
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Aug 31 01:22:51 2017

Adding a browser test to validate printing::PWGRasterConverter.

Adding a basic browser test to validate printing::PWGRasterConverter.
This is done prior to upcoming mojofication and servicification of that
class.

Bug:  758355 
Change-Id: I80a10f68c8b68a1e5cd13d9c43ff0076ded9a577
Reviewed-on: https://chromium-review.googlesource.com/643470
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498699}
[add] https://crrev.com/589166c11e590a1f5a54cdf2804fc9fca58e9654/chrome/browser/printing/pwg_raster_converter_browsertest.cc
[modify] https://crrev.com/589166c11e590a1f5a54cdf2804fc9fca58e9654/chrome/test/BUILD.gn
[add] https://crrev.com/589166c11e590a1f5a54cdf2804fc9fca58e9654/chrome/test/data/printing/pdf_to_pwg_raster_test.pdf
[add] https://crrev.com/589166c11e590a1f5a54cdf2804fc9fca58e9654/chrome/test/data/printing/pdf_to_pwg_raster_test.pwg

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac006bf40d1ac79e95e54aed2409acaf1b3ea236

commit ac006bf40d1ac79e95e54aed2409acaf1b3ea236
Author: Henrik Boström <hbos@chromium.org>
Date: Thu Aug 31 11:01:11 2017

Revert "Adding a browser test to validate printing::PWGRasterConverter."

This reverts commit 589166c11e590a1f5a54cdf2804fc9fca58e9654.

Reason for revert:
Suspected culprit of consistent PDFToPWGRasterBrowserTest.TestSuccess
failures on Linux Tests (dbg)(1), see
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/43824

I can't repro locally but this is the only CL touching pdf to pwg
related files.

Original change's description:
> Adding a browser test to validate printing::PWGRasterConverter.
> 
> Adding a basic browser test to validate printing::PWGRasterConverter.
> This is done prior to upcoming mojofication and servicification of that
> class.
> 
> Bug:  758355 
> Change-Id: I80a10f68c8b68a1e5cd13d9c43ff0076ded9a577
> Reviewed-on: https://chromium-review.googlesource.com/643470
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498699}

TBR=thestig@chromium.org,jcivelli@chromium.org,rbpotter@chromium.org

Change-Id: I40fd9d090b27655ffc5f24ce71557aba10d18dd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  758355 
Reviewed-on: https://chromium-review.googlesource.com/645646
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498812}
[delete] https://crrev.com/618571dabe915ca380db2317a6f688529ca3854e/chrome/browser/printing/pwg_raster_converter_browsertest.cc
[modify] https://crrev.com/ac006bf40d1ac79e95e54aed2409acaf1b3ea236/chrome/test/BUILD.gn
[delete] https://crrev.com/618571dabe915ca380db2317a6f688529ca3854e/chrome/test/data/printing/pdf_to_pwg_raster_test.pdf
[delete] https://crrev.com/618571dabe915ca380db2317a6f688529ca3854e/chrome/test/data/printing/pdf_to_pwg_raster_test.pwg

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d53be9b64e63c5fd8525d5a76ca172abab9d205

commit 4d53be9b64e63c5fd8525d5a76ca172abab9d205
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Aug 31 22:01:43 2017

Making the profile importer a Mojo service.

Changing the profile importer to be a Mojo service, resolved through the
ServiceManager.
This is part of the effort of deprecating the use of UtilityProcessHost.

Bug:  758355 
Change-Id: Id4860e2e0559d7c72201dbf4c3157238c7efc878
Reviewed-on: https://chromium-review.googlesource.com/629797
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499029}
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/app/BUILD.gn
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/browser/importer/external_process_importer_client.cc
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/browser/importer/external_process_importer_client.h
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/common/importer/profile_import.mojom
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/BUILD.gn
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/OWNERS
[rename] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/profile_import_impl.cc
[rename] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/profile_import_impl.h
[add] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/profile_import_manifest.json
[add] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/profile_import_service.cc
[add] https://crrev.com/4d53be9b64e63c5fd8525d5a76ca172abab9d205/chrome/utility/importer/profile_import_service.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67522843fc18901d1c95fc35671b085677680f68

commit 67522843fc18901d1c95fc35671b085677680f68
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Sep 07 22:48:35 2017

Removing Picasa support from the MediaGalleries API.

Removing Picasa support from the MediaGalleries API and removing any
Picasa related file.

Bug:  762985 ,  758355 ,  567212 
Tbr: sky, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I9612d2ad2407d167ac8462b51d1eddee5d70cf9e
Reviewed-on: https://chromium-review.googlesource.com/650948
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500420}
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/WATCHLISTS
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/BUILD.gn
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_data_provider.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_file_util.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_file_util.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_finder.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_finder.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/picasa_finder_mac.mm
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/imported_media_gallery_registry.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/imported_media_gallery_registry.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_histograms.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_preferences.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/browser/media_galleries/media_galleries_test_util.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/common/BUILD.gn
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/common/extensions/chrome_utility_extensions_messages.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/picasa_test_util.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/picasa_test_util.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/picasa_types.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/picasa_types.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/pmp_constants.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/pmp_test_util.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/common/media_galleries/pmp_test_util.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/test/BUILD.gn
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/test/data/extensions/api_test/media_galleries/picasa/manifest.json
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/test/data/extensions/api_test/media_galleries/picasa/test.js
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/utility/BUILD.gn
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/chrome/utility/extensions/extensions_handler.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_album_table_reader.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_album_table_reader.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_album_table_reader_unittest.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_albums_indexer.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_albums_indexer.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/picasa_albums_indexer_unittest.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/pmp_column_reader.cc
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/pmp_column_reader.h
[delete] https://crrev.com/54d0281a26e9adcb84c235d26aaf6989b95c60f2/chrome/utility/media_galleries/pmp_column_reader_unittest.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/components/storage_monitor/media_storage_util.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/components/storage_monitor/storage_info.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/components/storage_monitor/storage_info.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/content/browser/renderer_host/pepper/pepper_file_io_host.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/storage/common/fileapi/file_system_types.h
[modify] https://crrev.com/67522843fc18901d1c95fc35671b085677680f68/storage/common/fileapi/file_system_util.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf99550c9df48abf9c6b32a062320a26bf1624cd

commit cf99550c9df48abf9c6b32a062320a26bf1624cd
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Sep 08 23:59:27 2017

Removing iTunes support from media_gallery API.

Removing iTunes support from media_gallery API on Windows and Mac, as it is
not maintained and has been broken on Windows since iTunes changed its
configuration file locations more than a year ago.

Bug:  762991 , 758355 
Tbr: tsepez, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I258659e5241f27f5ad2b0cc86ba8f902f77a32e7
Reviewed-on: https://chromium-review.googlesource.com/646801
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500748}
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/WATCHLISTS
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_data_provider.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_mac.mm
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/imported_media_gallery_registry.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/imported_media_gallery_registry.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_histograms.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_test_util.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/common_message_generator.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/extensions/chrome_utility_extensions_messages.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/extensions/docs/templates/intros/mediaGalleries.html
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/media_galleries/itunes_library.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/media_galleries/itunes_library.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/test/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/extensions/extensions_handler.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/iapps_xml_utils.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/iapps_xml_utils.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser_unittest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_pref_parser_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_pref_parser_win.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/media_storage_util.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/storage_info.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/storage_info.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/content/browser/renderer_host/pepper/pepper_file_io_host.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/common/fileapi/file_system_types.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/common/fileapi/file_system_util.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ff353372f72e2cab97316591c36cf398f39a9e

commit 91ff353372f72e2cab97316591c36cf398f39a9e
Author: Jay Civelli <jcivelli@chromium.org>
Date: Tue Sep 19 17:46:31 2017

Mojofying printing::PWGRasterConverter.

Changing printing::PWGRasterConverter to use Mojo.
Moving the generation code from printing_handler.cc to its own file.

Bug:  758355 
Change-Id: Iaeca1665cd49c08794a6146e7ee75c694bf946d8
Reviewed-on: https://chromium-review.googlesource.com/636743
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502884}
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/browser/printing/pwg_raster_converter.cc
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/BUILD.gn
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/chrome_utility_printing_messages.h
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/BUILD.gn
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/OWNERS
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/pdf_to_pwg_raster_converter.mojom
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/pdf_to_pwg_raster_converter.typemap
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/pdf_to_pwg_raster_converter_struct_traits.cc
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/pdf_to_pwg_raster_converter_struct_traits.h
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/common/printing/typemaps.gni
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/BUILD.gn
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/chrome_content_utility_client.cc
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/printing/pdf_to_pwg_raster_converter_impl.cc
[add] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/printing/pdf_to_pwg_raster_converter_impl.h
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/printing_handler.cc
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/utility/printing_handler.h
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/content/public/app/mojo/content_utility_manifest.json
[modify] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9237eac57ecddd07c0f9c26648d31b46fa8df8d9

commit 9237eac57ecddd07c0f9c26648d31b46fa8df8d9
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Sep 21 16:10:21 2017

Servicifying PWGRasterConverter.

Changing PWGRasterConverterHelper to use a new service and relying on
the service manager for creating the child process instead of using
UtilityProcessHost.
This is part of the effort to deprecate the use of UtilityProcessHost.

Bug:  758355 
Change-Id: I7746dbab8485bdbe2310e2abe934e35106b59e40
Reviewed-on: https://chromium-review.googlesource.com/639031
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503458}
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/app/BUILD.gn
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/browser/printing/pwg_raster_converter.cc
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/common/printing/pdf_to_pwg_raster_converter.mojom
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/BUILD.gn
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/chrome_content_utility_client.cc
[add] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/OWNERS
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/pdf_to_pwg_raster_converter_impl.cc
[modify] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/pdf_to_pwg_raster_converter_impl.h
[add] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/pdf_to_pwg_raster_converter_manifest.json
[add] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/pdf_to_pwg_raster_converter_service.cc
[add] https://crrev.com/9237eac57ecddd07c0f9c26648d31b46fa8df8d9/chrome/utility/printing/pdf_to_pwg_raster_converter_service.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df2464ba2170bf3d4a4431b5d2288a96d744277

commit 2df2464ba2170bf3d4a4431b5d2288a96d744277
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Oct 09 20:22:28 2017

Servicifying net::MojoProxyResolverFactory.

Making net::MojoProxyResolverFactory a service and removing its use of
UtilityProcessHost.

Also renaming the interface implementations from MojoProxyResolverImpl/
MojoProxyResolverFactoryImpl to ProxyResolverImpl/
ProxyResolverFactoryImpl as is customary.

Also moving files not needed by the proxy service from
services/proxy_service to content/:
proxy_resolver_factory_mojo.[h,cc]
proxy_service_mojo.[h,cc]
test_mojo_proxy_resolver_factory.[h,cc]
mojo_proxy_resolver_factory.h

Bug:  758355 
Change-Id: I106f2f3979d41db2ceed554991591653c900ab46
Reviewed-on: https://chromium-review.googlesource.com/651340
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507467}
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/app/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/DEPS
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/net/DEPS
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/net/chrome_mojo_proxy_resolver_factory.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/net/chrome_mojo_proxy_resolver_factory.h
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/browser/net/chrome_mojo_proxy_resolver_factory_browsertest.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/test/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/utility/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/utility/DEPS
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/DEPS
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/DEPS
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/proxy_resolver_factory_mojo.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/proxy_resolver_factory_mojo.h
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/proxy_resolver_factory_mojo_unittest.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/proxy_service_mojo.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/network/proxy_service_mojo.h
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/network/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/network/DEPS
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/network/mojo_proxy_resolver_factory.h
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/network/url_request_context_builder_mojo.h
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/public/test/DEPS
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/DEPS
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/proxy_service_mojo_unittest.cc
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/test_mojo_proxy_resolver_factory.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/test_mojo_proxy_resolver_factory.h
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/content/test/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/BUILD.gn
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/OWNERS
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/manifest.json
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_factory_impl.cc
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_factory_impl.h
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_factory_impl_unittest.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_impl.cc
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_impl.h
[rename] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_impl_unittest.cc
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_service.cc
[add] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/proxy_resolver_service.h
[delete] https://crrev.com/8a6beb7ab5262f4566462d06db1dcaa00bb4522e/services/proxy_resolver/public/cpp/BUILD.gn
[delete] https://crrev.com/8a6beb7ab5262f4566462d06db1dcaa00bb4522e/services/proxy_resolver/public/cpp/mojo_proxy_resolver_factory_impl.h
[delete] https://crrev.com/8a6beb7ab5262f4566462d06db1dcaa00bb4522e/services/proxy_resolver/public/cpp/test_mojo_proxy_resolver_factory.cc
[modify] https://crrev.com/2df2464ba2170bf3d4a4431b5d2288a96d744277/services/proxy_resolver/public/interfaces/proxy_resolver.mojom

Components: Internals>Services>ServiceManager
Bulk applying component Internals>Services>ServiceManager to issues referencing the text ServiceManager.  This may not be 100% accurate, so please feel free to pull the component as needed.
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
It is safe to call this one Fixed. Thanks Jay :)

Sign in to add a comment