Issue metadata
Sign in to add a comment
|
Find in page doesn't scroll to show the match if the match is in an OOPIF |
||||||||||||||||||||||||
Issue descriptionREPRO STEPS: 1. Launch chrome with --site-per-process flag 2. Navigate to http://csreis.github.io/tests/cross-site-iframes.html 3. Click "Add Frame" button 3 times (to ensure the last frame is not visible / needs to be scrolled to) 4. Navigate the last/bottom frame cross-site by clicking "Go cross-site (complex page)" 5. Scroll the main frame to the top, so that the last/bottom frame is not visible 6. Ctrl-F and search for "Waterfall" EXPECTED BEHAVIOR: The main page scrolls to show the find-in-page results (this is the behavior without --site-per-process) ACTUAL BEHAVIOR: The main page doesn't scroll (i.e. going between different matches scrolls the subframe containing the matches, but this has in practice no visible effect when the main page doesn't scroll) WORK AROUND: The user can scroll the main frame manually (if the user knows about the workaround + knows which subframe contains the matches)
,
Aug 23 2017
I was wondering if only the main frame is scrolled (this is what I thought would happen based on the fact that WebViewImpl::ZoomToFindInPageRect operates only on the main frame). I've tried to test this and so far I see that the whole chain of frame owners gets scrolled: REPRO STEPS: 1. Navigate to http://csreis.github.io/tests/cross-site-iframes.html 2. Click "Add Frame" button 3 times (to ensure the last frame is not visible / needs to be scrolled to) 3. Inspect the last/bottom frame (let's call this frame Frame4) and also navigate it to http://csreis.github.io/tests/cross-site-iframes.html: 4. In Frame4 also click "Add Frame" button 3 times (to ensure the last subframe of Frame4 is not visible - let's call this frame Frame4bis) 5. Click "Go cross-site (complex page)" to navigate Frame4bis to Chromium waterfall page 6. Scroll the main frame and Frame4 to their tops, so that A) Frame4bis is not visible inside Frame4 and B) Frame4 is not visible in the main frame 7. Ctrl-F and search for "TryServers" (which appears below the fold in Frame4bis)
,
Aug 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/clusterfuzz/+/c3336a0113ab2d61cc9bb3b42b6da577ae539668 commit c3336a0113ab2d61cc9bb3b42b6da577ae539668 Author: Abhishek Arya <inferno@chromium.org> Date: Thu Aug 24 15:09:52 2017
,
Aug 24 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lukasza@chromium.org
, Aug 23 2017