New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758340 link

Starred by 1 user
Status: WontFix
Owner:
█ brettw@chromium.org
Last visit 25 days ago
Closed: Jan 2018
Cc:
nzolghadr@chromium.org
█ yzshen@chromium.org
█ r...@opera.com
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.1% regression in blink_perf.css at 494107:494277

Project Member Reported by nzolghadr@chromium.org, Aug 23 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 23 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=758340

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7704a4dd25a5c536f3031b889a02e5b633aac058f3debe748bff6c2165418640


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 24 2017

Cc: brettw@chromium.org
Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author brettw@chromium.org ===

Hi brettw@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Brett Wilson
  Commit : 3d88e7761486d1c453cc8ca97613fc0e213b247a
  Date   : Mon Aug 14 19:54:38 2017
  Subject: Convert some deque uses to base::circular_deque.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : FocusUpdate/FocusUpdate
  Change       : 5.55% | 19535.2119543 -> 18451.63977

Revision             Result                  N
chromium@494106      19535.2 +- 2670.7       21      good
chromium@494128      19782.9 +- 1105.91      9       good
chromium@494139      19838.1 +- 1863.59      9       good
chromium@494144      20187.4 +- 695.7        6       good
chromium@494145      17155.6 +- 774.728      6       bad       <--
chromium@494146      17401.5 +- 1211.9       6       bad
chromium@494147      17786.2 +- 1264.77      6       bad
chromium@494149      17921.8 +- 3050.72      9       bad
chromium@494191      17588.3 +- 1076.52      6       bad
chromium@494277      18451.6 +- 4303.43      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970443251927690016


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 24 2017 


=== Auto-CCing suspected CL author brettw@chromium.org ===

Hi brettw@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Brett Wilson
  Commit : 3d88e7761486d1c453cc8ca97613fc0e213b247a
  Date   : Mon Aug 14 19:54:38 2017
  Subject: Convert some deque uses to base::circular_deque.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : FocusUpdate/FocusUpdate
  Change       : 5.55% | 19535.2119543 -> 18451.63977

Revision             Result                  N
chromium@494106      19535.2 +- 2670.7       21      good
chromium@494128      19782.9 +- 1105.91      9       good
chromium@494139      19838.1 +- 1863.59      9       good
chromium@494144      20187.4 +- 695.7        6       good
chromium@494145      17155.6 +- 774.728      6       bad       <--
chromium@494146      17401.5 +- 1211.9       6       bad
chromium@494147      17786.2 +- 1264.77      6       bad
chromium@494149      17921.8 +- 3050.72      9       bad
chromium@494191      17588.3 +- 1076.52      6       bad
chromium@494277      18451.6 +- 4303.43      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970443251927690016


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 24 2017 


=== Auto-CCing suspected CL author brettw@chromium.org ===

Hi brettw@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Brett Wilson
  Commit : 3d88e7761486d1c453cc8ca97613fc0e213b247a
  Date   : Mon Aug 14 19:54:38 2017
  Subject: Convert some deque uses to base::circular_deque.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : FocusUpdate/FocusUpdate
  Change       : 5.55% | 19535.2119543 -> 18451.63977

Revision             Result                  N
chromium@494106      19535.2 +- 2670.7       21      good
chromium@494128      19782.9 +- 1105.91      9       good
chromium@494139      19838.1 +- 1863.59      9       good
chromium@494144      20187.4 +- 695.7        6       good
chromium@494145      17155.6 +- 774.728      6       bad       <--
chromium@494146      17401.5 +- 1211.9       6       bad
chromium@494147      17786.2 +- 1264.77      6       bad
chromium@494149      17921.8 +- 3050.72      9       bad
chromium@494191      17588.3 +- 1076.52      6       bad
chromium@494277      18451.6 +- 4303.43      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970443251927690016


For feedback, file a bug with component Speed>Bisection

Comment 6 by sullivan@chromium.org, Sep 21 2017

Cc: yzshen@chromium.org r...@opera.com
brettw: ping? bisect seems pretty clear this is a regression on blink_perf.css. Adding reviewer yzshen, and also ccing test owner rune in case he has guidance on how to prioritize this bug.

Comment 7 by sullivan@chromium.org, Jan 5 2018

Status: WontFix (was: Assigned)
WontFixing due to lack of activity.
►

Sign in to add a comment