Minimize mobile data quick settings when not in use |
||||||
Issue descriptionIf the user has a device which can possibly be used for tethering, we show the Mobile data section in quick settings. However, just because the device has the capability of serving as a tether host does not mean it actually will be used as one. For example, if the user's mobile data plan does not allow tethering, the phone cannot be used for this purpose. Similarly, if the user simply does not want to use mobile data and disables it, the section is still shown. The issue here is that the section is rather large (even if it is disabled, it takes up nearly half of the quick settings network pane) and that it is listed on top, before Wi-Fi. If a user never wants to use tether networks and only is interested in Wi-Fi connections, a lot of screen real estate is taken up for a feature that will never be used. Perhaps we should have a setting to hide this section in quick settings? Or Maybe we should have a way to minimize this section and make it smaller?
,
Aug 23 2017
It's true that you can always scroll past it, but the problem is that it's the first thing displayed in quick settings and takes up over half of the tray. IMO, users shouldn't have to scroll past something they will never use to make use of the rest of the tray. If the user truly does not want to use the feature (e.g., the user does not have a tethering mobile data plan), it seems like taking up half of the tray for this purpose would be annoying for that user. You're also right that adding a new UI element would probably create inconsistencies visually. Perhaps we could just go with a setting instead (users would see the quick settings section by default and it would only be hidden if users explicitly changed this in settings).
,
Aug 28 2017
We have decided to decrease the padding in the mobile data section, and created a section title is a 2 line title. Please refer to the updated spec for the change in QS.
,
Aug 28 2017
Thanks for the response. I think that your mocks look good, but unfortunately they are unrealistic because the height of the menu in your mocks is much higher than it would be on a real device. If we decrease the padding marginally as you did in your mocks, it would not make much of a difference since we're only squeezing things in by a few pixels. I've attached a screenshot on a real device so you can check out what it looks like currently. Even if we shave a few extra pixels off of the height of each row, we would still barely be able to see the top of the first Wi-Fi network in the list.
,
Aug 29 2017
kuscher@ suggested in an e-mail thread that we may want to show the "Mobile data" section below the Wi-Fi section when it is disabled. This would solve the issue at hand, but I'm not sure what the transition would be like when we switch it on and off? Clearly, we would not want to move the section up and down quick settings while quick settings is open, but moving it to the bottom the next time it is opened could also be a source of confusion for users.
,
Aug 29 2017
We either keep the setting above wifi or reorder and place it below. Moving it up and down based on it's status is not a great UX. We ran this idea by Jenn and she was on board with reducing padding.
,
Sep 11 2017
Just got clarification from jennschen@ on this issue. UX has decided that we should now "minimize" the quick settings section for Mobile data when there are no devices. Attached are mocks for what this should look like.
,
Sep 18 2017
Here is the spec for the padding for mobile apps. https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OSGhSVnRUSzQzU0E/view?usp=sharing
,
Sep 28 2017
,
Sep 29 2017
Hi Elizabeth - regarding the spec padding: what should be the dimensions of the space between the right side of the text and the left side of the toggle? Seems that measurement is missing. Also, what is the total width of the text? Thanks!
,
Sep 29 2017
You can find the updated spec here: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OSGhSVnRUSzQzU0E/view?usp=sharing
,
Oct 2 2017
,
Oct 2 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d523a93a787adcdadb670f45cd2ee3bab0490912 commit d523a93a787adcdadb670f45cd2ee3bab0490912 Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Oct 02 20:21:46 2017 [CrOS Tether] Minimize mobile data quick settings when empty. This change re-styles the "Mobile data" section of network quick settings so that when there are no networks shown in the section, it appears compressed. Without this change, the section takes up a lot of screen real estate, which can be annoying to users who do not plan on using mobile data networks. This CL also removes some obsolete code for being a delegate of TrayInfoLabel. Bug: 758323 , 672263 Change-Id: I144bf4b0f314270d8007fc924abfb465c93829dd Reviewed-on: https://chromium-review.googlesource.com/693322 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#505754} [modify] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/BUILD.gn [modify] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/network/network_list.cc [modify] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/network/network_list.h [add] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/network/network_row_title_view.cc [add] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/network/network_row_title_view.h [modify] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/tray/tray_info_label.cc [modify] https://crrev.com/d523a93a787adcdadb670f45cd2ee3bab0490912/ash/system/tray/tray_info_label.h
,
Oct 2 2017
Oops - this is targeted for M-63, not M-62. TPMs, please disregard the merge request :) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by elizabethchiu@chromium.org
, Aug 23 2017