New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758319 link

Starred by 2 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Mar 2018
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove attachments-related code from sync

Project Member Reported by pnoland@chromium.org, Aug 23 2017 
Attachments were a feature designed to support syncing large blobs of data associated with other sync entities. A fairly substantial amount of code was written to support storing, uploading, and downloading attachments. However, the two intended consumers of the feature(article sync and stars) were not launched and have no timeline to ever launch. 

We should remove attachments-related code from the codebase to shave binary size and reduce complexity in sync code that was modified to support attachments.

Comment 1 by pnoland@chromium.org, Jan 17 2018

Components: Services>Sync
Labels: SyncHandoff2018 SyncStarter2018
Owner: ----
Status: Available (was: Started)

Comment 2 by zea@chromium.org, Jan 17 2018

Labels: -SyncStarter2018 Hotlist-GoodFirstBug

Comment 3 by treib@chromium.org, Feb 1 2018

Owner: treib@chromium.org
Status: Started (was: Available)
I'll take a stab at this - I like deleting code :D

The code for "article sync" is still around in /media/treib/work/chromium/src/components/dom_distiller/core/article_attachments_data.h etc, I'm assuming this can also be deleted.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d

commit ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d
Author: Marc Treib <treib@chromium.org>
Date: Wed Feb 07 12:52:06 2018

Cleanup: Remove Article Attachments code from components/dom_distiller

This essentially reverts https://codereview.chromium.org/717793007. The
feature was abandoned, see  https://crbug.com/430552 .
This is in preparation for removing the Sync Attachments feature itself.

Bug:  758319 
Change-Id: I6894649f3cb52927776c1bc4efa3aac415069d21
Reviewed-on: https://chromium-review.googlesource.com/899003
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534987}
[modify] https://crrev.com/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d/components/dom_distiller/core/BUILD.gn
[delete] https://crrev.com/8d1c605a78d21df1b0c87dc7a7d14b319b3730c4/components/dom_distiller/core/article_attachments_data.cc
[delete] https://crrev.com/8d1c605a78d21df1b0c87dc7a7d14b319b3730c4/components/dom_distiller/core/article_attachments_data.h
[modify] https://crrev.com/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d/components/dom_distiller/core/article_entry.cc
[modify] https://crrev.com/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d/components/dom_distiller/core/dom_distiller_store.cc
[modify] https://crrev.com/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d/components/dom_distiller/core/dom_distiller_store.h
[modify] https://crrev.com/ef7ed225b3a0b5d4f0f77c837eb00537fa6d593d/components/dom_distiller/core/dom_distiller_store_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/476061989ab2a70acf80895c206fe8b41dbdf15a

commit 476061989ab2a70acf80895c206fe8b41dbdf15a
Author: Marc Treib <treib@chromium.org>
Date: Thu Feb 08 17:20:38 2018

Cleanup: Remove Sync Attachments code

Sync Attachments were never launched, and there are no plans to.
This CL removes all the code, but doesn't update any protos yet.

TBRing a bunch of mechanical, test-only changes.
TBR=jochen

Bug:  758319 
Change-Id: I3cff4d74293eead97deceedb1567b94ca799d05f
Reviewed-on: https://chromium-review.googlesource.com/899004
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535417}
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/chromeos/preferences_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/themes/theme_syncable_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/dom_distiller/core/dom_distiller_store_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/history/core/browser/history_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/history/core/browser/typed_url_syncable_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/BUILD.gn
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/fake_generic_change_processor.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/generic_change_processor.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/generic_change_processor.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/generic_change_processor_factory.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/generic_change_processor_factory.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/shared_change_processor.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/shared_change_processor_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/sync_api_component_factory.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/sync_api_component_factory_mock.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/driver/sync_api_component_factory_mock.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/DEPS
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_downloader.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_downloader.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_backend.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_backend.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_frontend.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_frontend.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_frontend_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_store_test_template.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_uploader.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_uploader.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_util.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/attachment_util.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_downloader.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_downloader.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_downloader_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_uploader.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_uploader.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/fake_attachment_uploader_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/in_memory_attachment_store.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/in_memory_attachment_store.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/in_memory_attachment_store_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/on_disk_attachment_store.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/on_disk_attachment_store.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine/attachments/on_disk_attachment_store_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/DEPS
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_downloader_impl.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_uploader_impl.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_uploader_impl.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/proto/BUILD.gn
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/engine_impl/attachments/proto/attachment_store.proto
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/commit_util.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/directory_commit_contribution_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/directory_update_handler_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/syncer_util.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/test_entry_factory.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/engine_impl/test_entry_factory.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/README
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_id.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_id.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_id_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_metadata.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_metadata.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_metadata_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service_proxy.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service_proxy.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service_proxy_for_test.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service_proxy_for_test.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_service_proxy_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_store.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_store.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model/attachments/attachment_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/fake_syncable_service.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/fake_syncable_service.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/sync_change_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/sync_data.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/sync_data.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/sync_data_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/syncable_service.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/model/syncable_service.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/DEPS
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/attachment_service_impl.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/attachment_service_impl.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/task_queue.h
[delete] https://crrev.com/9a0f72327d0be98c7d8360f4bfced1a427fd4f56/components/sync/model_impl/attachments/task_queue_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/base_node.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/base_node.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/directory.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/directory.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/directory_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/directory_unittest.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/model_neutral_mutable_entry.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/model_neutral_mutable_entry.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/mutable_entry.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/mutable_entry.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/read_transaction.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/read_transaction.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/write_node.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/write_node.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/write_transaction.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync/syncable/write_transaction.h
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync_preferences/pref_service_syncable_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync_sessions/lost_navigations_recorder_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync_sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/components/sync_wifi/wifi_credential_syncable_service_unittest.cc
[modify] https://crrev.com/476061989ab2a70acf80895c206fe8b41dbdf15a/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ca522c428ae0bb5898de27b9570b7a34bf98bc

commit 45ca522c428ae0bb5898de27b9570b7a34bf98bc
Author: Marc Treib <treib@chromium.org>
Date: Thu Feb 15 11:07:12 2018

Cleanup: Remove more Sync Attachments code

Followup to https://crrev.com/c/899004.
This removes a bunch of helper functions that I missed the first time
around, and deprecates the proto fields. attachments.proto itself is not
removed yet.

Bug:  758319 
Change-Id: Ie3eb5db0ce39c48e38ac1244f77c05a0515df714
Reviewed-on: https://chromium-review.googlesource.com/919081
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536986}
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/BUILD.gn
[delete] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/components/sync/base/attachment_id_proto.cc
[delete] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/components/sync/base/attachment_id_proto.h
[delete] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/components/sync/base/attachment_id_proto_unittest.cc
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/engine/engine_util.cc
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/engine/engine_util.h
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/article_specifics.proto
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/proto_value_conversions.h
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/proto_value_conversions_unittest.cc
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/45ca522c428ae0bb5898de27b9570b7a34bf98bc/components/sync/protocol/sync.proto
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/248ce84359e18e425f774147d1de4bbeac9ebe27

commit 248ce84359e18e425f774147d1de4bbeac9ebe27
Author: Marc Treib <treib@chromium.org>
Date: Tue Mar 06 12:26:03 2018

Cleanup: Remove Sync attachments.proto

Followup to https://crrev.com/c/899004 and https://crrev.com/c/919081.
This deletes the actual proto definitions, and a few more helper
functions that I missed before. The attachment metadata columns are not
removed from the directory DB yet; that's left for yet another followup.

Bug:  758319 
Change-Id: I3c3d1a52a2f1b55392019c21897f215672e47e6a
Reviewed-on: https://chromium-review.googlesource.com/941444
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541081}
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/engine_impl/conflict_resolver.cc
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/engine_impl/get_commit_ids.cc
[delete] https://crrev.com/360c12a3e5b56d5d93089f1ceac713b7c055d3c4/components/sync/protocol/attachments.proto
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/protocol/proto_memory_estimations.cc
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/protocol/protocol_sources.gni
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/directory_backing_store_unittest.cc
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/entry.h
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/entry_kernel.cc
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/entry_kernel.h
[modify] https://crrev.com/248ce84359e18e425f774147d1de4bbeac9ebe27/components/sync/syncable/syncable_enum_conversions.h
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4052e44458d650153daaaedebd48653d7d20c4de

commit 4052e44458d650153daaaedebd48653d7d20c4de
Author: Marc Treib <treib@chromium.org>
Date: Tue Mar 06 16:36:21 2018

Cleanup: Remove attachment metadata columns from DirectoryBackingStore

Followup to https://crrev.com/c/899004, https://crrev.com/c/919081,
and https://crrev.com/c/941444.
This CL removes the two attachment metadata columns from the
DirectoryBackingStore DB, bumps the version 92 and adds the
necessary migration code plus tests.

Bug:  758319 
Change-Id: Ibb461a33de326b986049de7058ef7fded5a6dac4
Reviewed-on: https://chromium-review.googlesource.com/943068
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541118}
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/directory_backing_store.h
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/directory_backing_store_unittest.cc
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/entry_kernel.cc
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/entry_kernel.h
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/syncable_enum_conversions.cc
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/syncable_enum_conversions.h
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/syncable/syncable_enum_conversions_unittest.cc
[modify] https://crrev.com/4052e44458d650153daaaedebd48653d7d20c4de/components/sync/test/test_directory_backing_store.h

Comment 9 by treib@chromium.org, Mar 6 2018

Status: Fixed (was: Started)
I think that's all!
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6907b8c1532ec198277a6090afa7b295b5132d4a

commit 6907b8c1532ec198277a6090afa7b295b5132d4a
Author: Marc Treib <treib@chromium.org>
Date: Fri Apr 20 09:58:54 2018

Mark Sync.Attachments.* histograms as obsolete

Sync attachments were never launched, and all the code (including
histogram recording) was removed recently.

Bug:  758319 
Change-Id: Idd68427d73b53b1d05f5a728230138404de5619e
Reviewed-on: https://chromium-review.googlesource.com/1019440
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552292}
[modify] https://crrev.com/6907b8c1532ec198277a6090afa7b295b5132d4a/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment