New issue
Advanced search Search tips

Issue 758314 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove shutdownSafeBrowsing method

Project Member Reported by ntfschr@chromium.org, Aug 23 2017 
After some discussion on http://ag/2743990 and conversation with the SafetyNet team, we decided that it doesn't make sense to expose shutdownSafeBrowsing in our public API.

A brief summary:

 * If we did expose shutdownSafeBrowsing(), when would apps call it? There's no signal for an application crash/death.
 * As we shift toward the connectionless API, the current thought is to intentionally never shutdown Safe Browsing (so the database will almost always be ready). shutdownSafeBrowsing API is counter intuitive to this.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28bb9fe7e2f0420d4043194fdfb56de5e39a809

commit a28bb9fe7e2f0420d4043194fdfb56de5e39a809
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed Aug 23 21:33:47 2017

AW: remove obsolete shutdownSafeBrowsing method

This removes the shutdownSafeBrowsing method, which we decided not to
expose in our public API.

Bug:  758314 
Test: ninja system_webview_google_apk
Change-Id: I021f41437163573a1896ba5218c416d178a9b99e
Reviewed-on: https://chromium-review.googlesource.com/629841
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496809}
[modify] https://crrev.com/a28bb9fe7e2f0420d4043194fdfb56de5e39a809/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/a28bb9fe7e2f0420d4043194fdfb56de5e39a809/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/3936d4fb2c261895040003fee2bfb353339df6b8

commit 3936d4fb2c261895040003fee2bfb353339df6b8
Author: Nate Fischer <ntfschr@google.com>
Date: Wed Aug 23 21:59:35 2017

Comment 3 by ntfschr@chromium.org, Aug 23 2017

Labels: SafeBrowsing-Triaged
Status: Fixed (was: Assigned)
No QA verification needed.

Comment 4 by ntfschr@chromium.org, Oct 11 2017

Labels: WebView-SafeBrowsing

Comment 5 by ntfschr@chromium.org, Aug 24

Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.
►

Sign in to add a comment