Remove au suite |
||||||||||||||||||||
Issue descriptionThe au suite is run on the canary & release builders and contains 3 tests: autoupdate_RollBack platform_Powerwash autoupdate_EndToEndTest_npo_delta The 3rd test *appears* to be an autoupdate from the build to the NPO (N Plus One) version of itself. During building, a control file for the test is generated and stored with the build artifacts on Google Storage. (See au_control.tar.bz2 in any gs://chromeos-image-archive build directory) Looking at the latest canary on samus we see that it applies this payload during the npo test run: gs://chromeos-image-archive/samus-release/R62-9871.0.0/chromeos_R62-9871.0.0_R62-9871.0.0_samus_delta_dev.bin This is an N to N (N2N) payload. During the paygen_au_* suite for the same build we apply the signed N2N payload in a different test run: gs://chromeos-releases/canary-channel/samus/9871.0.0/payloads/chromeos_9871.0.0-9871.0.0_samus_canary-channel_delta_test.bin-167fd51f1fba0eb4734ec1c48bb79c07 OK so its just one test duplicated what's the big deal? The builders have been failing the sanity phase on the builder very often. Todays M60 stable candidate was particularly bad (see the all the red in Build column https://cros-goldeneye.corp.google.com/chromeos/console/viewRelease?releaseName=M60-STABLE-CHROMEOS-3) When this happens the control file for the NPO test suite is not generated. (Full details of that problem in issue 709663 ) The au test suite will not run if this artifact is not there so we don't get a run of the powerwash and rollback tests. The test team then need to manually do spot checking of powerwash and rollback. This is happening very often lately. So my proposal is to move platform_Powerwash and autoupdate_Rollback to bvt-inline and not to generate the npo control files anymore. Then remove the au suite control file. Pros: 1. No more NPO naming to worry about 2. No more manual checking for test team 3. We will only have one 'autoupdate' test suite which avoids confusion Cons: 1. Two extra tests in bvt-inline Thoughts?
,
Aug 23 2017
Do any of the VM Test suites test basic updates? They used too. It seems weird to have an AU Suite that doesn't actually test the ability to update. That might cause confusion in future. But, "NPO" testing is duplicated against Paygen test suites, so removing it doesn't hurt test coverage, and reduces test load. My vote is to move forward with the proposed change.
,
Aug 23 2017
> It seems weird to have an AU Suite that doesn't actually test the ability to update. That might cause confusion in future. IIUC, the proposal boils down to "drop duplicated coverage of autoupdate_EndToEndTest_npo_delta and find a better home for the other two tests." I'm comfortable with dropping that AU test if we think Paygen covers it just as well. I think the tricky part will be the "better home for the other two tests." The reason for the trickiness is outlined in c#1. One option would be just to drop the one test, and rename the "au" suite to "bvt-<something>".
,
Aug 23 2017
I'm fine with that.
,
Sep 13 2017
,
Sep 14 2017
I've added a comment to the initial chromite CL, but I want to
add a similar comment here. c#3 suggests renaming the 'au' suite
in addition to deleting the EndToEndTest from the suite. Based on
looking at the initial CL, ITOT those two things are (essentially)
the same operation. It also turns out that there potentially less
risk doing it that way. That implies a long(ish) sequence of CLs:
A. (autotest) Create the new suite.
B. (autotest) Add the Powerwash and Rollback tests to the new suite.
C. (chromite) Change the HWTest config to drop the 'au' suite in
favor of the new suite.
D. (autotest) Remove the 'au' suite.
E. (chromite) Remove (now dead) references to the AU suite, and all
the customized code built around it.
Risk to the builds is reduced because only at step C. should there
be significant risk of anything breaking, and that step will be a
small change, easily reverted without risk.
Note that the only reason not to follow the plan above would be if
we declare that the 'au' suite should not be renamed: The plan
above is the safest, most efficient option that both cleans up the
suite contents _and_ renames the suite.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/729ca887199523d0c0d6dbd8c94d25850124874c commit 729ca887199523d0c0d6dbd8c94d25850124874c Author: David Haddock <dhaddock@chromium.org> Date: Fri Sep 15 07:24:02 2017 [chromite] Remove the AUTestStage from builders. We want to stop generating npo control files during AUTest stage. Generating N to N+1 (npo) control file is not necessary as we already have sufficient coverage with N to N test as part of the paygen_au* suites. So we don't need this stage and its assoicated code. BUG= chromium:764038 BUG= chromium:758307 TEST=Not sure how best to test this change CQ-DEPEND=CL:665366 Change-Id: Iadc9904c4e81770896cf02756f0025f87f5b5eb0 Reviewed-on: https://chromium-review.googlesource.com/665170 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/729ca887199523d0c0d6dbd8c94d25850124874c/cbuildbot/stages/test_stages.py [modify] https://crrev.com/729ca887199523d0c0d6dbd8c94d25850124874c/cbuildbot/commands_unittest.py [modify] https://crrev.com/729ca887199523d0c0d6dbd8c94d25850124874c/cbuildbot/stages/test_stages_unittest.py [modify] https://crrev.com/729ca887199523d0c0d6dbd8c94d25850124874c/cbuildbot/commands.py [modify] https://crrev.com/729ca887199523d0c0d6dbd8c94d25850124874c/cbuildbot/builders/simple_builders.py
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485 commit 8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485 Author: David Haddock <dhaddock@chromium.org> Date: Fri Sep 15 07:24:02 2017 Remove staging of control files for au suite. We no longer need to stage control files as part of the au suite. The npo test case that this test suite controls is covered as part of the N2N tests in paygen_au* suites. This change will remove a lot of manual work required by the test team to run powerwash tests manually when the sanity stage on the builder fails and the control file is not generated. BUG= chromium:758307 BUG= chromium:764038 BUG= chromium:709663 TEST=None Change-Id: I88a9bf7266c5615deb221d4adb50e5fbf4977d25 Reviewed-on: https://chromium-review.googlesource.com/665366 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485/test_suites/control.au
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4366f7cce5bd1220e13c266a02c9802e0e687266 commit 4366f7cce5bd1220e13c266a02c9802e0e687266 Author: David Haddock <dhaddock@chromium.org> Date: Fri Sep 15 23:09:09 2017 [chromite] Remove the AUTestStage from builders. We want to stop generating npo control files during AUTest stage. Generating N to N+1 (npo) control file is not necessary as we already have sufficient coverage with N to N test as part of the paygen_au* suites. So we don't need this stage and its assoicated code. BUG= chromium:764038 BUG= chromium:758307 TEST=Not sure how best to test this change CQ-DEPEND=CL:665366 Change-Id: Iadc9904c4e81770896cf02756f0025f87f5b5eb0 Reviewed-on: https://chromium-review.googlesource.com/665170 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> (cherry picked from commit 729ca887199523d0c0d6dbd8c94d25850124874c) Reviewed-on: https://chromium-review.googlesource.com/669701 Reviewed-by: David Haddock <dhaddock@chromium.org> Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/4366f7cce5bd1220e13c266a02c9802e0e687266/cbuildbot/stages/test_stages.py [modify] https://crrev.com/4366f7cce5bd1220e13c266a02c9802e0e687266/cbuildbot/commands_unittest.py [modify] https://crrev.com/4366f7cce5bd1220e13c266a02c9802e0e687266/cbuildbot/stages/test_stages_unittest.py [modify] https://crrev.com/4366f7cce5bd1220e13c266a02c9802e0e687266/cbuildbot/commands.py [modify] https://crrev.com/4366f7cce5bd1220e13c266a02c9802e0e687266/cbuildbot/builders/simple_builders.py
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/24874293ea89dcce5af71f7d5da74d483e4f4dc4 commit 24874293ea89dcce5af71f7d5da74d483e4f4dc4 Author: David Haddock <dhaddock@chromium.org> Date: Fri Sep 15 23:09:34 2017 Remove staging of control files for au suite. We no longer need to stage control files as part of the au suite. The npo test case that this test suite controls is covered as part of the N2N tests in paygen_au* suites. This change will remove a lot of manual work required by the test team to run powerwash tests manually when the sanity stage on the builder fails and the control file is not generated. BUG= chromium:758307 BUG= chromium:764038 BUG= chromium:709663 TEST=None Change-Id: I88a9bf7266c5615deb221d4adb50e5fbf4977d25 Reviewed-on: https://chromium-review.googlesource.com/665366 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> (cherry picked from commit 8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485) Reviewed-on: https://chromium-review.googlesource.com/669901 Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/24874293ea89dcce5af71f7d5da74d483e4f4dc4/test_suites/control.au
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8028677de916a3172a53611e3e57c74f183637c8 commit 8028677de916a3172a53611e3e57c74f183637c8 Author: David Haddock <dhaddock@chromium.org> Date: Mon Sep 18 18:27:01 2017 [chromite] Remove the AUTestStage from builders. We want to stop generating npo control files during AUTest stage. Generating N to N+1 (npo) control file is not necessary as we already have sufficient coverage with N to N test as part of the paygen_au* suites. So we don't need this stage and its assoicated code. BUG= chromium:764038 BUG= chromium:758307 TEST=Not sure how best to test this change CQ-DEPEND=CL:665366 Change-Id: Iadc9904c4e81770896cf02756f0025f87f5b5eb0 Reviewed-on: https://chromium-review.googlesource.com/665170 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/671455 Reviewed-by: David Haddock <dhaddock@chromium.org> Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/8028677de916a3172a53611e3e57c74f183637c8/cbuildbot/stages/test_stages.py [modify] https://crrev.com/8028677de916a3172a53611e3e57c74f183637c8/cbuildbot/commands_unittest.py [modify] https://crrev.com/8028677de916a3172a53611e3e57c74f183637c8/cbuildbot/stages/test_stages_unittest.py [modify] https://crrev.com/8028677de916a3172a53611e3e57c74f183637c8/cbuildbot/commands.py [modify] https://crrev.com/8028677de916a3172a53611e3e57c74f183637c8/cbuildbot/builders/simple_builders.py
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eb06fa4395f1cf3bd8d3b930308d8f977a7bdd9a commit eb06fa4395f1cf3bd8d3b930308d8f977a7bdd9a Author: David Haddock <dhaddock@chromium.org> Date: Mon Sep 18 18:27:41 2017 Remove staging of control files for au suite. We no longer need to stage control files as part of the au suite. The npo test case that this test suite controls is covered as part of the N2N tests in paygen_au* suites. This change will remove a lot of manual work required by the test team to run powerwash tests manually when the sanity stage on the builder fails and the control file is not generated. BUG= chromium:758307 BUG= chromium:764038 BUG= chromium:709663 TEST=None Change-Id: I88a9bf7266c5615deb221d4adb50e5fbf4977d25 Reviewed-on: https://chromium-review.googlesource.com/665366 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> (cherry picked from commit 8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485) Reviewed-on: https://chromium-review.googlesource.com/671186 Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/eb06fa4395f1cf3bd8d3b930308d8f977a7bdd9a/test_suites/control.au
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/78a645b0df7702f8b82ffca216b6cffda17cf1ea commit 78a645b0df7702f8b82ffca216b6cffda17cf1ea Author: David Haddock <dhaddock@chromium.org> Date: Tue Sep 19 01:37:57 2017 [chromite] Remove the AUTestStage from builders. We want to stop generating npo control files during AUTest stage. Generating N to N+1 (npo) control file is not necessary as we already have sufficient coverage with N to N test as part of the paygen_au* suites. So we don't need this stage and its assoicated code. BUG= chromium:764038 BUG= chromium:758307 TEST=Not sure how best to test this change CQ-DEPEND=CL:665366 Change-Id: Iadc9904c4e81770896cf02756f0025f87f5b5eb0 Reviewed-on: https://chromium-review.googlesource.com/665170 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/671685 Reviewed-by: David Haddock <dhaddock@chromium.org> Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/78a645b0df7702f8b82ffca216b6cffda17cf1ea/cbuildbot/stages/test_stages.py [modify] https://crrev.com/78a645b0df7702f8b82ffca216b6cffda17cf1ea/cbuildbot/commands_unittest.py [modify] https://crrev.com/78a645b0df7702f8b82ffca216b6cffda17cf1ea/cbuildbot/stages/test_stages_unittest.py [modify] https://crrev.com/78a645b0df7702f8b82ffca216b6cffda17cf1ea/cbuildbot/commands.py [modify] https://crrev.com/78a645b0df7702f8b82ffca216b6cffda17cf1ea/cbuildbot/builders/simple_builders.py
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cc274348acbbad5bde4480bca36fca6ea8c77981 commit cc274348acbbad5bde4480bca36fca6ea8c77981 Author: David Haddock <dhaddock@chromium.org> Date: Tue Sep 19 01:38:10 2017 Remove staging of control files for au suite. We no longer need to stage control files as part of the au suite. The npo test case that this test suite controls is covered as part of the N2N tests in paygen_au* suites. This change will remove a lot of manual work required by the test team to run powerwash tests manually when the sanity stage on the builder fails and the control file is not generated. BUG= chromium:758307 BUG= chromium:764038 BUG= chromium:709663 TEST=None Change-Id: I88a9bf7266c5615deb221d4adb50e5fbf4977d25 Reviewed-on: https://chromium-review.googlesource.com/665366 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> (cherry picked from commit 8f9b1e6bfd3bda3fc922034cbd2f3c89ba7bc485) Reviewed-on: https://chromium-review.googlesource.com/671153 Trybot-Ready: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/cc274348acbbad5bde4480bca36fca6ea8c77981/test_suites/control.au
,
Sep 25 2017
sorry in advance for the badly formed paste below. I'm seeing this on staging master, and I wonder if it might happening in other places: [chromeos-staging-master2.hot.corp.google.com] out: Suite job FAIL: 500 Internal Server Error #powered_by { margin-top: 20px; border-top: 2px solid black; font-style: italic; } #traceback { color: red; } 500 Internal Server Error The server encountered an unexpected condition which prevented it from fulfilling the request. Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/cherrypy/_cprequest.py", line 656, in respond response.body = self.handler() File "/usr/lib/python2.7/dist-packages/cherrypy/lib/encoding.py", line 188, in __call__ self.body = self.oldhandler(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/cherrypy/_cpdispatch.py", line 34, in __call__ return self.callable(*self.args, **self.kwargs) File "/usr/local/google/home/chromeos-test/chromiumos/src/platform/dev/devserver.py", line 795, in is_staged response = str(dl.IsStaged(factory)) File "/usr/local/google/home/chromeos-test/chromiumos/src/platform/dev/downloader.py", line 216, in IsStaged raise DownloaderException(exceptions) DownloaderException: Could not find au_control.tar.bz2 in Google Storage at gs://chromeos-image-archive/gandof-release/R61-9765.70.0 Traceback (most recent call last): File "/usr/local/google/home/chromeos-test/chromiumos/src/platform/dev/build_artifact.py", line 337, in Process self.name, self.is_regex_name, timeout) File "/usr/local/google/home/chromeos-test/chromiumos/src/platform/dev/downloader.py", line 336, in Wait (name, self._archive_url)) ArtifactDownloadError: Could not find au_control.tar.bz2 in Google Storage at gs://chromeos-image-archive/gandof-release/R61-9765.70.0 Powered by CherryPy 3.2.2
,
Sep 25 2017
Is staging test erroneously still requesting for this artifact to be staged, when it no longer exists?
,
Sep 25 2017
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/142-chromeos-test/hostless/debug/ 09/25 15:53:38.920 INFO | dev_server:1125| Staging artifacts on devserver http://100.108.133.197:8082: build=gandof-release/R61-9765.70.0, artifacts=['au_suite'], files=, archive_url=gs://chromeos-image-archive/gandof-release/R61-9765.70.0 09/25 15:53:39.001 DEBUG| dev_server:1067| response for RPC: 'Success' 09/25 15:53:39.076 DEBUG| dev_server:1023| whether artifact is staged: 'False' 09/25 15:53:44.155 DEBUG| dev_server:0300| RPC call call_and_wait has timed out on devserver 100.108.133.197. 09/25 15:53:44.156 DEBUG| dev_server:0300| RPC call stage_artifacts has timed out on devserver 100.108.133.197. 09/25 15:53:44.156 ERROR| server_job:0864| Exception escaped control file, job aborting: Traceback (most recent call last): File "/usr/local/autotest/server/server_job.py", line 856, in run self._execute_code(server_control_file, namespace) File "/usr/local/autotest/server/server_job.py", line 1357, in _execute_code execfile(code_file, namespace, namespace) File "/usr/local/autotest/results/142-chromeos-test/hostless/control.srv", line 67, in <module> ds.stage_artifacts(build, artifacts=['au_suite']) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 290, in metrics_wrapper return wrapper() File "/usr/local/autotest/client/common_lib/cros/retry.py", line 218, in func_retry remaining_time) File "/usr/local/autotest/client/common_lib/cros/retry.py", line 123, in timeout default_result = func(*args, **kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 284, in wrapper return method(*args, **kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1448, in stage_artifacts self._stage_artifacts(image, artifacts, files, archive_url) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1142, in _stage_artifacts **arguments) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 290, in metrics_wrapper return wrapper() File "/usr/local/autotest/client/common_lib/cros/retry.py", line 218, in func_retry remaining_time) File "/usr/local/autotest/client/common_lib/cros/retry.py", line 123, in timeout default_result = func(*args, **kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 284, in wrapper return method(*args, **kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1421, in call_and_wait expected_response, **kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1087, in _call_and_wait self.wait_for_artifacts_staged(**kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1394, in wait_for_artifacts_staged return self._poll_is_staged(**kwargs) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1042, in _poll_is_staged sleep_interval=_ARTIFACT_STAGE_POLLING_INTERVAL) File "/usr/local/autotest/client/common_lib/utils.py", line 2733, in poll_for_condition value = condition() File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 1027, in all_staged raise DevServerException(_strip_http_message(error_markup)) My hypothesis is staging test is still trying to run an obsolete test.
,
Sep 25 2017
,
Sep 25 2017
,
Sep 25 2017
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8784ea7cc39a9890690c126fcdc9dc000bbceeff commit 8784ea7cc39a9890690c126fcdc9dc000bbceeff Author: Aviv Keshet <akeshet@chromium.org> Date: Mon Sep 25 23:17:33 2017 autotest: stop trying to stage au_control in staging test BUG= chromium:758307 TEST=None Change-Id: I8ea6f7958dc12c9b4493a7f5cf93aa88d59bef46 Reviewed-on: https://chromium-review.googlesource.com/683294 Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/8784ea7cc39a9890690c126fcdc9dc000bbceeff/test_suites/control.push_to_prod
,
Sep 25 2017
Cherry-picks to 62, 61, 60: https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/683302 https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/683303 https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/683304 Can I get expedited merge approval to branches? This should be no-op from all production relevant purposes, this suite is only used by the staging lab.
,
Sep 26 2017
Approving merge to M61.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ce4838b97e7f8b66e1800487983dafa92d9fc60b commit ce4838b97e7f8b66e1800487983dafa92d9fc60b Author: Aviv Keshet <akeshet@chromium.org> Date: Tue Sep 26 00:07:19 2017 autotest: stop trying to stage au_control in staging test BUG= chromium:758307 TEST=None Change-Id: I8ea6f7958dc12c9b4493a7f5cf93aa88d59bef46 Previous-Reviewed-on: https://chromium-review.googlesource.com/683294 (cherry picked from commit 52ad5d42e2046f12c5b46bba4914b0c9bde16e41) Reviewed-on: https://chromium-review.googlesource.com/683303 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/ce4838b97e7f8b66e1800487983dafa92d9fc60b/test_suites/control.push_to_prod
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5d0e0ed713cd34ea4c29eeeaef9d55fd45efe65a commit 5d0e0ed713cd34ea4c29eeeaef9d55fd45efe65a Author: Aviv Keshet <akeshet@chromium.org> Date: Tue Sep 26 02:24:49 2017 autotest: stop trying to stage au_control in staging test BUG= chromium:758307 TEST=None Change-Id: I8ea6f7958dc12c9b4493a7f5cf93aa88d59bef46 Previous-Reviewed-on: https://chromium-review.googlesource.com/683294 (cherry picked from commit 1892aa70f1236d8726e185f3f8776d13171e887f) Reviewed-on: https://chromium-review.googlesource.com/683302 Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/5d0e0ed713cd34ea4c29eeeaef9d55fd45efe65a/test_suites/control.push_to_prod
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a730c52b00fb71451517d015de50d3833d2ef513 commit a730c52b00fb71451517d015de50d3833d2ef513 Author: Aviv Keshet <akeshet@chromium.org> Date: Tue Sep 26 02:24:54 2017 autotest: stop trying to stage au_control in staging test BUG= chromium:758307 TEST=None Change-Id: I8ea6f7958dc12c9b4493a7f5cf93aa88d59bef46 Previous-Reviewed-on: https://chromium-review.googlesource.com/683294 (cherry picked from commit 8a1e8b5ba0a470ec1200f44355cd7215cdaf028b) Reviewed-on: https://chromium-review.googlesource.com/683304 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/a730c52b00fb71451517d015de50d3833d2ef513/test_suites/control.push_to_prod
,
Sep 26 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5911031d335c7578cb8930db3c65525a3a4eed28 commit 5911031d335c7578cb8930db3c65525a3a4eed28 Author: David Haddock <dhaddock@chromium.org> Date: Thu Sep 28 04:12:57 2017 [autotest] Create bvt-installer suite. This suite will replace the au suite that is being removed. This CL creates the new suite and adds the 2 tests to it. BUG= chromium:758307 TEST=None Change-Id: Iecd798ab1a1ab3836a36ee9a4f955c92e259d58a Reviewed-on: https://chromium-review.googlesource.com/676470 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/5911031d335c7578cb8930db3c65525a3a4eed28/site_utils/attribute_whitelist.txt [modify] https://crrev.com/5911031d335c7578cb8930db3c65525a3a4eed28/server/site_tests/autoupdate_Rollback/control [add] https://crrev.com/5911031d335c7578cb8930db3c65525a3a4eed28/test_suites/control.bvt-installer [modify] https://crrev.com/5911031d335c7578cb8930db3c65525a3a4eed28/server/site_tests/platform_Powerwash/control
,
Sep 28 2017
,
Sep 29 2017
I'm done any push-to-prod related fixes here.
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6db0112653e21c396177cc6b4fcdc0a20c78cdcd commit 6db0112653e21c396177cc6b4fcdc0a20c78cdcd Author: David Haddock <dhaddock@chromium.org> Date: Thu Oct 05 01:47:08 2017 [chromite] Replace au suite with bvt-installer. Gets the bvt-installer suite in place of the au suite. Also removes a workaround for an old bug now that the AUTestStage is removed from the builder. BUG= chromium:758307 TEST=None Change-Id: I47b5fc999039a9aaf50f94191eb510dc2f54d365 Reviewed-on: https://chromium-review.googlesource.com/675600 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/6db0112653e21c396177cc6b4fcdc0a20c78cdcd/cbuildbot/config_dump.json [modify] https://crrev.com/6db0112653e21c396177cc6b4fcdc0a20c78cdcd/lib/constants.py [modify] https://crrev.com/6db0112653e21c396177cc6b4fcdc0a20c78cdcd/cbuildbot/chromeos_config.py
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/979e61bf93b091725c6c6e117ab1e6160773cc8e commit 979e61bf93b091725c6c6e117ab1e6160773cc8e Author: David Haddock <dhaddock@chromium.org> Date: Fri Oct 06 22:51:11 2017 [autotest] Delete the 'au' suite. And remove it from the tests control files. And remove it from attribute_whitelist.txt. BUG= chromium:758307 TEST=None Change-Id: Ibdda3bd9552a2c8eb5d90e6258cb7f4554f03cab Reviewed-on: https://chromium-review.googlesource.com/676471 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> [delete] https://crrev.com/71ffc43890100b94cac82da093265e7f815c191d/test_suites/control.au [modify] https://crrev.com/979e61bf93b091725c6c6e117ab1e6160773cc8e/site_utils/attribute_whitelist.txt [modify] https://crrev.com/979e61bf93b091725c6c6e117ab1e6160773cc8e/server/site_tests/autoupdate_Rollback/control [modify] https://crrev.com/979e61bf93b091725c6c6e117ab1e6160773cc8e/server/site_tests/platform_Powerwash/control
,
Oct 10 2017
Requesting merge of the last 3 CLs to 62 and 61. They will be reflected in the columns in GoldenEye.
,
Oct 10 2017
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10 2017
,
Oct 11 2017
Approved for 62.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2948443ef19f9b5d1900749daf49a28e336f60c6 commit 2948443ef19f9b5d1900749daf49a28e336f60c6 Author: David Haddock <dhaddock@chromium.org> Date: Wed Oct 11 19:12:50 2017 [autotest] Create bvt-installer suite. This suite will replace the au suite that is being removed. This CL creates the new suite and adds the 2 tests to it. BUG= chromium:758307 TEST=None Change-Id: Iecd798ab1a1ab3836a36ee9a4f955c92e259d58a Reviewed-on: https://chromium-review.googlesource.com/676470 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> (cherry picked from commit 5911031d335c7578cb8930db3c65525a3a4eed28) Reviewed-on: https://chromium-review.googlesource.com/713402 Reviewed-by: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/2948443ef19f9b5d1900749daf49a28e336f60c6/site_utils/attribute_whitelist.txt [modify] https://crrev.com/2948443ef19f9b5d1900749daf49a28e336f60c6/server/site_tests/autoupdate_Rollback/control [add] https://crrev.com/2948443ef19f9b5d1900749daf49a28e336f60c6/test_suites/control.bvt-installer [modify] https://crrev.com/2948443ef19f9b5d1900749daf49a28e336f60c6/server/site_tests/platform_Powerwash/control
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/65a1016a1c98b2d40091e6e9629c52380b3ad1a3 commit 65a1016a1c98b2d40091e6e9629c52380b3ad1a3 Author: David Haddock <dhaddock@chromium.org> Date: Wed Oct 11 20:03:17 2017 [chromite] Replace au suite with bvt-installer. Gets the bvt-installer suite in place of the au suite. Also removes a workaround for an old bug now that the AUTestStage is removed from the builder. BUG= chromium:758307 TEST=None Change-Id: I47b5fc999039a9aaf50f94191eb510dc2f54d365 Reviewed-on: https://chromium-review.googlesource.com/675600 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> Reviewed-on: https://chromium-review.googlesource.com/713663 Reviewed-by: David Haddock <dhaddock@chromium.org> [modify] https://crrev.com/65a1016a1c98b2d40091e6e9629c52380b3ad1a3/cbuildbot/config_dump.json [modify] https://crrev.com/65a1016a1c98b2d40091e6e9629c52380b3ad1a3/lib/constants.py [modify] https://crrev.com/65a1016a1c98b2d40091e6e9629c52380b3ad1a3/cbuildbot/chromeos_config.py
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ee7eec929dadb6c9f39e46334aae2bd4119d6428 commit ee7eec929dadb6c9f39e46334aae2bd4119d6428 Author: David Haddock <dhaddock@chromium.org> Date: Wed Oct 11 20:03:51 2017 [autotest] Delete the 'au' suite. And remove it from the tests control files. And remove it from attribute_whitelist.txt. BUG= chromium:758307 TEST=None Change-Id: Ibdda3bd9552a2c8eb5d90e6258cb7f4554f03cab Reviewed-on: https://chromium-review.googlesource.com/676471 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> (cherry picked from commit 979e61bf93b091725c6c6e117ab1e6160773cc8e) Reviewed-on: https://chromium-review.googlesource.com/713403 [delete] https://crrev.com/2948443ef19f9b5d1900749daf49a28e336f60c6/test_suites/control.au [modify] https://crrev.com/ee7eec929dadb6c9f39e46334aae2bd4119d6428/site_utils/attribute_whitelist.txt [modify] https://crrev.com/ee7eec929dadb6c9f39e46334aae2bd4119d6428/server/site_tests/autoupdate_Rollback/control [modify] https://crrev.com/ee7eec929dadb6c9f39e46334aae2bd4119d6428/server/site_tests/platform_Powerwash/control
,
Oct 12 2017
Merged to 62 and working. Ketaki can you approve for 61?
,
Oct 16 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16 2017
We are at the last 61 stable. I wont merge this back to 61
,
Oct 20 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
|
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by jrbarnette@chromium.org
, Aug 23 2017