New issue
Advanced search Search tips

Issue 758304 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Transparency broken on "arrow" windows

Project Member Reported by thomasanderson@chromium.org, Aug 23 2017

Issue description

Chrome Version: ToT
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Drag a link to the tabstrip

The arrow indicating where the tab will be created should have transparency, but does not.
 
Here's what it looks like.  the arrow shouldn't have a black background
Screenshot from 2017-08-23 11-22-51.png
6.2 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8bc9f0e7a14c70037b9b7245812674652f5971

commit cd8bc9f0e7a14c70037b9b7245812674652f5971
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 23 19:47:21 2017

X11: Fix transparency on certain windows

Transparency on arrow windows stopped working after CL [1].  This CL
is a one-line selective revert of that CL.  Note that transparency on
all other windows that I've tested (drag images, dragged URLs, etc)
were not broken.

[1] https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43

BUG= 758304 
R=erg@chromium.org

Change-Id: I37020d930bd081facce65b0a8be0eeb2e1756c69
Reviewed-on: https://chromium-review.googlesource.com/629538
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496775}
[modify] https://crrev.com/cd8bc9f0e7a14c70037b9b7245812674652f5971/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)
Cc: pnangunoori@chromium.org
Labels: TE-Verified-62.0.3196.0 TE-Verified-M62
Tested the issue on Ubuntu 14.04 using Chrome Canary version M62 - 62.0.3196.0 as per the issue mentioned in original comment. Observed that issue is working as intended (When links are dragged an arrow is indicated where a tab will be created). Hence adding TE-Verified label. Attached the screencast for reference.

Thank you!
758304.mp4
4.2 MB View Download
Status: Started (was: Fixed)
Revert in progress, so reopening
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d9fac7f02ebc1b72988c46b5836af2fc03fd75

commit a0d9fac7f02ebc1b72988c46b5836af2fc03fd75
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Sep 01 04:58:42 2017

Revert "X11: Fix transparency on certain windows"

This reverts commit cd8bc9f0e7a14c70037b9b7245812674652f5971.

Reason for revert: Breaks thestig@'s theme.  Also, ShouldWindowContentsBeTransparent() should only return true on the Windows Aero theme

Original change's description:
> X11: Fix transparency on certain windows
> 
> Transparency on arrow windows stopped working after CL [1].  This CL
> is a one-line selective revert of that CL.  Note that transparency on
> all other windows that I've tested (drag images, dragged URLs, etc)
> were not broken.
> 
> [1] https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43
> 
> BUG= 758304 
> R=​erg@chromium.org
> 
> Change-Id: I37020d930bd081facce65b0a8be0eeb2e1756c69
> Reviewed-on: https://chromium-review.googlesource.com/629538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Elliot Glaysher <erg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496775}

TBR=erg@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  758304 
Change-Id: I5fa80e041c77d485afa08dea99d893f84474c458
Reviewed-on: https://chromium-review.googlesource.com/647032
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499131}
[modify] https://crrev.com/a0d9fac7f02ebc1b72988c46b5836af2fc03fd75/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee05ae5f136ea85445eb7562899906ca33ada368

commit ee05ae5f136ea85445eb7562899906ca33ada368
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Sep 01 17:55:46 2017

[Merge to M62] Revert "X11: Fix transparency on certain windows"

> This reverts commit cd8bc9f0e7a14c70037b9b7245812674652f5971.
>
> Reason for revert: Breaks thestig@'s theme.  Also, ShouldWindowContentsBeTransparent() should only return true on the Windows Aero theme
>
> Original change's description:
> > X11: Fix transparency on certain windows
> >
> > Transparency on arrow windows stopped working after CL [1].  This CL
> > is a one-line selective revert of that CL.  Note that transparency on
> > all other windows that I've tested (drag images, dragged URLs, etc)
> > were not broken.
> >
> > [1] https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43
> >
> > BUG= 758304 
> > R=​erg@chromium.org
> >
> > Change-Id: I37020d930bd081facce65b0a8be0eeb2e1756c69
> > Reviewed-on: https://chromium-review.googlesource.com/629538
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Elliot Glaysher <erg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#496775}
>
> TBR=erg@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug:  758304 
> Change-Id: I5fa80e041c77d485afa08dea99d893f84474c458
> Reviewed-on: https://chromium-review.googlesource.com/647032
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#499131}
>

BUG= 758304 
TBR=erg@chromium.org
CC=thestig@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I5e69899078d27d1b24b95ee2d02a84a8db6270ee
Reviewed-on: https://chromium-review.googlesource.com/648089
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#6}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/ee05ae5f136ea85445eb7562899906ca33ada368/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Labels: -TE-Verified-M62 -TE-Verified-62.0.3196.0 -merge-merged-3202
Removing labels that no longer apply to this bug in its current state.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b4617ad9677d48db215e211198b23135b46fa4a

commit 6b4617ad9677d48db215e211198b23135b46fa4a
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Oct 30 19:33:45 2017

X11: Fix transparency on certain windows

This is a correction to the (reverted) CL [1], which returned true from
ShouldWindowContentsBeTransparent() whenever transparent visuals were
supported.  This broke tabstrip colors when using certain browser
themes because TabStrip uses that function to decide if Aero Glass is
enabled, and makes parts of the tabstrip partially translucent.

This CL relaxes that function to only return true when the window
itself is translucent.

[1] https://chromium.googlesource.com/chromium/src/+/cd8bc9f0e7a14c70037b9b7245812674652f5971

BUG= 758304 
R=erg@chromium.org
CC=​thestig@chromium.org

Change-Id: I57ea2421d19d0cf7d1b76f131cb3e79461c096b9
Reviewed-on: https://chromium-review.googlesource.com/742448
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512579}
[modify] https://crrev.com/6b4617ad9677d48db215e211198b23135b46fa4a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M64 TE-Verified-64.0.3254.0
Tested the issue on Ubuntu 14.04 using Chrome Canary version M64 - 64.0.3254.0 as per the issue mentioned in original comment. Observed that issue is working as intended (When links are dragged towards tab strip an arrow is indicated with no black background. Also verified on Glass Aero theme, where arrow is displayed without any background). Hence adding TE-Verified labels. Attached the screencast for reference.

Thank you!
758304.mp4
3.2 MB View Download
758304-AeroGlassTheme.mp4
2.6 MB View Download

Sign in to add a comment