TCP_INFO not implemented on Fuchsia, TCP RTT estimation doesn't work |
||
Issue descriptionTcpSocketPosix on MacOS and Linux uses getsockopt(TCP_INFO) to get RTT estimate from the TCP stack. It's not implemented on Fuchsia, so I see the following message from netstack: [00010.500] 02411.04074> netstack: convSockOpt: TODO SOL_TCP optname=11 This feature is used only by NetworkQualityEstimator. It's not implemented on Windows. Will disable this feature on Fuchsia, until we get TCP_INFO implemented.
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39fc78b8f739490b9fe39c5457cc0dc93d0b08a7 commit 39fc78b8f739490b9fe39c5457cc0dc93d0b08a7 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Aug 24 01:26:21 2017 Don't use TCP_INFO on Fuchsia TCP_INFO is used in TCPSocket to get RTT estimates from TCP stack. It's currently not implemented on Fuchsia, but TCP_INFO is defined. Updated TCPSocketPosix to avoid calling getsockopt(TCP_INFO) needlessly. Bug: 758294 Change-Id: Iac8a13199e39a34663542bb36e18cfddef5ac9a2 Reviewed-on: https://chromium-review.googlesource.com/628399 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#496908} [modify] https://crrev.com/39fc78b8f739490b9fe39c5457cc0dc93d0b08a7/net/socket/tcp_socket_posix.cc
,
Aug 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sergeyu@chromium.org
, Aug 23 2017