Determine policy for filtering WebView experiments by channel |
||||
Issue descriptionIn Chrome, experiments are filtered based on the current channel that is running. In WebView this granularity is not always available to us, Monochrome can provide the channel, while stand-alone WebView can not. To correctly filter experiments we must determine which channel to report here: https://cs.chromium.org/chromium/src/android_webview/browser/aw_variations_service_client.cc?l=50
,
Aug 23 2017
,
Sep 27 2017
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/638bba2aa798f39cf9d803c33d569eaf9a484f0d commit 638bba2aa798f39cf9d803c33d569eaf9a484f0d Author: Paul Miller <paulmiller@google.com> Date: Thu May 03 17:51:33 2018 WebView: Pass channel to variations Since b66db7c43366e0dec86670ab698a7d116ae73075, WebView can now get the channel. Variations uses this to filter experiments. Stand-alone WebView will report "unknown" channel. Experiments which do not specify any channel will apply to stand-alone WebView; see CheckStudyChannel in study_filtering.cc. BUG= 758290 Change-Id: I6174b63c6995cb950e5ec349891ad579d24e7396 Reviewed-on: https://chromium-review.googlesource.com/1041206 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555802} [modify] https://crrev.com/638bba2aa798f39cf9d803c33d569eaf9a484f0d/android_webview/browser/aw_variations_service_client.cc
,
May 3 2018
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7542b65f226fb53db53bfc89dbb5beee6da79a0 commit f7542b65f226fb53db53bfc89dbb5beee6da79a0 Author: Paul Miller <paulmiller@google.com> Date: Thu Aug 23 23:52:24 2018 Rename android_webview::GetChannel Commit 0c0fc42d9f2905a615bf865c2da1e7a1a257f603 moved AwVariationsServiceClient's "channel == unknown ? stable : channel" logic into a new android_webview::GetChannel. But this is confusing because the new GetChannel retains the variations-specific comment, and the name "android_webview::GetChannel" might sound like all of WebView should be using this sanitized channel, when UMA still needs the un-sanitized channel. Move the variations-specific comment back into AwVariationsServiceClient and rename GetChannel to GetChannelOrStable. BUG= 758290 Change-Id: I4590aa22b73424e14e47444c3fdf3abc151bf441 Reviewed-on: https://chromium-review.googlesource.com/1187271 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585662} [modify] https://crrev.com/f7542b65f226fb53db53bfc89dbb5beee6da79a0/android_webview/browser/aw_variations_service_client.cc [modify] https://crrev.com/f7542b65f226fb53db53bfc89dbb5beee6da79a0/android_webview/common/aw_channel.cc [modify] https://crrev.com/f7542b65f226fb53db53bfc89dbb5beee6da79a0/android_webview/common/aw_channel.h [modify] https://crrev.com/f7542b65f226fb53db53bfc89dbb5beee6da79a0/android_webview/common/crash_reporter/aw_crash_reporter_client.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by kmilka@google.com
, Aug 23 2017